From 1eb77d37821a42742a9b2984c89e3aed8296a5fc Mon Sep 17 00:00:00 2001 From: tommyadam Date: Wed, 3 Jul 2013 10:22:50 +0200 Subject: Fix resource leak in directshow plugin. Add two missing release calls to free file handles. Task-number: QTBUG-23822 Change-Id: I8f5b6d0dcf9ad66bdaa2f378c0d3e401388d7add Reviewed-by: Wouter Huysentruit Reviewed-by: Yoann Lopes --- src/plugins/directshow/player/directshowplayerservice.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/plugins/directshow/player') diff --git a/src/plugins/directshow/player/directshowplayerservice.cpp b/src/plugins/directshow/player/directshowplayerservice.cpp index d89ed7bdb..70049e245 100644 --- a/src/plugins/directshow/player/directshowplayerservice.cpp +++ b/src/plugins/directshow/player/directshowplayerservice.cpp @@ -578,6 +578,9 @@ void DirectShowPlayerService::doReleaseGraph(QMutexLocker *locker) control->Release(); } + //release m_headerInfo -> decrease ref counter of m_source + m_metaDataControl->updateGraph(0, 0); + if (m_source) { m_source->Release(); m_source = 0; @@ -627,6 +630,7 @@ int DirectShowPlayerService::findStreamTypes(IBaseFilter *source) const } } } + pins->Release(); } filter->Release(); } -- cgit v1.2.3