From 9c43f48d118ff869a9a621e1cea1ed2df81d2f37 Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Thu, 14 Jan 2016 15:09:36 +0300 Subject: fix expensive iteration over QMap::keys() and QHash::keys() Change-Id: I244aa1ecf006774ebe5fb9bb5b22d37142186e39 Reviewed-by: Yoann Lopes --- src/plugins/gstreamer/camerabin/camerabinmetadata.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/plugins/gstreamer/camerabin') diff --git a/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp b/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp index e404065fc..ec2a83a66 100644 --- a/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp +++ b/src/plugins/gstreamer/camerabin/camerabinmetadata.cpp @@ -244,8 +244,8 @@ QStringList CameraBinMetaData::availableMetaData() const } QStringList res; - Q_FOREACH (const QByteArray &key, m_values.keys()) { - QString tag = keysMap.value(key); + for (auto it = m_values.keyBegin(), end = m_values.keyEnd(); it != end; ++it) { + QString tag = keysMap.value(*it); if (!tag.isEmpty()) res.append(tag); } -- cgit v1.2.3