From a1bf811b1dd287fbb75b6d27dbc163f15001e28f Mon Sep 17 00:00:00 2001
From: VaL Doroshchuk <valentyn.doroshchuk@qt.io>
Date: Tue, 10 Sep 2019 12:48:38 +0200
Subject: GStreamer: Use member initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I96026828c357677c84e880ea85e6e82b8c0495c7
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
---
 .../mediaplayer/qgstreameravailabilitycontrol.h    |  2 +-
 .../mediaplayer/qgstreamermetadataprovider.h       |  2 +-
 .../mediaplayer/qgstreamerplayerservice.cpp        | 13 ++----------
 .../mediaplayer/qgstreamerplayerservice.h          | 24 +++++++++++-----------
 .../mediaplayer/qgstreamerstreamscontrol.h         |  2 +-
 5 files changed, 17 insertions(+), 26 deletions(-)

(limited to 'src/plugins/gstreamer')

diff --git a/src/plugins/gstreamer/mediaplayer/qgstreameravailabilitycontrol.h b/src/plugins/gstreamer/mediaplayer/qgstreameravailabilitycontrol.h
index 78299b608..e100fccc8 100644
--- a/src/plugins/gstreamer/mediaplayer/qgstreameravailabilitycontrol.h
+++ b/src/plugins/gstreamer/mediaplayer/qgstreameravailabilitycontrol.h
@@ -57,7 +57,7 @@ private Q_SLOTS:
     void handleAvailabilityChanged();
 
 private:
-    QMediaPlayerResourceSetInterface *m_resources;
+    QMediaPlayerResourceSetInterface *m_resources = nullptr;
 };
 
 QT_END_NAMESPACE
diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.h b/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.h
index bf8f7e842..691453a42 100644
--- a/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.h
+++ b/src/plugins/gstreamer/mediaplayer/qgstreamermetadataprovider.h
@@ -63,7 +63,7 @@ private slots:
     void updateTags();
 
 private:
-    QGstreamerPlayerSession *m_session;
+    QGstreamerPlayerSession *m_session = nullptr;
     QVariantMap m_tags;
 };
 
diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.cpp b/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.cpp
index 0712f6e6c..44cb5439b 100644
--- a/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.cpp
+++ b/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.cpp
@@ -71,17 +71,8 @@
 
 QT_BEGIN_NAMESPACE
 
-QGstreamerPlayerService::QGstreamerPlayerService(QObject *parent):
-     QMediaService(parent)
-     , m_audioProbeControl(0)
-     , m_videoProbeControl(0)
-     , m_videoOutput(0)
-     , m_videoRenderer(0)
-     , m_videoWindow(0)
-#if defined(HAVE_WIDGETS)
-     , m_videoWidget(0)
-#endif
-     , m_videoReferenceCount(0)
+QGstreamerPlayerService::QGstreamerPlayerService(QObject *parent)
+    : QMediaService(parent)
 {
     m_session = new QGstreamerPlayerSession(this);
     m_control = new QGstreamerPlayerControl(m_session, this);
diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.h b/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.h
index ec0c0944b..f88f0ae38 100644
--- a/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.h
+++ b/src/plugins/gstreamer/mediaplayer/qgstreamerplayerservice.h
@@ -73,25 +73,25 @@ public:
     void releaseControl(QMediaControl *control) override;
 
 private:
-    QGstreamerPlayerControl *m_control;
-    QGstreamerPlayerSession *m_session;
-    QGstreamerMetaDataProvider *m_metaData;
-    QGstreamerStreamsControl *m_streamsControl;
-    QGStreamerAvailabilityControl *m_availabilityControl;
+    QGstreamerPlayerControl *m_control = nullptr;
+    QGstreamerPlayerSession *m_session = nullptr;
+    QGstreamerMetaDataProvider *m_metaData = nullptr;
+    QGstreamerStreamsControl *m_streamsControl = nullptr;
+    QGStreamerAvailabilityControl *m_availabilityControl = nullptr;
 
-    QGstreamerAudioProbeControl *m_audioProbeControl;
-    QGstreamerVideoProbeControl *m_videoProbeControl;
+    QGstreamerAudioProbeControl *m_audioProbeControl = nullptr;
+    QGstreamerVideoProbeControl *m_videoProbeControl = nullptr;
 
-    QMediaControl *m_videoOutput;
-    QMediaControl *m_videoRenderer;
-    QGstreamerVideoWindow *m_videoWindow;
+    QMediaControl *m_videoOutput = nullptr;
+    QMediaControl *m_videoRenderer = nullptr;
+    QGstreamerVideoWindow *m_videoWindow = nullptr;
 #if defined(HAVE_WIDGETS)
-    QGstreamerVideoWidgetControl *m_videoWidget;
+    QGstreamerVideoWidgetControl *m_videoWidget = nullptr;
 #endif
 
     void increaseVideoRef();
     void decreaseVideoRef();
-    int m_videoReferenceCount;
+    int m_videoReferenceCount = 0;
 };
 
 QT_END_NAMESPACE
diff --git a/src/plugins/gstreamer/mediaplayer/qgstreamerstreamscontrol.h b/src/plugins/gstreamer/mediaplayer/qgstreamerstreamscontrol.h
index 6f332c160..41932095c 100644
--- a/src/plugins/gstreamer/mediaplayer/qgstreamerstreamscontrol.h
+++ b/src/plugins/gstreamer/mediaplayer/qgstreamerstreamscontrol.h
@@ -62,7 +62,7 @@ public:
     void setActive(int streamNumber, bool state) override;
 
 private:
-    QGstreamerPlayerSession *m_session;
+    QGstreamerPlayerSession *m_session = nullptr;
 };
 
 QT_END_NAMESPACE
-- 
cgit v1.2.3