From 4149a11384a5b336f0d4d1ac8b5298ad2847028d Mon Sep 17 00:00:00 2001
From: Rainer Keller <Rainer.Keller@qt.io>
Date: Tue, 26 Jun 2018 09:49:34 +0200
Subject: example: Skip beginInsertRows in case of invalid node
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I385a9b6841887ca94cb388c07c99fbbf36bbbfb8
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
Reviewed-by: Jannis Völker <jannis.voelker@basyskom.com>
Reviewed-by: Frank Meerkoetter <frank.meerkoetter@basyskom.com>
---
 examples/opcua/opcuaviewer/treeitem.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/examples/opcua/opcuaviewer/treeitem.cpp b/examples/opcua/opcuaviewer/treeitem.cpp
index 65faf45..9f4a7d1 100644
--- a/examples/opcua/opcuaviewer/treeitem.cpp
+++ b/examples/opcua/opcuaviewer/treeitem.cpp
@@ -234,14 +234,13 @@ void TreeItem::browseFinished(QVector<QOpcUaReferenceDescription> children, QOpc
     auto index = mModel->createIndex(row(), 0, this);
 
     for (const auto &item : children) {
-        mModel->beginInsertRows(index, mChildItems.size(), mChildItems.size() + 1);
-
         auto node = mModel->opcUaClient()->node(item.nodeId());
         if (!node) {
             qWarning() << "Failed to instantiate node:" << item.nodeId();
             continue;
         }
 
+        mModel->beginInsertRows(index, mChildItems.size(), mChildItems.size() + 1);
         mChildItems.append(new TreeItem(node, mModel, item, this));
         mModel->endInsertRows();
     }
-- 
cgit v1.2.3