From 92c7c42342dc7bff5f338b5043a6f7a5650737ae Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Wed, 7 Mar 2012 17:13:48 +1000 Subject: qtmod_test.pl: enable crashreporter plugin by default on mac This is fast and safe. Enable it by default, for better details from crashing tests. Change-Id: I383186a2499b0fb4a8e8dd0697a9c71efc066734 Reviewed-by: Kalle Lehtonen --- scripts/qt/qtmod_test.pl | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'scripts/qt') diff --git a/scripts/qt/qtmod_test.pl b/scripts/qt/qtmod_test.pl index 285d11dd..f32b2c91 100755 --- a/scripts/qt/qtmod_test.pl +++ b/scripts/qt/qtmod_test.pl @@ -155,9 +155,10 @@ my @PROPERTIES = ( q{qt.tests.tee_logs} => q{like qt.tests.capture_logs, but also print the test logs to } . q{STDOUT/STDERR as normal while the tests are running}, - q{qt.tests.backtraces} => q{if 1, attempt to capture backtraces from crashing tests; } - . q{currently, this requires gdb, and is known to work on Linux } - . q{and Mac, but can be very slow on Mac}, + q{qt.tests.backtraces} => q{if 1, attempt to capture backtraces from crashing tests, } + . q{using the platform's best available mechanism; currently } + . q{uses gdb on Linux, CrashReporter on Mac, and does not work } + . q{on Windows}, q{qt.tests.flaky_mode} => q{how to handle flaky autotests ("best", "worst" or "ignore")}, @@ -249,7 +250,7 @@ sub default_qt_tests_enabled sub default_qt_tests_backtraces { my ($self) = @_; - return ($OSNAME =~ m{linux}i); + return ($OSNAME =~ m{linux|darwin}i); } sub default_qt_qtqa_tests_insignificant @@ -868,7 +869,12 @@ sub get_testrunner_command } if ($qt_tests_backtraces) { - push @testrunner_with_args, '--plugin', 'core'; + if ($OSNAME =~ m{linux}i) { + push @testrunner_with_args, '--plugin', 'core'; + } + elsif ($OSNAME =~ m{darwin}i) { + push @testrunner_with_args, '--plugin', 'crashreporter'; + } } # give more info about unstable / flaky tests -- cgit v1.2.3