summaryrefslogtreecommitdiffstats
path: root/tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp
diff options
context:
space:
mode:
authorDavid Faure <david.faure@kdab.com>2014-07-25 18:29:19 +0200
committerDavid Faure <david.faure@kdab.com>2014-07-26 00:46:13 +0200
commit8c80dd6a9893c6e323ae69b651efd7b629b2714c (patch)
tree843aa76e5125aa082419140d19e121bbb019ebf3 /tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp
parent302687f21c99643a2dd1930a19fde66ba725661e (diff)
QDeclarativeError::toString: improve handling of empty urls.
"file::2:23: ..." is strange to read. Show "<Unknown File>:2:23: ..." instead, by treating empty urls (including "file:") as unknown, and by still showing line and column numbers in such a case. This change makes it possible for QUrl::fromLocalFile("") to return an empty url rather than "file:", which this module was relying upon in the tests. Change-Id: Id6d8aaa73673283cb65cbd1316dca77f859a3f8f Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Diffstat (limited to 'tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp')
-rw-r--r--tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp b/tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp
index fde77813..a158966a 100644
--- a/tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp
+++ b/tests/auto/declarative/qdeclarativefontloader/tst_qdeclarativefontloader.cpp
@@ -140,7 +140,7 @@ void tst_qdeclarativefontloader::failLocalFont()
const QString componentStr =
QStringLiteral("import QtQuick 1.0\nFontLoader { source: \"")
+ urlString + QStringLiteral("\" }");
- const QByteArray message = QByteArrayLiteral("file::2:1: QML FontLoader: Cannot load font: \"")
+ const QByteArray message = QByteArrayLiteral("<Unknown File>:2:1: QML FontLoader: Cannot load font: \"")
+ urlString.toUtf8() + '"';
QTest::ignoreMessage(QtWarningMsg, message.constData());
QDeclarativeComponent component(&engine);
@@ -186,7 +186,7 @@ void tst_qdeclarativefontloader::redirWebFont()
void tst_qdeclarativefontloader::failWebFont()
{
QString componentStr = "import QtQuick 1.0\nFontLoader { source: \"http://localhost:14448/nonexist.ttf\" }";
- QTest::ignoreMessage(QtWarningMsg, "file::2:1: QML FontLoader: Cannot load font: \"http://localhost:14448/nonexist.ttf\"");
+ QTest::ignoreMessage(QtWarningMsg, "<Unknown File>:2:1: QML FontLoader: Cannot load font: \"http://localhost:14448/nonexist.ttf\"");
QDeclarativeComponent component(&engine);
component.setData(componentStr.toLatin1(), QUrl::fromLocalFile(""));
QDeclarativeFontLoader *fontObject = qobject_cast<QDeclarativeFontLoader*>(component.create());