From 8898cabfbf84a126257cf537b8172e799501682c Mon Sep 17 00:00:00 2001 From: Frederik Gladhorn Date: Fri, 29 Aug 2014 11:33:38 +0200 Subject: Bump version Change-Id: I8eb3593fc738554c52999119439b5f5ff32933f7 --- .qmake.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.qmake.conf b/.qmake.conf index 60effa7d..8c368751 100644 --- a/.qmake.conf +++ b/.qmake.conf @@ -1,4 +1,4 @@ load(qt_build_config) CONFIG += qt_example_installs -MODULE_VERSION = 5.3.2 +MODULE_VERSION = 5.3.3 -- cgit v1.2.3 From f09b12cea1143f1b2763064bb0d3e6592081de2b Mon Sep 17 00:00:00 2001 From: Nils Jeisecke Date: Fri, 28 Feb 2014 12:53:43 +0100 Subject: Make sure that the itemview's count property is reliable This fixes a missing countChanged signal when model changes happen while the itemview component is not completely initialized. Task-number: QTBUG-37115 Change-Id: I20c749b9e521b0292186adbecd09e1d362520881 Reviewed-by: Alan Alpert --- .../graphicsitems/qdeclarativegridview.cpp | 8 ++- .../graphicsitems/qdeclarativelistview.cpp | 8 ++- .../graphicsitems/qdeclarativepathview.cpp | 14 ++++- .../graphicsitems/qdeclarativerepeater.cpp | 11 +++- .../qdeclarativelistview/data/qtbug37115.qml | 71 ++++++++++++++++++++++ .../tst_qdeclarativelistview.cpp | 48 +++++++++++++++ 6 files changed, 152 insertions(+), 8 deletions(-) create mode 100644 tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml diff --git a/src/declarative/graphicsitems/qdeclarativegridview.cpp b/src/declarative/graphicsitems/qdeclarativegridview.cpp index 1285c877..b59eb6af 100644 --- a/src/declarative/graphicsitems/qdeclarativegridview.cpp +++ b/src/declarative/graphicsitems/qdeclarativegridview.cpp @@ -2767,8 +2767,10 @@ void QDeclarativeGridView::trackedPositionChanged() void QDeclarativeGridView::itemsInserted(int modelIndex, int count) { Q_D(QDeclarativeGridView); - if (!isComponentComplete()) + if (!isComponentComplete()) { + emit countChanged(); return; + } int index = d->visibleItems.count() ? d->mapFromModel(modelIndex) : 0; if (index < 0) { @@ -2903,8 +2905,10 @@ void QDeclarativeGridView::itemsInserted(int modelIndex, int count) void QDeclarativeGridView::itemsRemoved(int modelIndex, int count) { Q_D(QDeclarativeGridView); - if (!isComponentComplete()) + if (!isComponentComplete()) { + emit countChanged(); return; + } d->itemCount -= count; bool currentRemoved = d->currentIndex >= modelIndex && d->currentIndex < modelIndex + count; diff --git a/src/declarative/graphicsitems/qdeclarativelistview.cpp b/src/declarative/graphicsitems/qdeclarativelistview.cpp index 08e76363..48e6e532 100644 --- a/src/declarative/graphicsitems/qdeclarativelistview.cpp +++ b/src/declarative/graphicsitems/qdeclarativelistview.cpp @@ -3211,8 +3211,10 @@ void QDeclarativeListView::trackedPositionChanged() void QDeclarativeListView::itemsInserted(int modelIndex, int count) { Q_D(QDeclarativeListView); - if (!isComponentComplete()) + if (!isComponentComplete()) { + emit countChanged(); return; + } d->updateUnrequestedIndexes(); d->moveReason = QDeclarativeListViewPrivate::Other; @@ -3364,8 +3366,10 @@ void QDeclarativeListView::itemsInserted(int modelIndex, int count) void QDeclarativeListView::itemsRemoved(int modelIndex, int count) { Q_D(QDeclarativeListView); - if (!isComponentComplete()) + if (!isComponentComplete()) { + emit countChanged(); return; + } d->moveReason = QDeclarativeListViewPrivate::Other; d->updateUnrequestedIndexes(); d->itemCount -= count; diff --git a/src/declarative/graphicsitems/qdeclarativepathview.cpp b/src/declarative/graphicsitems/qdeclarativepathview.cpp index 9dec9e25..f41d0547 100644 --- a/src/declarative/graphicsitems/qdeclarativepathview.cpp +++ b/src/declarative/graphicsitems/qdeclarativepathview.cpp @@ -1476,8 +1476,13 @@ void QDeclarativePathView::itemsInserted(int modelIndex, int count) { //XXX support animated insertion Q_D(QDeclarativePathView); - if (!d->isValid() || !isComponentComplete()) + if (!d->isValid()) + return; + + if (!isComponentComplete()) { + emit countChanged(); return; + } if (d->modelCount) { d->itemCache += d->items; @@ -1506,9 +1511,14 @@ void QDeclarativePathView::itemsRemoved(int modelIndex, int count) { //XXX support animated removal Q_D(QDeclarativePathView); - if (!d->model || !d->modelCount || !d->model->isValid() || !d->path || !isComponentComplete()) + if (!d->model || !d->modelCount || !d->model->isValid() || !d->path) return; + if (!isComponentComplete()) { + emit countChanged(); + return; + } + // fix current bool currentChanged = false; if (d->currentIndex >= modelIndex + count) { diff --git a/src/declarative/graphicsitems/qdeclarativerepeater.cpp b/src/declarative/graphicsitems/qdeclarativerepeater.cpp index 0e9a9be6..9ac497a9 100644 --- a/src/declarative/graphicsitems/qdeclarativerepeater.cpp +++ b/src/declarative/graphicsitems/qdeclarativerepeater.cpp @@ -381,8 +381,10 @@ void QDeclarativeRepeater::regenerate() void QDeclarativeRepeater::itemsInserted(int index, int count) { Q_D(QDeclarativeRepeater); - if (!isComponentComplete()) + if (!isComponentComplete()) { + emit countChanged(); return; + } for (int i = 0; i < count; ++i) { int modelIndex = index + i; QDeclarativeItem *item = d->model->item(modelIndex); @@ -403,8 +405,13 @@ void QDeclarativeRepeater::itemsInserted(int index, int count) void QDeclarativeRepeater::itemsRemoved(int index, int count) { Q_D(QDeclarativeRepeater); - if (!isComponentComplete() || count <= 0) + if (count <= 0) return; + + if (!isComponentComplete()) { + emit countChanged(); + return; + } while (count--) { QDeclarativeItem *item = d->deletables.takeAt(index); emit itemRemoved(index, item); diff --git a/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml b/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml new file mode 100644 index 00000000..d6f86fca --- /dev/null +++ b/tests/auto/declarative/qdeclarativelistview/data/qtbug37115.qml @@ -0,0 +1,71 @@ +/**************************************************************************** +** +** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies). +** Contact: http://www.qt-project.org/legal +** +** This file is part of the test suite of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:LGPL$ +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and Digia. For licensing terms and +** conditions see http://qt.digia.com/licensing. For further information +** use the contact form at http://qt.digia.com/contact-us. +** +** GNU Lesser General Public License Usage +** Alternatively, this file may be used under the terms of the GNU Lesser +** General Public License version 2.1 as published by the Free Software +** Foundation and appearing in the file LICENSE.LGPL included in the +** packaging of this file. Please review the following information to +** ensure the GNU Lesser General Public License version 2.1 requirements +** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html. +** +** In addition, as a special exception, Digia gives you certain additional +** rights. These rights are described in the Digia Qt LGPL Exception +** version 1.1, included in the file LGPL_EXCEPTION.txt in this package. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3.0 as published by the Free Software +** Foundation and appearing in the file LICENSE.GPL included in the +** packaging of this file. Please review the following information to +** ensure the GNU General Public License version 3.0 requirements will be +** met: http://www.gnu.org/copyleft/gpl.html. +** +** +** $QT_END_LICENSE$ +** +****************************************************************************/ +import QtQuick 1.1 +import org.test.models 1.0 + +Rectangle { + + width: 360 + height: 360 + + ListModel { + id: m + ListElement { filter: "X*" } + } + + Repeater { + model: m + delegate: Column { + property string mfilter: model.filter + ListView { + objectName: "listview" + property int countCopy: count // without the fix this won't get updated correctly due to missing countChanged notifications + width: 100; height: 100 + TestFilterModel { + id: fm + filter: mfilter + } + model: fm + delegate: Text { text: "entry " + model.display } + } + } + } +} diff --git a/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp b/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp index eb0e0948..f2f39102 100644 --- a/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp +++ b/tests/auto/declarative/qdeclarativelistview/tst_qdeclarativelistview.cpp @@ -60,6 +60,8 @@ public: tst_QDeclarativeListView(); private slots: + void initTestCase(); + // Test both QListModelInterface and QAbstractItemModel model types void qListModelInterface_items(); void qAbstractItemModel_items(); @@ -116,6 +118,7 @@ private slots: void test_mirroring(); void orientationChange(); void contentPosJump(); + void QTBUG_37115(); private: template void items(); @@ -350,10 +353,41 @@ private: QList > list; }; +class TestFilterModel : public QSortFilterProxyModel +{ + Q_OBJECT + Q_PROPERTY(QString filter READ filter WRITE setFilter NOTIFY filterChanged) + QString m_filter; + +public: + explicit TestFilterModel(QObject *parent = 0) : QSortFilterProxyModel(parent) + { + setSourceModel(new QStringListModel(QStringList() << "AA" << "BB" << "CC", this)); + } + + QString filter() const { return m_filter; } + void setFilter(const QString &filter) + { + if (m_filter != filter) { + m_filter = filter; + setFilterWildcard(m_filter); + emit filterChanged(); + } + } + +signals: + void filterChanged(); +}; + tst_QDeclarativeListView::tst_QDeclarativeListView() { } +void tst_QDeclarativeListView::initTestCase() +{ + qmlRegisterType("org.test.models", 1, 0, "TestFilterModel"); +} + template void tst_QDeclarativeListView::items() { @@ -2721,6 +2755,20 @@ void tst_QDeclarativeListView::contentPosJump() delete canvas; } +void tst_QDeclarativeListView::QTBUG_37115() +{ + QDeclarativeView *canvas = createView(); + + canvas->setSource(QUrl::fromLocalFile(SRCDIR "/data/qtbug37115.qml")); + qApp->processEvents(); + + QDeclarativeListView *listview = findItem(canvas->rootObject(), "listview"); + QTRY_VERIFY(listview != 0); + QTRY_COMPARE(listview->property("countCopy").toInt(), 0); + + delete canvas; +} + void tst_QDeclarativeListView::qListModelInterface_items() { items(); -- cgit v1.2.3