From 67db779665b1d95a20720c0dee058c47f7df8726 Mon Sep 17 00:00:00 2001
From: Andrew den Exter <andrew.den.exter@jollamobile.com>
Date: Sat, 16 Feb 2013 17:59:50 +1000
Subject: MouseArea shouldn't grab the mouse until there is an effective drag.

A MouseArea shouldn't prevent a parent MouseArea or Flickable from
handling a drag event unless it is going to do something useful with
it.

Task-number: QTBUG-29717
Change-Id: I17caa51ebc2e547e73e727fd185e60644591ad2b
Reviewed-by: Alan Alpert <aalpert@rim.com>
---
 .../data/nestedStopAtBounds.qml                    | 44 +++++++++++++
 .../tst_qdeclarativemousearea.cpp                  | 76 ++++++++++++++++++++++
 2 files changed, 120 insertions(+)
 create mode 100644 tests/auto/declarative/qdeclarativemousearea/data/nestedStopAtBounds.qml

(limited to 'tests/auto/declarative/qdeclarativemousearea')

diff --git a/tests/auto/declarative/qdeclarativemousearea/data/nestedStopAtBounds.qml b/tests/auto/declarative/qdeclarativemousearea/data/nestedStopAtBounds.qml
new file mode 100644
index 00000000..0379964d
--- /dev/null
+++ b/tests/auto/declarative/qdeclarativemousearea/data/nestedStopAtBounds.qml
@@ -0,0 +1,44 @@
+import QtQuick 1.1
+
+Rectangle {
+    width: 400
+    height: 400
+
+    MouseArea {
+        id: outer
+        objectName: "outer"
+        x: 50
+        y: 50
+        width: 300
+        height: 300
+
+        drag.target: outer
+        drag.filterChildren: true
+
+        Rectangle {
+            anchors.fill: parent
+            color: "yellow"
+        }
+
+        MouseArea {
+            id: inner
+            objectName: "inner"
+
+            x: 0
+            y: 0
+            width: 200
+            height: 200
+
+            drag.target: inner
+            drag.minimumX: 0
+            drag.maximumX: 100
+            drag.minimumY: 0
+            drag.maximumY: 100
+
+            Rectangle {
+                anchors.fill: parent
+                color: "blue"
+            }
+        }
+    }
+}
diff --git a/tests/auto/declarative/qdeclarativemousearea/tst_qdeclarativemousearea.cpp b/tests/auto/declarative/qdeclarativemousearea/tst_qdeclarativemousearea.cpp
index b28381ef..855ad602 100644
--- a/tests/auto/declarative/qdeclarativemousearea/tst_qdeclarativemousearea.cpp
+++ b/tests/auto/declarative/qdeclarativemousearea/tst_qdeclarativemousearea.cpp
@@ -71,6 +71,8 @@ private slots:
     void preventContextMenu();
 #endif // QT_NO_CONTEXTMENU
     void changeAxis();
+    void nestedStopAtBounds();
+    void nestedStopAtBounds_data();
 
 private:
     QDeclarativeView *createView();
@@ -776,6 +778,80 @@ void tst_QDeclarativeMouseArea::changeAxis()
     delete canvas;
 }
 
+void tst_QDeclarativeMouseArea::nestedStopAtBounds_data()
+{
+    QTest::addColumn<bool>("transpose");
+    QTest::addColumn<bool>("invert");
+
+    QTest::newRow("left") << false << false;
+    QTest::newRow("right") << false << true;
+    QTest::newRow("top") << true << false;
+    QTest::newRow("bottom") << true << true;
+}
+
+void tst_QDeclarativeMouseArea::nestedStopAtBounds()
+{
+    QFETCH(bool, transpose);
+    QFETCH(bool, invert);
+
+    QDeclarativeView view;
+    view.setSource(QUrl::fromLocalFile(SRCDIR "/data/nestedStopAtBounds.qml"));
+    view.show();
+    view.activateWindow();
+    QVERIFY(QTest::qWaitForWindowExposed(&view));
+    QVERIFY(view.rootObject());
+
+    QDeclarativeMouseArea *outer =  view.rootObject()->findChild<QDeclarativeMouseArea*>("outer");
+    QVERIFY(outer);
+
+    QDeclarativeMouseArea *inner = outer->findChild<QDeclarativeMouseArea*>("inner");
+    QVERIFY(inner);
+    inner->drag()->setAxis(transpose ? QDeclarativeDrag::YAxis : QDeclarativeDrag::XAxis);
+    inner->setX(invert ? 100 : 0);
+    inner->setY(invert ? 100 : 0);
+
+    const int threshold = QApplication::startDragDistance();
+
+    QPoint position(200, 200);
+    int &axis = transpose ? position.ry() : position.rx();
+
+    QGraphicsSceneMouseEvent moveEvent(QEvent::GraphicsSceneMouseMove);
+    moveEvent.setButton(Qt::LeftButton);
+    moveEvent.setButtons(Qt::LeftButton);
+
+    // drag toward the aligned boundary.  Outer mouse area dragged.
+    QTest::mousePress(view.viewport(), Qt::LeftButton, 0, position);
+    QTest::qWait(10);
+    axis += invert ? threshold * 2 : -threshold * 2;
+    moveEvent.setScenePos(position);
+    QApplication::sendEvent(view.scene(), &moveEvent);
+    axis += invert ? threshold : -threshold;
+    moveEvent.setScenePos(position);
+    QApplication::sendEvent(view.scene(), &moveEvent);
+    QCOMPARE(outer->drag()->active(), true);
+    QCOMPARE(inner->drag()->active(), false);
+    QTest::mouseRelease(view.viewport(), Qt::LeftButton, 0, position);
+
+    QVERIFY(!outer->drag()->active());
+
+    axis = 200;
+    outer->setX(50);
+    outer->setY(50);
+
+    // drag away from the aligned boundary.  Inner mouse area dragged.
+    QTest::mousePress(view.viewport(), Qt::LeftButton, 0, position);
+    QTest::qWait(10);
+    axis += invert ? -threshold * 2 : threshold * 2;
+    moveEvent.setScenePos(position);
+    QApplication::sendEvent(view.scene(), &moveEvent);
+    axis += invert ? -threshold : threshold;
+    moveEvent.setScenePos(position);
+    QApplication::sendEvent(view.scene(), &moveEvent);
+    QCOMPARE(outer->drag()->active(), false);
+    QCOMPARE(inner->drag()->active(), true);
+    QTest::mouseRelease(view.viewport(), Qt::LeftButton, 0, position);
+}
+
 QTEST_MAIN(tst_QDeclarativeMouseArea)
 
 #include "tst_qdeclarativemousearea.moc"
-- 
cgit v1.2.3