diff options
| author | J-P Nurmi <jpnurmi@qt.io> | 2017-10-31 18:13:37 +0100 |
|---|---|---|
| committer | J-P Nurmi <jpnurmi@qt.io> | 2017-11-02 09:12:30 +0000 |
| commit | 05ba72454de8b1d4aaec304931c96d41b81ac9d2 (patch) | |
| tree | 5a35ddb3249ec1240cc6544f916f0a1dfd5b0615 | |
| parent | 02c44ee00777a76c3bf13cd0705d91435654a4c1 (diff) | |
Default: micro-optimize MenuItem
A binding to "<id>.<property>" is a tiny bit faster than a binding to
"parent.<property>". ID is a direct reference, like a pointer in C++,
whereas "parent" is a property so the binding is effectively depending
on two properties: "<property>.<property>".
The gain is not huge, but enough to show up in qmlbench. ;)
Before:
running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_menuitem.qml
[...] (10 repeats, all results between 65-66)
Average: 65.5 frames; using samples; MedianAll=66; StdDev=0.527046, CoV=0.00804651
After:
running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_menuitem.qml
[...] (10 repeats, all results between 66-67)
Average: 66.6 frames; using samples; MedianAll=67; StdDev=0.516398, CoV=0.00775372
Change-Id: Ib161fad3b11e19a4bb0f39900639131f36838d2a
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
| -rw-r--r-- | src/imports/controls/MenuItem.qml | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/imports/controls/MenuItem.qml b/src/imports/controls/MenuItem.qml index 8633c311..3562669d 100644 --- a/src/imports/controls/MenuItem.qml +++ b/src/imports/controls/MenuItem.qml @@ -99,8 +99,8 @@ T.MenuItem { implicitHeight: 40 x: 1 y: 1 - width: parent.width - 2 - height: parent.height - 2 + width: control.width - 2 + height: control.height - 2 color: control.down ? control.palette.midlight : control.highlighted ? control.palette.light : "transparent" } } |