diff options
| author | J-P Nurmi <jpnurmi@qt.io> | 2017-11-04 10:49:42 +0100 |
|---|---|---|
| committer | J-P Nurmi <jpnurmi@qt.io> | 2017-11-06 10:17:22 +0000 |
| commit | 430fe83ecb7106118cbebd735637aee9e9253914 (patch) | |
| tree | c27f1c2a5ae6a2b740467375439d8eac021e06e0 /src/quicktemplates2/qquickdial_p.h | |
| parent | 6470a54ed34523822c50ac846a17a9f76564cf58 (diff) | |
Re-order all revisioned members and add explanatory comments
We've come to realize that even though it's tempting to group similar
properties together, organizing the API so that revisions are grouped
together makes future maintenance more pleasant. It's a lot easier to
to see what was added and when.
Change-Id: I47ba7725260f2c259048848cc2a9b17bce2f01c7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Diffstat (limited to 'src/quicktemplates2/qquickdial_p.h')
| -rw-r--r-- | src/quicktemplates2/qquickdial_p.h | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/quicktemplates2/qquickdial_p.h b/src/quicktemplates2/qquickdial_p.h index 959cb154..296f7986 100644 --- a/src/quicktemplates2/qquickdial_p.h +++ b/src/quicktemplates2/qquickdial_p.h @@ -69,8 +69,9 @@ class Q_QUICKTEMPLATES2_PRIVATE_EXPORT QQuickDial : public QQuickControl Q_PROPERTY(SnapMode snapMode READ snapMode WRITE setSnapMode NOTIFY snapModeChanged FINAL) Q_PROPERTY(bool wrap READ wrap WRITE setWrap NOTIFY wrapChanged FINAL) Q_PROPERTY(bool pressed READ isPressed NOTIFY pressedChanged FINAL) - Q_PROPERTY(bool live READ live WRITE setLive NOTIFY liveChanged FINAL REVISION 2) Q_PROPERTY(QQuickItem *handle READ handle WRITE setHandle NOTIFY handleChanged FINAL) + // 2.2 (Qt 5.9) + Q_PROPERTY(bool live READ live WRITE setLive NOTIFY liveChanged FINAL REVISION 2) public: explicit QQuickDial(QQuickItem *parent = nullptr); @@ -107,12 +108,13 @@ public: bool isPressed() const; void setPressed(bool pressed); - bool live() const; - void setLive(bool live); - QQuickItem *handle() const; void setHandle(QQuickItem *handle); + // 2.2 (Qt 5.9) + bool live() const; + void setLive(bool live); + public Q_SLOTS: void increase(); void decrease(); @@ -127,9 +129,10 @@ Q_SIGNALS: void snapModeChanged(); void wrapChanged(); void pressedChanged(); - Q_REVISION(2) void liveChanged(); void handleChanged(); + // 2.2 (Qt 5.9) Q_REVISION(2) void moved(); + Q_REVISION(2) void liveChanged(); protected: void keyPressEvent(QKeyEvent *event) override; |