aboutsummaryrefslogtreecommitdiffstats
path: root/src/quicktemplates2/qquickmenu.cpp
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@qt.io>2017-07-10 12:46:45 +0200
committerJ-P Nurmi <jpnurmi@qt.io>2017-07-10 11:24:08 +0000
commit83541427f555b73bcc0f8687adb6e81acf32c9ef (patch)
treea479b7eb699c40ac89d63b7176a74b2d5934bc2a /src/quicktemplates2/qquickmenu.cpp
parent0c9ef2ef271db212380147b406eea860bd9e6231 (diff)
QQuickMenu: use key press instead of key release events
In general, when shortcuts override key press events, the respective key release events are still sent. Therefore, in order to respect shortcuts, key navigation should be based on key press events. Key release -based navigation is also not going to work with nested menus in a menubar, because a leaf menu may need to propagate key events up to the parent menus and finally to the menubar, but only if keys are not actually handled. Change-Id: Ia040a387adc782d8828250fbed393ef1794f2148 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/quicktemplates2/qquickmenu.cpp')
-rw-r--r--src/quicktemplates2/qquickmenu.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/quicktemplates2/qquickmenu.cpp b/src/quicktemplates2/qquickmenu.cpp
index f91498fd..6fce1969 100644
--- a/src/quicktemplates2/qquickmenu.cpp
+++ b/src/quicktemplates2/qquickmenu.cpp
@@ -1194,10 +1194,10 @@ void QQuickMenu::itemChange(QQuickItem::ItemChange change, const QQuickItem::Ite
}
}
-void QQuickMenu::keyReleaseEvent(QKeyEvent *event)
+void QQuickMenu::keyPressEvent(QKeyEvent *event)
{
Q_D(QQuickMenu);
- QQuickPopup::keyReleaseEvent(event);
+ QQuickPopup::keyPressEvent(event);
if (d->contentModel->count() == 0)
return;