diff options
| author | J-P Nurmi <jpnurmi@qt.io> | 2017-11-04 10:49:42 +0100 |
|---|---|---|
| committer | J-P Nurmi <jpnurmi@qt.io> | 2017-11-06 10:17:22 +0000 |
| commit | 430fe83ecb7106118cbebd735637aee9e9253914 (patch) | |
| tree | c27f1c2a5ae6a2b740467375439d8eac021e06e0 /src/quicktemplates2/qquicktumbler_p.h | |
| parent | 6470a54ed34523822c50ac846a17a9f76564cf58 (diff) | |
Re-order all revisioned members and add explanatory comments
We've come to realize that even though it's tempting to group similar
properties together, organizing the API so that revisions are grouped
together makes future maintenance more pleasant. It's a lot easier to
to see what was added and when.
Change-Id: I47ba7725260f2c259048848cc2a9b17bce2f01c7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Diffstat (limited to 'src/quicktemplates2/qquicktumbler_p.h')
| -rw-r--r-- | src/quicktemplates2/qquicktumbler_p.h | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/quicktemplates2/qquicktumbler_p.h b/src/quicktemplates2/qquicktumbler_p.h index b71a7636..de7de595 100644 --- a/src/quicktemplates2/qquicktumbler_p.h +++ b/src/quicktemplates2/qquicktumbler_p.h @@ -66,7 +66,9 @@ class Q_QUICKTEMPLATES2_PRIVATE_EXPORT QQuickTumbler : public QQuickControl Q_PROPERTY(QQuickItem *currentItem READ currentItem NOTIFY currentItemChanged FINAL) Q_PROPERTY(QQmlComponent *delegate READ delegate WRITE setDelegate NOTIFY delegateChanged FINAL) Q_PROPERTY(int visibleItemCount READ visibleItemCount WRITE setVisibleItemCount NOTIFY visibleItemCountChanged FINAL) + // 2.1 (Qt 5.8) Q_PROPERTY(bool wrap READ wrap WRITE setWrap RESET resetWrap NOTIFY wrapChanged FINAL REVISION 1) + // 2.2 (Qt 5.9) Q_PROPERTY(bool moving READ isMoving NOTIFY movingChanged FINAL REVISION 2) public: @@ -88,14 +90,16 @@ public: int visibleItemCount() const; void setVisibleItemCount(int visibleItemCount); + static QQuickTumblerAttached *qmlAttachedProperties(QObject *object); + + // 2.1 (Qt 5.8) bool wrap() const; void setWrap(bool wrap); void resetWrap(); + // 2.2 (Qt 5.9) bool isMoving() const; - static QQuickTumblerAttached *qmlAttachedProperties(QObject *object); - Q_SIGNALS: void modelChanged(); void countChanged(); @@ -103,7 +107,9 @@ Q_SIGNALS: void currentItemChanged(); void delegateChanged(); void visibleItemCountChanged(); + // 2.1 (Qt 5.8) Q_REVISION(1) void wrapChanged(); + // 2.2 (Qt 5.9) Q_REVISION(2) void movingChanged(); protected: |