diff options
| author | J-P Nurmi <jpnurmi@qt.io> | 2017-10-31 19:54:40 +0100 |
|---|---|---|
| committer | J-P Nurmi <jpnurmi@qt.io> | 2017-11-02 11:59:03 +0000 |
| commit | c3481c3115f1881ba0ac61ca478c7ec7f74aef5a (patch) | |
| tree | 28dd63a0012feee10a031bc7730992ce18a4a5f7 /src | |
| parent | f24a76bea9bf033e6f2eea70ea9cdb43cdb8f6f9 (diff) | |
Optimize ProgressBar
Control's padding is supposed to be content padding, not background
padding. The background has a fixed height, so it's enough to set the
Y-coordinate to keep it vertically center aligned.
running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_progressbar.qml
[...]
Average: 205.8 frames; using samples; MedianAll=206; StdDev=1.30384, CoV=0.00633547
After:
running: qmlbench/benchmarks/auto/creation/quick.controls2/delegates_progressbar.qml
[...]
Average: 214.4 frames; using samples; MedianAll=214; StdDev=3.20936, CoV=0.014969
Change-Id: I4900bf496effa52e9291192e05ed95f4a44fbea4
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/imports/controls/ProgressBar.qml | 4 | ||||
| -rw-r--r-- | src/imports/controls/material/ProgressBar.qml | 4 | ||||
| -rw-r--r-- | src/imports/controls/universal/ProgressBar.qml | 5 |
3 files changed, 3 insertions, 10 deletions
diff --git a/src/imports/controls/ProgressBar.qml b/src/imports/controls/ProgressBar.qml index ff760099..00cdb28f 100644 --- a/src/imports/controls/ProgressBar.qml +++ b/src/imports/controls/ProgressBar.qml @@ -59,9 +59,7 @@ T.ProgressBar { background: Rectangle { implicitWidth: 200 implicitHeight: 6 - x: control.leftPadding - y: control.topPadding + (control.availableHeight - height) / 2 - width: control.availableWidth + y: (control.height - height) / 2 height: 6 color: control.palette.midlight diff --git a/src/imports/controls/material/ProgressBar.qml b/src/imports/controls/material/ProgressBar.qml index 06682285..3a20bbee 100644 --- a/src/imports/controls/material/ProgressBar.qml +++ b/src/imports/controls/material/ProgressBar.qml @@ -59,9 +59,7 @@ T.ProgressBar { background: Rectangle { implicitWidth: 200 implicitHeight: 4 - x: control.leftPadding - y: control.topPadding + (control.availableHeight - height) / 2 - width: control.availableWidth + y: (control.height - height) / 2 height: 4 color: Qt.rgba(control.Material.accentColor.r, control.Material.accentColor.g, control.Material.accentColor.b, 0.25) diff --git a/src/imports/controls/universal/ProgressBar.qml b/src/imports/controls/universal/ProgressBar.qml index 20a2932d..9b8be7d3 100644 --- a/src/imports/controls/universal/ProgressBar.qml +++ b/src/imports/controls/universal/ProgressBar.qml @@ -59,10 +59,7 @@ T.ProgressBar { background: Rectangle { implicitWidth: 100 implicitHeight: 10 - - x: control.leftPadding - y: control.topPadding + (control.availableHeight - height) / 2 - width: control.availableWidth + y: (control.height - height) / 2 height: 10 visible: !control.indeterminate |