aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorKonstantin Ritt <ritt.ks@gmail.com>2017-11-03 11:13:44 +0400
committerJ-P Nurmi <jpnurmi@qt.io>2017-11-08 10:34:51 +0000
commita0559ea88be32e19e83b2131cb26e61e873dc817 (patch)
tree56fb4ccc44e192063afb717dfa22ea88cbde10f7 /src
parentf46776cc68f88a8cbc518cacf6c63f31f11d73b0 (diff)
DialogButtonBox: micro optimization for resizeContent()
Change-Id: Ie72671fb92108dfaf5aaae4ea3ffb279e14b2f1a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/quicktemplates2/qquickdialogbuttonbox.cpp15
1 files changed, 6 insertions, 9 deletions
diff --git a/src/quicktemplates2/qquickdialogbuttonbox.cpp b/src/quicktemplates2/qquickdialogbuttonbox.cpp
index 1b50346c..5f7f488e 100644
--- a/src/quicktemplates2/qquickdialogbuttonbox.cpp
+++ b/src/quicktemplates2/qquickdialogbuttonbox.cpp
@@ -172,13 +172,13 @@ static QRectF alignedRect(Qt::LayoutDirection direction, Qt::Alignment alignment
qreal w = size.width();
qreal h = size.height();
if ((alignment & Qt::AlignVCenter) == Qt::AlignVCenter)
- y += rectangle.size().height() / 2 - h / 2;
+ y += (rectangle.size().height() - h) / 2;
else if ((alignment & Qt::AlignBottom) == Qt::AlignBottom)
y += rectangle.size().height() - h;
if ((alignment & Qt::AlignRight) == Qt::AlignRight)
x += rectangle.size().width() - w;
else if ((alignment & Qt::AlignHCenter) == Qt::AlignHCenter)
- x += rectangle.size().width() / 2 - w / 2;
+ x += (rectangle.size().width() - w) / 2;
return QRectF(x, y, w, h);
}
@@ -188,15 +188,12 @@ void QQuickDialogButtonBoxPrivate::resizeContent()
if (!contentItem)
return;
- const int halign = alignment & Qt::AlignHorizontal_Mask;
- const int valign = alignment & Qt::AlignVertical_Mask;
-
- const qreal cw = !halign ? q->availableWidth() : contentItem->implicitWidth();
- const qreal ch = !valign ? q->availableHeight() : contentItem->implicitHeight();
-
QRectF geometry = q->boundingRect().adjusted(q->leftPadding(), q->topPadding(), -q->rightPadding(), -q->bottomPadding());
- if (halign || valign)
+ if (alignment != 0) {
+ qreal cw = (alignment & Qt::AlignHorizontal_Mask) == 0 ? q->availableWidth() : contentItem->implicitWidth();
+ qreal ch = (alignment & Qt::AlignVertical_Mask) == 0 ? q->availableHeight() : contentItem->implicitHeight();
geometry = alignedRect(q->isMirrored() ? Qt::RightToLeft : Qt::LeftToRight, alignment, QSizeF(cw, ch), geometry);
+ }
contentItem->setPosition(geometry.topLeft());
contentItem->setSize(geometry.size());