CheckDelegate: add support for icons

Task-number: QTBUG-49820
Change-Id: I8644767d8d739337af1fe0fd29f87fea300752fb
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

1 files changed, 81 insertions, 0 deletions

diff --git a/tests/auto/controls/data/tst_checkdelegate.qml b/tests/auto/controls/data/tst_checkdelegate.qml
index 8933a7dd..f13d6d49 100644
--- a/tests/auto/controls/data/tst_checkdelegate.qml
+++ b/tests/auto/controls/data/tst_checkdelegate.qml
@@ -89,4 +89,85 @@ TestCase {
         verify(control);
         compare(control.baselineOffset, control.contentItem.y + control.contentItem.baselineOffset);
     }
+
+    function test_spacing() {
+        var control = createTemporaryObject(checkDelegate, testCase, { text: "Some long, long, long text" })
+        verify(control)
+        verify(control.contentItem.implicitWidth + control.leftPadding + control.rightPadding > control.background.implicitWidth)
+
+        var textLabel = findChild(control.contentItem, "label")
+        verify(textLabel)
+
+        // The implicitWidth of the IconLabel that all buttons use as their contentItem should be
+        // equal to the implicitWidth of the Text and the check indicator + spacing while no icon is set.
+        compare(control.contentItem.implicitWidth, textLabel.implicitWidth + control.indicator.width + control.spacing)
+
+        control.spacing += 100
+        compare(control.contentItem.implicitWidth, textLabel.implicitWidth + control.indicator.width + control.spacing)
+
+        compare(control.implicitWidth, textLabel.implicitWidth + control.indicator.width + control.spacing + control.leftPadding + control.rightPadding)
+    }
+
+    function test_display_data() {
+        return [
+            { "tag": "IconOnly", display: CheckDelegate.IconOnly },
+            { "tag": "TextOnly", display: CheckDelegate.TextOnly },
+            { "tag": "TextUnderIcon", display: CheckDelegate.TextUnderIcon },
+            { "tag": "TextBesideIcon", display: CheckDelegate.TextBesideIcon },
+            { "tag": "IconOnly, mirrored", display: CheckDelegate.IconOnly, mirrored: true },
+            { "tag": "TextOnly, mirrored", display: CheckDelegate.TextOnly, mirrored: true },
+            { "tag": "TextUnderIcon, mirrored", display: CheckDelegate.TextUnderIcon, mirrored: true },
+            { "tag": "TextBesideIcon, mirrored", display: CheckDelegate.TextBesideIcon, mirrored: true }
+        ]
+    }
+
+    function test_display(data) {
+        var control = createTemporaryObject(checkDelegate, testCase, {
+            text: "CheckDelegate",
+            display: data.display,
+            width: 400,
+            "icon.source": "qrc:/qt-project.org/imports/QtQuick/Controls.2/images/check.png",
+            "LayoutMirroring.enabled": !!data.mirrored
+        })
+        verify(control)
+        verify(control.icon.source.length > 0)
+
+        var iconImage = findChild(control.contentItem, "image")
+        var textLabel = findChild(control.contentItem, "label")
+
+        var availableWidth = control.availableWidth - control.indicator.width - control.spacing
+        var indicatorOffset = control.mirrored ? control.indicator.width + control.spacing : 0
+
+        switch (control.display) {
+        case CheckDelegate.IconOnly:
+            verify(iconImage)
+            verify(!textLabel)
+            compare(iconImage.x, indicatorOffset + (availableWidth - iconImage.width) / 2)
+            compare(iconImage.y, (control.availableHeight - iconImage.height) / 2)
+            break;
+        case CheckDelegate.TextOnly:
+            verify(!iconImage)
+            verify(textLabel)
+            compare(textLabel.x, control.mirrored ? control.availableWidth - textLabel.width : 0)
+            compare(textLabel.y, (control.availableHeight - textLabel.height) / 2)
+            break;
+        case CheckDelegate.TextUnderIcon:
+            verify(iconImage)
+            verify(textLabel)
+            compare(iconImage.x, indicatorOffset + (availableWidth - iconImage.width) / 2)
+            compare(textLabel.x, indicatorOffset + (availableWidth - textLabel.width) / 2)
+            verify(iconImage.y < textLabel.y)
+            break;
+        case CheckDelegate.TextBesideIcon:
+            verify(iconImage)
+            verify(textLabel)
+            if (control.mirrored)
+                verify(textLabel.x < iconImage.x)
+            else
+                verify(iconImage.x < textLabel.x)
+            compare(iconImage.y, (control.availableHeight - iconImage.height) / 2)
+            compare(textLabel.y, (control.availableHeight - textLabel.height) / 2)
+            break;
+        }
+    }
 }