aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/controls/data/tst_spinbox.qml
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@qt.io>2018-03-23 10:44:05 +0100
committerJ-P Nurmi <jpnurmi@qt.io>2018-03-23 12:14:43 +0000
commit2acf527d54049cfb17d1d2aaf4d77c97716e1dc6 (patch)
tree57c803313e941b13f8c58d30100425c6b43fd204 /tests/auto/controls/data/tst_spinbox.qml
parent9529225c849ee8e697767350cbb08e5f2845681b (diff)
Combo|SpinBox: fix wheel event propagation
Sync the behavior with Qt Widgets. Don't propagate wheel events when reaching the end. The behavior was not nice, that a ScrollView underneath started suddenly moving whilst these input controls had input focus. Task-number: QTBUG-66044 Change-Id: I1b9c7f005652041cd82c77d4a1ca1a01d7d536e9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'tests/auto/controls/data/tst_spinbox.qml')
-rw-r--r--tests/auto/controls/data/tst_spinbox.qml17
1 files changed, 14 insertions, 3 deletions
diff --git a/tests/auto/controls/data/tst_spinbox.qml b/tests/auto/controls/data/tst_spinbox.qml
index 9568da1a..47c19f40 100644
--- a/tests/auto/controls/data/tst_spinbox.qml
+++ b/tests/auto/controls/data/tst_spinbox.qml
@@ -71,6 +71,11 @@ TestCase {
SpinBox { }
}
+ Component {
+ id: mouseArea
+ MouseArea { }
+ }
+
function test_defaults() {
var control = createTemporaryObject(spinBox, testCase)
verify(control)
@@ -401,7 +406,10 @@ TestCase {
}
function test_wheel(data) {
- var control = createTemporaryObject(spinBox, testCase, {wrap: data.wrap, from: data.from, to: data.to, value: data.value, stepSize: data.stepSize, wheelEnabled: true})
+ var ma = createTemporaryObject(mouseArea, testCase, {width: 100, height: 100})
+ verify(ma)
+
+ var control = spinBox.createObject(ma, {wrap: data.wrap, from: data.from, to: data.to, value: data.value, stepSize: data.stepSize, wheelEnabled: true})
verify(control)
var valueModifiedCount = 0
@@ -410,13 +418,16 @@ TestCase {
var delta = 120
+ var spy = signalSpy.createObject(ma, {target: ma, signalName: "wheel"})
+ verify(spy.valid)
+
for (var u = 0; u < data.upSteps.length; ++u) {
var wasUpEnabled = control.wrap || control.value < control.to
mouseWheel(control, control.width / 2, control.height / 2, delta, delta)
if (wasUpEnabled)
++valueModifiedCount
compare(valueModifiedSpy.count, valueModifiedCount)
-
+ compare(spy.count, 0) // no propagation
compare(control.value, data.upSteps[u])
}
@@ -426,7 +437,7 @@ TestCase {
if (wasDownEnabled)
++valueModifiedCount
compare(valueModifiedSpy.count, valueModifiedCount)
-
+ compare(spy.count, 0) // no propagation
compare(control.value, data.downSteps[d])
}
}