GitRecorder: don't warn on empty outputFileName.

If it's empty, we generate it for the user.

Change-Id: I4f02fcd603eb0c3c4ebba4838bcbd45f20ad6414
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>

2 files changed, 4 insertions, 6 deletions

diff --git a/tests/manual/gifs/gifrecorder.cpp b/tests/manual/gifs/gifrecorder.cpp
index e684181c..7df35548 100644
--- a/tests/manual/gifs/gifrecorder.cpp
+++ b/tests/manual/gifs/gifrecorder.cpp
@@ -89,7 +89,6 @@ void GifRecorder::setOutputDir(const QDir &dir)
 
 void GifRecorder::setOutputFileName(const QString &fileName)
 {
-    QVERIFY2(!fileName.isEmpty(), "Output file name cannot be empty");
     mOutputFileName = fileName;
 }
 
@@ -119,8 +118,10 @@ void GifRecorder::start()
     mView->requestActivate();
     QVERIFY(QTest::qWaitForWindowActive(mView, 500));
 
-    mOutputFileName = mOutputDir.absoluteFilePath(mQmlInputFileName);
-    mOutputFileName.replace(".qml", ".gif");
+    if (mOutputFileName.isEmpty()) {
+        mOutputFileName = mOutputDir.absoluteFilePath(mQmlInputFileName);
+        mOutputFileName.replace(".qml", ".gif");
+    }
 
     QStringList args;
     args << "-d" << QString::number(mRecordingDuration) << "-v";
diff --git a/tests/manual/gifs/tst_gifs.cpp b/tests/manual/gifs/tst_gifs.cpp
index babf143a..f61f609f 100644
--- a/tests/manual/gifs/tst_gifs.cpp
+++ b/tests/manual/gifs/tst_gifs.cpp
@@ -78,7 +78,6 @@ void tst_Gifs::tumblerWrap()
     gifRecorder.setOutputDir(outputDir);
     gifRecorder.setRecordingDuration(4);
     gifRecorder.setQmlFileName("qtquickextras2-tumbler-wrap.qml");
-    gifRecorder.setOutputFileName("wrap.gif");
     gifRecorder.setView(&view);
 
     view.show();
@@ -151,8 +150,6 @@ void tst_Gifs::slider()
     gifRecorder.setOutputDir(outputDir);
     gifRecorder.setRecordingDuration(3);
     gifRecorder.setQmlFileName("qtquickcontrols2-slider.qml");
-    // TODO: default to replacing .qml with .gif if outputFileName is empty.
-    gifRecorder.setOutputFileName("qtquickcontrols2-slider.gif");
     gifRecorder.setView(&view);
 
     view.show();