aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/quicktemplates2/qquickmenuitem.cpp40
-rw-r--r--src/quicktemplates2/qquickmenuitem_p.h3
-rw-r--r--src/quicktemplates2/qquickmenuitem_p_p.h5
3 files changed, 44 insertions, 4 deletions
diff --git a/src/quicktemplates2/qquickmenuitem.cpp b/src/quicktemplates2/qquickmenuitem.cpp
index f71b9c35..6693d4f8 100644
--- a/src/quicktemplates2/qquickmenuitem.cpp
+++ b/src/quicktemplates2/qquickmenuitem.cpp
@@ -37,6 +37,7 @@
#include "qquickmenuitem_p.h"
#include "qquickmenuitem_p_p.h"
#include "qquickmenu_p.h"
+#include "qquickdeferredexecute_p_p.h"
#include <QtGui/qpa/qplatformtheme.h>
#include <QtQuick/private/qquickevents_p_p.h>
@@ -134,6 +135,26 @@ void QQuickMenuItemPrivate::updateEnabled()
q->setEnabled(subMenu && subMenu->isEnabled());
}
+static inline QString arrowName() { return QStringLiteral("arrow"); }
+
+void QQuickMenuItemPrivate::cancelArrow()
+{
+ Q_Q(QQuickAbstractButton);
+ quickCancelDeferred(q, arrowName());
+}
+
+void QQuickMenuItemPrivate::executeArrow(bool complete)
+{
+ Q_Q(QQuickMenuItem);
+ if (arrow.wasExecuted())
+ return;
+
+ if (!arrow || complete)
+ quickBeginDeferred(q, arrowName(), arrow);
+ if (complete)
+ quickCompleteDeferred(q, arrowName(), arrow);
+}
+
/*!
\qmlsignal void QtQuick.Controls::MenuItem::triggered()
@@ -183,7 +204,9 @@ void QQuickMenuItem::setHighlighted(bool highlighted)
*/
QQuickItem *QQuickMenuItem::arrow() const
{
- Q_D(const QQuickMenuItem);
+ QQuickMenuItemPrivate *d = const_cast<QQuickMenuItemPrivate *>(d_func());
+ if (!d->arrow)
+ d->executeArrow();
return d->arrow;
}
@@ -193,11 +216,15 @@ void QQuickMenuItem::setArrow(QQuickItem *arrow)
if (d->arrow == arrow)
return;
- QQuickControlPrivate::destroyDelegate(d->arrow, this);
+ if (!d->arrow.isExecuting())
+ d->cancelArrow();
+
+ delete d->arrow;
d->arrow = arrow;
if (arrow && !arrow->parentItem())
arrow->setParentItem(this);
- emit arrowChanged();
+ if (!d->arrow.isExecuting())
+ emit arrowChanged();
}
/*!
@@ -228,6 +255,13 @@ QQuickMenu *QQuickMenuItem::subMenu() const
return d->subMenu;
}
+void QQuickMenuItem::componentComplete()
+{
+ Q_D(QQuickMenuItem);
+ d->executeArrow(true);
+ QQuickAbstractButton::componentComplete();
+}
+
QFont QQuickMenuItem::defaultFont() const
{
return QQuickControlPrivate::themeFont(QPlatformTheme::MenuItemFont);
diff --git a/src/quicktemplates2/qquickmenuitem_p.h b/src/quicktemplates2/qquickmenuitem_p.h
index 8af3cbd1..7cffd97b 100644
--- a/src/quicktemplates2/qquickmenuitem_p.h
+++ b/src/quicktemplates2/qquickmenuitem_p.h
@@ -63,6 +63,7 @@ class Q_QUICKTEMPLATES2_PRIVATE_EXPORT QQuickMenuItem : public QQuickAbstractBut
Q_PROPERTY(QQuickItem *arrow READ arrow WRITE setArrow NOTIFY arrowChanged FINAL REVISION 3)
Q_PROPERTY(QQuickMenu *menu READ menu NOTIFY menuChanged FINAL REVISION 3)
Q_PROPERTY(QQuickMenu *subMenu READ subMenu NOTIFY subMenuChanged FINAL REVISION 3)
+ Q_CLASSINFO("DeferredPropertyNames", "arrow,background,contentItem,indicator")
public:
explicit QQuickMenuItem(QQuickItem *parent = nullptr);
@@ -86,6 +87,8 @@ Q_SIGNALS:
Q_REVISION(3) void subMenuChanged();
protected:
+ void componentComplete() override;
+
QFont defaultFont() const override;
QPalette defaultPalette() const override;
diff --git a/src/quicktemplates2/qquickmenuitem_p_p.h b/src/quicktemplates2/qquickmenuitem_p_p.h
index e0e90ff1..5deea6e3 100644
--- a/src/quicktemplates2/qquickmenuitem_p_p.h
+++ b/src/quicktemplates2/qquickmenuitem_p_p.h
@@ -72,8 +72,11 @@ public:
void updateEnabled();
+ void cancelArrow();
+ void executeArrow(bool complete = false);
+
bool highlighted;
- QQuickItem *arrow;
+ QQuickDeferredPointer<QQuickItem> arrow;
QQuickMenu *menu;
QQuickMenu *subMenu;
};