| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I2389ce274d609c13055e82408f38d30c6e921e5c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
| |
Change-Id: If3c56e80803135ac7e1ce99033da8e3dd09ad7a9
|
|
|
|
|
|
|
| |
According to https://material.io/design/components/buttons.html#text-button
Change-Id: Ia36a676864a8f738d204cf8db9430b797f1f2f99
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: Ib83e2ec925e0c37b40562aea7f11e09759ce3abc
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise we cannot interpret them as the original key sequence anymore.
When passing them on they are interpreted as the number key that
represents the numeric value of the key sequence enum.
Change-Id: Idd94ef95bc693cb6d51162dd1994adc953b52e25
Fixes: QTBUG-75572
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The cursor flash iterval can sometimes be set to 0. This is done
from e.g the iOS plugin while selecting text, since the
cursor should not flash when the user is dragging it around
inside a magnifier glass. Setting the interval to 0 simply
means "don't flash", rather than "hide the cursor". But
setting the interval of a QML Timer to 0 will cause it to
never trigger, which is not what we want, since then the
cursor can end up staying hidden if done in-between two
"flashes".
This patch will add an extra condition that checks for this case.
Fixes: QTBUG-75844
Change-Id: Ib1ca594a49a18cb161a2b2a67928fb6766984988
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
| |
Instead of casting to int and back to enum, just use the enum directly.
Change-Id: Ifbd6a74ee499ffaeb99b0b4274cd59365833bfbd
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current behavior is to always decrement the currentIndex when the current item
is removed -- even when the current item is item 0. This means, for example,
that in a TabBar with three tabs and the first tab selected closing the first
tab will leave nothing at all selected.
Change behavior to keep currentIndex at 0 if there are still items left in the
container. Now closing the first tab will leave the next remaining tab selected.
Change-Id: If4e1903366e29fcee8226b776d5b2e03cec189df
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The important part of the "cascading" test is checking that the sub-sub
menu eventually opens, so move the !visible check to the non-cascading
branch of the if statement.
Change-Id: I5a09bf0b5d45832f7b75c3e8c397fdb9e6fcc011
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Short version:
There are currently two problems with MenuItems:
- Mirrored MenuItems don't fill the Menu's available width.
- MenuItem does not fill the Menu's available width when changed
after Component completion.
This patch fixes both of them by listening to geometry changes in both
the contentItem and individual menu items, and setting the explicit
width of those menu items when either changes.
Longer version:
The first problem can be seen whenever the MenuItem's implicitWidth
changes:
- QQmlEngine::retranslate() is called, causing all bindings to be
re-evaluated
- The MenuItem's font size changes
- The MenuItem's icon size changes
- etc.
We fix this by making Menu listen to the width of each of its MenuItems
and call resizeItem() if it doesn't have an explicit width.
The second problem can be seen when e.g. resizing a Menu to account
for new items that are wider and hence require more space.
This can be fixed by listening to width changes in Menu's contentItem,
which was actually done in earlier versions but (probably accidentally)
removed in 482ecb0f.
I had tried to solve both issues by setting the explicit width of
MenuItem to the width of its Menu, or undefined if it has none
(which means it reverts to its implicit width). However, this does
not account for e.g. MenuSeparator and custom items that can be added
to Menu - they should also have their width fill the Menu automatically
if they don't have an explicit width set.
Change-Id: I95dd0da0919a1e297f2e2030da746ff1f1a17644
Fixes: QTBUG-75051
Fixes: QTBUG-75142
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for ensuring that an Imagine-style-specific fix
works.
Fixes: QTBUG-75141
Change-Id: Iafef3bf947151cb35b88a1230e3541d8e4e15fd9
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
| |
Change-Id: Idecee26bcae178ed294c062819f55e12a65af37d
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: Ibde952a165c9e0fb40133ce554e90ba35c93feee
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
qtbase/mkspecs/features/testcase.prf already generates a .qrc file
containing the files in TESTDATA, so instead of trying to copy QML
files to the device, we can just use the existing resources.
This fixes the following failure, which affects all tests using
util.pri:
FAIL! : tst_cursor::initTestCase() 'QDir::setCurrent(m_directory)' returned FALSE. (Could not chdir to :/)
Change-Id: I1fd7449437be045a7230a7679e24252cdf9c0ccc
Fixes: QTBUG-73604
Fixes: QTBUG-73606
Fixes: QTBUG-73607
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
Connect to the QQuickAccessibleAttached::increaseAction() and
QQuickAccessibleAttached::decreaseAction() signals.
Change-Id: I9d6b37ac68d8790edcb3d4d72f155ec8511cabe2
Fixes: QTBUG-75072
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
|\
| |
| |
| | |
Change-Id: Ib631757c6c4d4bfeef0fe34d625139f29fa3f2d0
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
+ 16836da1ae44c11317b9861764ea55cce39eac02 Page: fix binding loop
+ feed3b7b8077f2c9bba72c49e249fb96c262d72e Drawer: fix infinite positioning loop
+ fa641ab12340fa128668318a1fe7c6a01906f163 Add dialogs manual test
+ 951bfc041f1f43272f73d9cbc47100060c379c0c Doc: restructure and fill in Imagine customization section
+ d45d163240fca2fcdec445f1d8622062ad90bdd8 Doc: state that negative scales for Popup are not supported
+ 637630cc7ed0e6efd43678b11d1309e72a957874 Remove the internal_module config to enable generation of cmake files
+ 05eb8127594f0d40247e8c84a4704277dd12d16e QQuickMenu: allow enter/return to be used to activate items
+ 694438066eb88e53e4070630e6b99d0f552d254d qtlite: Fix build the source code with -no-feature-shortcut
+ 9fdbdea176007ed7b470e317e9002aa77ddd4ead Fix tst_cursor::controls(containers) test failing after change in the Windows QPA
+ ff30fc5f5f637da6a06a33ae0e55d5e4b798099d QQuickScrollView: respect the content size set on/by the flickable
+ 73914e00dba2fe259108197d01b6744ce16b63d8 Add *.pro.user.* to .gitignore
+ 1ef176b5da8ad8d4993fa9296e64e44ee8de6560 Fix attached ToolTips using the timeout of the last shown tool tip
+ 8b78d9cea3091b0bd94d1ae0c71a000f8e7e1903 Fix DialogButtonBox content size calculation
+ 0ee25027edf1be38412e2a397c1c0a71d2bd146b Handle recursion depth errors in tst_sanity.cpp
+ 27e030f24b05dac56189c34951da38fd68dc64a1 Bump version
+ 5a07a970fa9d73fc2c4da8966fadcb35d142c7f5 QQuickComboBox: ensure we don't close popup on iOS
+ 5135bec50762955b3a1138ecda10214a9d0bf62a DialogButtonBox: don't sort buttons based on their memory addresses
+ 11995169ee09a99ef1af4c778e30e25829c635b4 Mark BaseValidator::throwRecursionDepthError() as final
+ 10023b188bb84d631fea53baa9ce5997f3fc286d Default: fix highlighted ItemDelegate colors
+ d0f6b28618f7252f3f7c915a6a91a153f350e354 Fix typo in ScrollBar's documentation
+ 7c31b884b932034bb907db638f155b813d90aff2 Attempt to stabilize Tumbler::test_itemsCorrectlyPositioned
+ ef9ab1a4bd4e3545cfb1c23c002e58b3e078ed75 tst_dialogbuttonbox.qml: use tryVerify() consistently to avoid flakiness
+ 1bb25edd6c30e163976afa43065671ffcb56d6f4 tst_dialogbuttonbox.qml: consolidate two similar tests
Change-Id: I32bc2dc040808d8b556e5231e1d2b77a50138b4e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The ComboBox popup should be closed when the ComboBox loses focus, but
not if the control gaining focus is the popup itself. While all the
styles implemented in this module implement the ComboBox popup as an
unfocusable window and handle all the keyboard events in QQuickComboBox
itself, the developer can choose to replace the popup with a custom
implementation, which might need the keyboard focus.
Fixes: QTBUG-74661
Change-Id: I838ab9cb697df63ea2099e68f1ae99eadb06be08
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Mention what happens if its contentItem has no implicit size and only
one child item.
Change-Id: I646ca2baad89ac195836268b14108b43beaec2bf
Fixes: QTBUG-69096
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-74902
Change-Id: I3f77459028de48729bb78353d8d95e92c7fc98f6
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We also need to update the hovered state of each indicator when
the mouse is moved while pressed, not just when we get hover move
events.
Change-Id: I6fa71344fd540f648683958e5804ae735523e72d
Fixes: QTBUG-74688
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Although the doc project is named QtQuickControls,
the repo is still called qtquickcontrols2 and the
exported headers are installed under
QT_INSTALL_PREFIX/include/QtQuickControls2. By default,
Qdoc tries to look for the headers in a directory that
matches the doc project name, which is not the right
include directory in this case.
Change-Id: I77889fe35c028a2fc903d49b571a564c57326c21
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
| |
into one data-driven one.
Change-Id: I7507765747dd984530e50df5cd08152b9d71cb66
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
| |
Change-Id: Ic18cca692b09f55818b9c99379aae4be72ba4159
Fixes: QTBUG-74711
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not sure if this will help (because I haven't been able to
reproduce the flakiness, even in a CI VM), but the tumbler should
really not still be spinning after we got the position of its items,
so make sure it's stopped before doing any comparisons.
Task-number: QTBUG-70597
Change-Id: I72555747b2ea4ef136cdaa13f7b0757be2624e73
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
| |
Change-Id: I3a26f24ad16f6330715ce62151895f28e4b856d3
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make ItemDelegate respect highlightedText
- Change ItemDelegate's highlightedText palette role from white to
almost black (i.e inversion of "light" which is 0xFF090909),
so that text shows up against a highlighted background.
This also allows easily switching ComboBox to a dark style via palette
customization.
Fixes: QTBUG-72786
Fixes: QTBUG-74678
Change-Id: I5ad0d86de112f869edf0488d06bb308cdc900363
Reviewed-by: Massimo Callegari <massimocallegari@yahoo.it>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-74512
Change-Id: I7b154d793c134a93aa3a48ade7d3ae785c44e7ea
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When two buttons' roles are equal, the code would fall back to
comparing the buttons' memory addresses. This leads to random results,
which are especially noticeable on Windows and with release builds.
This patch fixes the issue by instead returning false if the roles
are equal. This still satisfies the "comp(a,a)==false" requirement
of strict weak ordering:
https://en.cppreference.com/w/cpp/named_req/Compare
The patch also changes the sorting algorithm used from std::sort()
to std::stable_sort(). Although it doesn't appear to be necessary from
the testing that I did, it is good to ensure that the order of equal
elements is maintained.
Fixes: QTBUG-70451
Change-Id: I47561604108b12bf8ec0c794a2372767f0b2e04e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS (and Android), we give focus to a control on touch release
(rather than on touch begin, which is normal on desktop). For a
QQuickCombobox, this means that we will both handle focus and open
the popup on touch release, and not focus on touch begin
and open popup on touch release, like on desktop. Because of this, we
need to be more careful about when we choose to close the popup as
well, otherwise it will close down before it gets a chance to show on iOS.
This patch will check why we lose focus on both the inner line edit
and the combobox itself, and based on this, choose whether we should
close the popup. Basically, if focus is just transferred between the
popup button and the line edit, we choose to keep the popup open.
Fixes: QTBUG-70161
Change-Id: Iec242c0b5570844868085480fdf96fc49d189b82
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
| |
Change-Id: Icbbe5fba6bfa6b4bb14a174d2ffafb85f223e0bf
|
|
|
|
|
|
|
|
| |
Implementations of QQmlJS::AST::Visitor are required to do so.
Fixes: QTBUG-74512
Change-Id: I19d40d2d3a5d3588cad4caa7f0a48c13919077a0
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some history:
- f1f884d3 worked around an issue in DialogButtonBox.
- c2fd8f7d fixed it by using contentWidth; i.e. the implicit width of
the contentItem. It caused QTBUG-72372.
- I tried to fix QTBUG-72372 with 6476de0b, but created (or exposed)
QTBUG-73860.
The problem in QTBUG-73860 can be seen with the following example:
Dialog {
id: dialog
visible: true
standardButtons: Dialog.Ok
}
The single 'Ok' button here will go outside of the dialog. The
underlying issue can be seen by looking into DialogButtonBox.qml:
implicitWidth: Math.max(implicitBackgroundWidth + leftInset + rightInset,
(control.count === 1 ? contentWidth * 2 : contentWidth) + leftPadding + rightPadding)
implicitHeight: Math.max(implicitBackgroundHeight + topInset + bottomInset,
contentHeight + topPadding + bottomPadding)
The implicit width of the box in this case is contentWidth * 2
(there is one button, so control.count === 1). This should result in
the button taking half the width of the box and being aligned to the
right:
alignment: count === 1 ? Qt.AlignRight : undefined
...
delegate: Button {
width: control.count === 1 ? control.availableWidth / 2 : undefined
}
What actually happens is that the contentItem (ListView) is temporarily 0
until it gets its final size of 100. However, QQuickDialogButtonBox
doesn't respond to this change in the ListView's contentWidth.
This problem can be fixed by returning to c2fd8f7d's resizeContent()
implementation, which uses contentWidth.
Then, there is a second issue:
Dialog {
id: dialog
visible: true
standardButtons: Dialog.Ok
width: 300
}
The button here is also positioned outside of the box. The problem is
that the contentWidth is based on implicitContentWidth:
QQuickContainerPrivate::updateContentWidth()
{
// ...
contentWidth = implicitContentWidth;
// ...
}
implicitContentWidth is calculated by calling getContentWidth():
void QQuickControlPrivate::updateImplicitContentWidth()
{
// ...
implicitContentWidth = getContentWidth();
// ...
}
In the case of horizontal alignment,
QQuickDialogButtonBoxPrivate::getContentWidth() uses the implicit
width of the largest button:
for (int i = 0; i < count; ++i) {
QQuickItem *item = q->itemAt(i);
if (item) {
totalWidth += item->implicitWidth();
maxWidth = qMax(maxWidth, item->implicitWidth());
}
}
// ...
if ((alignment & Qt::AlignHorizontal_Mask) == 0)
totalWidth = qMax(totalWidth, count * maxWidth + totalSpacing);
The Default style button has an implicitWidth of 100.
The DialogButtonBox in the example above is 300 pixels wide, so the
button should be 150, and it is, thanks to its width binding.
However, the DialogButtonBox uses contentWidth to size its contentItem
(ListView), and the contentWidth is, as mentioned, 100: the implicit
width of the button. So, the button ends up hanging over the side
of the box, as it's larger than the box thinks it is.
This problem is fixed by setting DialogButtonBox's contentWidth to the
contentWidth of the contentItem (ListView). This makes DialogButtonBox
use the explicit widths of the buttons rather than their implicit
widths. Since the contentWidth is no longer implicit, we must also
change any use of contentWidth in the implicitWidth binding to
implicitContentWidth.
While writing auto tests for this, they caught an issue where
contentWidth wasn't updated, so now we call resizeContent() in
QQuickContainer::setContentWidth().
Change-Id: I99ffda21b47aeb14d4382e453e87c4312f343a1c
Fixes: QTBUG-72886
Fixes: QTBUG-73860
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|\
| |
| |
| | |
Change-Id: I9f41b1731d8307c3b8725dfffee97191d03a14a6
|
| |
| |
| |
| |
| | |
Change-Id: I024460c3dabc1240ed37f8bfd216b3bad81eebb5
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Attached ToolTips share a single ToolTip item and set properties
(such as delay) on it before showing it. Before 63899f3185,
this wasn't a problem, but now QQuickToolTip has its own show()
function that QQuickToolTipAttached calls. QQuickToolTipAttached
passes -1 by default, which QQuickToolTip sees as the "default"
and hence doesn't set a timeout at all. However, since that
QQuickToolTip instance is shared, it still has a previous
timeout value from the last time it was shown by a different
QQuickToolTipAttached object.
So, instead of QQuickToolTipAttached passing the timeout to
QQuickToolTip::show(), make it set it on the QQuickToolTip
instead. This ensures that it has the correct value if no
timeout was specified for an attached tool tip.
Task-number: QTBUG-74226
Change-Id: Iceed17bbb640a929fae3b9c975519df36cc2d210
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
To ignore files like foo.pro.user.4.8-pre1
Change-Id: I465b36eda8a3a57854c25802d003d86ca7356f86
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the flickable inside a scrollview has an explicit content
size assigned, or if the flickable was created by the
application, then don't fall back to calculate the content
size. The reason is that it should not try to change the content
size of a flickable that is controlled by the application (or by
the flickable itself, in the case of ListView, ScrollView and
TextArea). Sometimes e.g ListView will report a negative
contentWidth, which is not considered illegal.
From before we used to just check if the child flickable had
a negative content size, and if so, take that as a evidence
that the flickable was owned by the scrollview. But with this
patch, we instead add two extra variables that keeps explicit
track of whether or not we should read the content size from the
flickable, regardless of the values it might return.
With the two new variables, we also no longer need the
"ownsFlickable" property, as we can instead use the new
variables to check for the same.
Fixes: QTBUG-72536
Fixes: QTBUG-74000
Fixes: QTBUG-72940
Change-Id: Iec87cc953557bf8c1bdb32a3c11b721c607fc19a
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Windows QPA
The test failed in case the mouse cursor was within the view to be created.
Move the cursor away to prevent that.
Fixes: QTBUG-74130
Change-Id: I8d77fc9b4cc5380ddb06ba128bca7c1666357b50
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
| |
| |
| |
| | |
Change-Id: I7247659b3c9f4634ff57bce1e55187def604e161
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this patch, only space was allowed.
Windows 10 and macOS 10.14.2 both allow using enter to activate menu
items.
Change-Id: I64476347669ff73f233efd129563a18ba51618a5
Fixes: QTBUG-73354
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After checking, it seems that this is not needed and was likely added
by accident, so removing internal_module will enable the cmake file
generation so QtQuickTemplates2 can be used in a project.
Change-Id: I4a3287147c3c8afb715ba8e4d21b8af6fc1e48f6
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This sentence was probably copied from Item's docs.
Task-number: QTBUG-73687
Change-Id: If9f7554c78cbc47abc7c9fdabacc8025864b76e0
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I1b34fe2df28c734395dc2a55340f2a7cb1629692
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As with the buttons manual test, there are a lot of possible
combinations of dialogs, which makes automated testing very difficult.
This test will allow us to see lots of different combinations all at
once for a particular style.
Change-Id: I42fa5a1e027c9f56bebf859078d3e54fe1902228
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the issue where Drawer would try to reposition itself forever,
but does not address the fact that it is incorrectly positioned afterwards.
Task-number: QTBUG-71290
Change-Id: Ibbd4baa84b66ab446ce3af2ef326f8c50e74216d
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Dialog (which derives from Page) has only its title set,
there'd be a binding loop. A simplified version of the call stack:
- QQuickPopup::componentComplete
- QQuickPopupPrivate::prepareEnterTransition
- QQuickItem::setVisible
- QQuickPagePrivate::itemVisibilityChanged
- QQuickDialog::implicitHeaderWidthChanged
- QQmlBinding::expressionChanged <== Dialog.qml's implicitWidth binding
- QQmlPropertyData::readProperty
- QQuickDialog::implicitHeaderWidth
- QQuickPage::implicitHeaderWidth
- QQuickItem::implicitWidth <== QQuickPagePrivate::header, aka Label
- QQuickTextPrivate::getImplicitWidth
- QQuickTextPrivate::updateSize
- QQuickTextPrivate::setupTextLayout
- QQuickItem::setImplicitSize
- QQuickItemPrivate::implicitWidthChanged
- QQuickPagePrivate::itemImplicitWidthChanged
- QQuickDialog::implicitHeaderWidthChanged
- QQmlBinding::expressionChanged
- QQmlAbstractBinding::printBindingLoopError
Fix the issue by not emitting change signals if we're already in the
process of doing so.
Change-Id: I37d6fa35b1e70420e436c0e001f55035d7630542
Fixes: QTBUG-66494
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-73849
Change-Id: I02b32f55fabc6274a071536234dd485bf4e9bd02
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TableView monitors if the application sets an explicit
contentWidth/Height, and skips calculating it when that is the case.
So be more careful from ScrollView, and don't set it on the
flickable if the application did not set it explicitly.
By doing it this way, you can now set an explicit contentWidth/Height
both in ScrollView and TableView, and it will be respected.
Task-number: QTBUG-72536
Change-Id: Ib87fa6958881fccdc47f50133e996484392281b6
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
QFont data must not be held at the application destruction time
to make the font database correctly dispose all acquired resources.
Change-Id: Ifc4a28a89701cf5622e8289a688eb0d4344c81fd
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|