| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
QCocoaColorDialogHelper in its setCurrentColor does some initialization
(using NSColorPanel) and required its 'm_options' to be set by this point.
So, first set options, then current color.
Task-number: QTBUG-69839
Change-Id: I9092c80a511890e958de5b99a9614feb134dba7e
Reviewed-by: J-P Nurmi <jpnurmi@gmail.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-68298
Change-Id: I049ff1de079f065182429f43a20e1a3899f4a962
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I0ea789c0ba3a153b00ac3ab6501ecf10f6c733ce
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit dabf5d2e fixed a documentation issue with QML type inheritance
by excluding .qml files from the documentation build. A side-effect is
that example documentation pages do not list .qml files as part
of the example project.
Instead of excluding all .qml files, simply exclude '*.qml' from the
list of source file extensions. This way, .qml files are still
considered to be part of examples.
Task-number: QTBUG-69141
Change-Id: I51a6d1768c30cfb9025a1aaf718b93bfae52437a
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are multiple copies (for each style) of .qml files, all
without documentation. The types are documented in .cpp or .qdoc files,
but QDoc parsed also the .qml source and generated (internal) nodes
for these undocumented types - this conflicted with the actual
documented types, causing the inheritance information to go missing.
To solve this, exclude all .qml files from the build as they contain
no documentation.
Task-number: QTBUG-69141
Change-Id: If9a84d91f37d5f9431c9ce1d0d079b7fd5159445
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Use Window.window instead of ApplicationWindow.window, as the former
will always result in a window regardless of which type of window is
in use.
Task-number: QTBUG-68858
Change-Id: I3bdb60350d92b13621b0f4db9085bf067b6ff6e2
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-66834
Change-Id: I8a07e114d230361f21dfbf1458210729b3607d92
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
There is currently no indication (in the form of build output) that the
user is missing a required module when building from source.
QTBUG-68826 suggests that such a feature be added, but until then,
we need a way to inform users how to build from source.
Task-number: QTBUG-68618
Change-Id: Ic17565aeaaff6aaa9907552d3b0c2646b407b425
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The placeholder text's renderType should cohere to the renderType of
the control. This is already the case for font, and sometimes color
too.
This solution avoids the need to expose a new property.
Task-number: QTBUG-68769
Change-Id: I6711aea83b7b8ee27f56b9c905aa4870465e3fd9
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Explain that the 9-patch lines must be one pixel thick regardless of
the intended DPI (e.g. @2x) of the image.
Task-number: QTBUG-66834
Change-Id: I57ab0460bf190a67a436dd63543ea0e09812a898
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We do not provide a 2x version for the 16x16 icon,
since the difference is quite subtle and it reduces the maintenance
burden.
We do not provide those for the other icon sets, too.
Change-Id: Ia6914c1abe8bac94ace9659a8b2c46cf3ed5fb56
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: Ifd7521b8a7bfd7da91808dd00ebdcb59f2ba46dc
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This was broken in 99b2fbbc90466c79837c7e68ac5d7a15b2f91699.
MenuItem doesn't have a checkState property, so we need to check its
checked property instead.
Change-Id: I3c2f9b27a1fe81c1de3500fad7e7bbe17ce6e02e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
Don't add paddings to header and footer width when choosing the max.
Padding affects content, not headers and footers.
Change-Id: I92381762f97eab384b18510522bf788abecd8338
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-67574
Change-Id: I3ab706c3eb6ad3112ed3f0a7dc37d530a179be6f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-67573
Change-Id: Iecdc9f6f35f858b962dc9a9e17077a35f56e90dd
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though there are no public QML types in the QtQuick.Controls.Fusion
namespace, we must provide plugins.qmltypes to avoid that tooling tries
to run qmlplugindump. Because of the internal .impl namespace, running
qmlplugindump doesn't work out of the box. The plugins.qmltypes file
has been dumped after deleting all .qml files from
QT_INSTALL_QML/QtQuick/Controls.2/Fusion and then manually edited to
remove all redundant QQC2 type definitions, leaving only the Fusion
.impl type definitions, similarly to what we did with the other styles.
Task-number: QTBUG-66276
Change-Id: I39ecfa1cd889ec5013a85dcdf96395fa31e92e57
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-67442
Change-Id: I41d8515763ef3af6da463ab9c1549164de3fafa0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Change-Id: I54225f958a16151f24a8c773489017d5b0a22d54
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to avoid false positives about
e.g. icon.source.
Note: I had issues when dumping controls. Certain types
were not part of plugins.qmltypes anymore. I fixed that manually.
Task-number: QTBUG-66625
Change-Id: I802b427efee5c27720c99c537ddb4690f74449fd
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
| |
Change-Id: Ib8c0688e071781e25ef4fdd8a51e302def32215f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Task-number: QT3DS-1363
Change-Id: Id464f3373bdc486060dcd1e351ffe29c55d85696
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Change-Id: I25bfc453bdfdc007ec10a69de92f3f339617c2d7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Change-Id: Id90ec3a30df73c7e510f388876bc92e552685177
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
There was a question about this recently, but our docs aren't exactly
clear about it.
Change-Id: I152e88f656505aace26b4a517daf79c9df8745c2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
These snippets are not referenced by their file names (without
extension) by any files in the repo.
Change-Id: Ia2cc52fc62dc15a525880678e544e792a64dab5e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
Unlike all other styles, imagine.pro was not assigning QML_FILES to
OTHER_FILES that makes the .qml files show up in Qt Creator.
Change-Id: I7510e8db6ef606774983151da3bae089a4697e8c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
Ensure that we unparent submenus in destroy(), not just in the
destructor.
Task-number: QTBUG-66889
Change-Id: I18b5fc28ee47a50f511ef4f8cf55cfdcbae9bfec
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
As with other properties in QQuickPlatformMenu, ensure that we set the
relevant property on the internal QQuickPlatformMenuItem.
Task-number: QTBUG-66876
Change-Id: Ie37d874426200014ea3bb4045bc6b566422221de
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
This will list each control that is a focus scope, and have
some relevant information about focus in Qt Quick Controls 2.
Change-Id: I3126452bf73f7d7730d0522d616d61ad0da0dd74
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-66874
Change-Id: I1e34039e4fa0344b1efdcb2977586d97ada6b31e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
Update the internal checked state before emitting triggered()
Task-number: QTBUG-66386
Change-Id: If120955681b2011bf88126a1ca6032f0af482824
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
It's important that users know the circumstances under which the items
managed by StackView will be destroyed.
Task-number: QTBUG-66658
Change-Id: I26e287b3dfed44e441125080443bdae4ee1814b7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
3b36c4e4 rounded translation of the ripple background node. Do the same
for the ripple wave node.
Task-number: QTBUG-58646
Change-Id: I455249603e5845a8790dcb374564744de4b880e2
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
A BusyIndicator with its default implicit size (48px) gets the same
line-width (4px) as before: 48px / 12 = 4px. The line-width is still
not adjustable as requested in QTBUG-64872, but tiny and huge busy
indicators look now much better.
Task-number: QTBUG-64872
Change-Id: If21feaf1f898b337eae879a961d37b54b217ed87
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
When running is set to true, QQuickFusionBusyIndicator, which is a
QQuickPaintedItem sub-class, must trigger an update.
Task-number: QTBUG-66752
Change-Id: I848a0008d7c8bd3f26f5daf54881c80cc6ba557e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I3b98e4c2159ba37b0b8d0ef5099b93308c84db11
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I5b4af1ddfe8c4583731f5a90082d803298bdf9bd
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there's only one button in the dialog button box, the Default and
Universal styles resize the button to cover half of the button box.
This works in typical scenarios when the dialog button box is assigned
as a footer of a dialog, and thus, gets resized together with the
dialog. However, if the dialog button box is placed into a layout, or
otherwise not given an explicit size, the implicit size calculation
loops until it reaches zero.
1) button box gets the implicit size of the content (one button)
2) button box resizes the button to cover half of the box width
3) button box re-calculates its implicit size => step 1
Avoid the problem by providing a reasonable hard-coded implicit size
for this special case.
Notice that this is just a temporary workaround to avoid the problem.
This can be fixed properly in dev by providing separate contentWidth
and contentHeight properties that cleanly propagate the content size
to QML.
Task-number: QTBUG-59719
Change-Id: I552e0824ae6bff26b570c699252a3e4f09bd3397
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
Sync with all other delegate types. This makes ItemDelegate less prone
to losing 48px height as per the design guidelines.
Change-Id: Idf4a097440236c35213ce1cb1e9709776fd8e95f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
DelayButton and ProgressBar are using QtGraphicalEffects. The
dependency must be declared in static builds:
DelayButton.qml:41:1: module "QtGraphicalEffects" plugin "qtgraphicaleffectsplugin" not found
Change-Id: Ic6774a2ebb85e6324ad6e9e222d15120c191a144
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
Cleanup global static data in QQuickStyle when the controls plugin is
unloaded (qmlClearTypeRegistrations()). This ensures that the style is
resolved as appropriate when the controls plugin is reloaded.
Change-Id: Icebb835e057e6063e4fc0ca035c6836560bc7c14
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|\
| |
| |
| | |
Change-Id: I91f8b19e02b7350a2569ab14fe79fe809202e6a8
|
| |
| |
| |
| |
| | |
Change-Id: I7f6d156d54a4c407853af5baa5bf59125ab35bde
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Use the more specific bottomPadding rather than padding.
Change-Id: Ib8823d6d9b07eaea97479ef432df0868b1b5d37d
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I83e5d787d0706dc547a9d906fdafef97e838172f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was already in Overlay's docs, but not Popup's, so this
patch moves the example to a .qdocinc and includes it in both places,
creating a new Popup Positioning section in the process.
Change-Id: I8e8438919fd849a8466b3a28133d22bb45f7dc19
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ib653224d7e30b08ec80b148420717e7e9fec5e7a
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The handle is not interactive; the whole dial is. As it is now, the
handle looks way too big.
Before and after this patch: https://imgur.com/a/HEbeh
Change-Id: I5db93a3e792a2133f765f69566bdd871598ab3b0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The handle is not interactive; the whole dial is. As it is now, the
handle looks way too big.
Before and after this patch: https://imgur.com/a/amhN3
Change-Id: I13c03085d25ee2eb01090825f6baa531409e02a0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|