| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
In auto tests, the engine might be null during destruction.
Change-Id: I0556c746f6c47198afc937da052106d3f8c35558
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
|
| |
|
|
|
|
|
|
|
|
| |
Avoid calling an uninitialized JS callback. This is a regression caused
by lazy creation of the JS callbacks in 1f146d9.
Change-Id: I1816b491ada0509c5664cffbcaa32ca987095b31
Task-number: QTBUG-51114
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling QJSEngine::evaluate() is a heavy operation. Only one of them,
namely textFromValue, is used from QML, so there's a good chance that
valueFromText doesn't need to be evaluated at component creation time.
This change postpones the initial evaluation to the point where either
callback is requested.
Before:
RESULT : tst_CreationTime::controls():"SpinBox":
0.53 msecs per iteration (total: 68, iterations: 128)
After:
RESULT : tst_CreationTime::controls():"SpinBox":
0.39 msecs per iteration (total: 51, iterations: 128)
Change-Id: I1730dc4024d0a556ca2da765ac3c52ba8a29f743
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| |
|
|
|
|
|
| |
condition. Return cached value.
Change-Id: If6394a59c2720351742d0d00b3ecaf4015824760
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |
|
|
|
| |
Change-Id: I65c37f661689bf30e7a9119bb877dce68eeb634c
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
|
| |
|
|
|
|
| |
Change-Id: Ic56f7882bc6070c85f87ab171ee7feb6dd0b260d
Task-number: QTBUG-50033
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |
|
|
|
|
| |
Change-Id: I6c6647de6d286a92b35bca09a45e82cd3343a623
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
|
| |
|
|
|
|
|
|
| |
The old name was a bit confusing, because Spinner is a synonym to
SpinBox: https://en.wikipedia.org/wiki/Spinner_%28computing%29
Change-Id: Id1e70d58238b93366c387c453803eabd002368eb
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |
|
|
|
|
|
| |
Change-Id: I45e01199453ac5fd64b7f98c165cc12eeb0ce8c3
Task-number: QTBUG-48989
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
Reviewed-by: Nikita Krupenko <krnekit@gmail.com>
|
| |
|
|
|
|
|
|
| |
* m_accessibleRole was removed
* also applied to QQuickLabel, QQuickTextArea and QQuickTextField
Change-Id: I4b487f32cccfba0e16b3dba7e39882e8cd7ea616
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
It came up in discussions at the QtWS that even if we have Tumbler,
people still want and expect to have the good old SpinBox control.
SpinBox has it pros, such as that it might work better inside a
vertical Flickable, and that in multi-field forms it might visually
align better with other controls like TextFields.
An early mockup of SpinBox was removed in 1c0edf0. A quote from the
commit message:
SpinBox is a desktop centric control. It won't be provided in
Qt Quick Controls 2.0, but maybe later when desktop support is
re-considered. Qt Quick Controls 2.0 will focus on embedded and
mobile. SpinBox is still available in 1.x.
While it is true that SpinBox might not be optimal for touch or
mobile, the real reason for the removal was that validating decimal
number input is very complicated. Even though locales have well-
defined thousand separators and decimal points, users have very
different expectations on how strict or relaxed the input
validation should be.
This change re-introduces a touch-optimized integer-based SpinBox.
What makes it more touch friendly than the earlier version is that
it has now auto-repeating buttons. Limiting it to integers avoids
the decimal number input validation problem. We can introduce a
separate DoubleSpinBox later if necessary - just like in QtWidgets.
Change-Id: I2819060eb5d1ae6a8c00b0f12be703456085079d
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
