| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: Ica132eeac20a5d276abfb7d74eba07d638ba288e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
| |
This is no longer true.
Change-Id: I70b36cfaf96be1d332e801499ca23de144df76ac
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/imports/controls/material/qquickmaterialstyle.cpp
src/imports/controls/universal/qquickuniversalstyle.cpp
src/quicktemplates2/qquickpopup_p_p.h
src/quicktemplates2/qquicktooltip.cpp
tests/auto/auto.pro
Change-Id: I88b347dd85278e14f7b2ca468e30648c6432b6f2
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Don't create the shared tooltip in the parent item's context, because
that may be destroyed and invalidate all bindings in ToolTip.qml. The
QML engine is the effective parent of the shared tooltip, so use the
engine's root context for creation as well. We do not need to pass any
specific context to QQmlComponent::create(), because it will pick the
root context by default.
Change-Id: I624b53fa9ba02123398e76b5eccf1a8091826b37
Task-number: QTBUG-55347
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The attached properties should apply to the shared/global tooltip
instance only when the shared tooltip is visible for the attachee
item.
Task-number: QTBUG-55347
Change-Id: Ia822f2d1de62d2d6dfb28519817edce674d8c2b8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A parentless/windowless popup item is not associated to a QML engine.
Accessing transitions calls qmlExecuteDeferred(), which leads to a crash.
This can happen in auto tests with the shared tooltip during destruction.
Change-Id: I9a258b2df6b87fce7833e358f17b1910934212c2
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A parentless popup is not visible anywhere, and is not even associated
to a QML engine. Attempting to execute transitions would crash.
Make sure to remove any event filters (when using a plain QML Window,
like with QML TestCase) when a popup is made parentless. This ensures
that if the global shared tooltip was shown on an item that was
destroyed, the tooltip won't keep interfering with the window where
it was last shown.
Change-Id: I87bf9f8dda2fbcc5d1b83d1b83a66a6b9e718eb6
Task-number: QTBUG-55347
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I88fbebfc672d4c8d398a45b5dfe0c61fa307a9e7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I390d3f9107f9e38e755f98060f74d63becba60cb
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Add HasGlobalForeground and HasGlobalBackground. These are set
to true when a foreground/background color is specified via settings
(qtquickcontrols2.conf file or environment variables), and then used
to initialize each attached style object's m_hasForeground and
m_hasBackground property.
- Add tst_qquickuniversalstyleconf auto test to ensure that global
settings are respected.
Task-number: QTBUG-55366
Change-Id: I7a8b219506f9528c4ae323bd890b418ba056ed23
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For example, DefaultAccent will become GlobalAccent. This better
reflects the reality that these are not true defaults because they can
be overridden by settings and makes it easier to read the code.
Change-Id: I2a7afa3ec8fd6db620d054b6e1f6860b2d3e1d02
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I8349ec366c75b9480533bb9b61a3748e09e9560e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Add hasGlobalForeground and hasGlobalBackground. These are set
to true when a foreground/background color is specified via settings
(qtquickcontrols2.conf file or environment variables), and then used
to initialize each attached style object's m_hasForeground and
m_hasBackground property.
- Add tst_qquickmaterialstyleconf auto test to ensure that global
settings are respected.
Change-Id: I436773e355c6d470215fb9cfe8fbff402d2979d9
Task-number: QTBUG-55366
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For example, defaultPrimary will become globalPrimary. This better
reflects the reality that these are not true defaults because they can
be overridden by settings and makes it easier to read the code.
Change-Id: Idf09e5b0c6a2d91663730c00e3d32f2be49e15c6
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make the QML engine the parent of the shared tooltip instance,
and make sure the instances are per engine. This ensures that
the shared tooltip gets properly destructed when the associated
QML engine is destructed. The same technique is used for the
global styles in QQuickStyleAttached.
Change-Id: I08dcb4f9bc6ddafb7449afe43362e560c0952e88
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move the itemDestroyed() listener from QQuickPopupPositioner, which is
only active while the popup is visible, to QQuickPopupPrivate instead.
This way the popup gets a notification when the parent gets destroyed
while the popup is hidden.
Task-number: QTBUG-55347
Change-Id: Ic72206cc05996c23062e814799a030c369fc6288
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-55050
Change-Id: I25e84d15ebb61f88cc92ab570471969ec5971c10
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I96ebc8ccd0c6bb05a4725cd42a65224411823b82
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I3ee830e88fd9621ffa4f81b2106c33c06ca7d1e9
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I8172f493c5747db2c9e728b026ff267bff2e3427
|
| |
| |
| |
| |
| |
| | |
Change-Id: Iad89f8d46b44ca2634d3f8ecd52431654ae5d7ac
Task-number: QTBUG-55129
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Iba3f5c0847a57420e9a8f85c589496c4e698a01e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There is no reason to force ChromeDisabledLowColor when having active
focus. ChromeDisabledLowColor is the same color than light theme's
BaseHighColor. Universal's foreground color is mapped to BaseHighColor,
so we can simply use Universal.foreground to retain the old behavior
_and_ get a working foreground color when explicitly turned to a dark
editor.
Task-number: QTBUG-52738
Change-Id: I2687a3df17985c5ad897f8fd80d808fa27ea918d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Same as a055629 for SwipeView, and 9cf30f1 for Menu. This hides the
tabs until they become visible in the bar. Hiding them explicitly is
not an option, because then they will never show up. This technique
is used in QQuickItemView::initItem() and FxViewItem::setVisible().
Task-number: QTBUG-55129
Change-Id: I84a9e0acf6109dfff72130f7a2bf1e5e992829d8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As was done in for Slider in c4c803ce4:
The correct formula for calculating the "range" or "span" is to-from,
not from+(to-from), which is used in the formula for calculating value.
Task-number: QTBUG-55228
Change-Id: Ic5463ef5ac5566efc5996aadd9ae39ec108d778f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The correct formula for calculating the "range" or "span" is to-from,
not from+(to-from), which is used in the formula for calculating value.
Task-number: QTBUG-55015
Change-Id: Ie30f7e86a10b606a59a171a4667772e446beaf39
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Cannot use local static variables to store the values of the last
round, because the values must be stored per instance, not shared
between all busy indicators.
Task-number: QTBUG-54472
Change-Id: Ibb088b077ff8e23b1376e04a0329f001211574f7
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using a plain QML Window, the Z-value of the popup item
must be higher than the Z-value of the DefaultWindowDecoration
in QtQuick.Dialogs 1.x. When using an ApplicationWindow, the
same applies to the window overlay.
NOTE: The correct Z-value of DefaultWindowDecoration is 1000000,
not 10000! (qtquickcontrols/src/dialogs/qml/DefaultWindowDecoration.qml)
Task-number: QTBUG-55004
Change-Id: Ib5d068ee2c633884f95ba519f77b6ec082220461
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is done in qwidgetplatform_p.h createWidget() outside QT_WIDGETS_LIB
guards so you get the important warnings even in -no-widgets builds.
Now that the widget platform instances are created only when really
available, they can unconditionally instantiate the respective widget,
which simplifies the code quite a bit.
Change-Id: I7430f8e803050e43edb3af3a139b0508445f6a37
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: If51b359fa44a539c236e1a070e69451c75e190f7
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I3438e1da864f6d7c710e4770f12aa2596f091a9d
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Iee7c700666d866ac28b8102a17ee86121af1af4e
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
It should be _after_ the potential widget-instance creation.
Change-Id: I7534a5914aeb96b441807945030a1ea1d8370378
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I107d51c9e3a874b92c627735dc88c7d296ec799f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Now that we know the type and whether it should be native, it can
be all done in the base class to reduce a lot of code duplication.
Change-Id: I7d7d7057fa499df75b72914d2b505bfa0288048d
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Id1699a6045eb9066a80ebdbb3cb5d3a01e58a36f
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I42b5e403e6cb16e607d9ce0d0e9f624b150bec03
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I4b65c7623a34d016243e626146437d2fa20fd93b
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
A more generic replacement for MessageDialog.clickedButton.
Change-Id: I060f70a48ab258485e3155188e483c4cf24210e0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I6bccfebcbb32dcafeea0814d88f7882857a62a85
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I56ad5025fb873261ccd96e82e4c9fff0731ddf92
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
It is no longer necessary to force the creation when accessing the
handle, because all places where it is used have a fallback member.
Change-Id: I7051b79e12c48aff0065a5a478c9c6c0c3ad2559
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This allows us to postpone to creation further, and even re-create
the instance on the fly later, without losing information.
Change-Id: I116d332d10d637bbc393ee31ec1bc8b0cd156835
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make sure the widget-based fallback implementation will never call
back to the platform plugin.
Change-Id: I860e61d23a34edcd0a8f85aabbd8d9c86ceac9ad
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I5805e03327cea6cba8083f636e061b561e87f215
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: If31d657e29a9cc3049af5cd3cf39d68979ff2db0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I60d60072f1cc6a876228e647b1d6db943e303ea2
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Follow the same convention that ColorDialog, FontDialog and FolderDialog.
Change-Id: I960d4fc1ba275ab997f2a079a799d2b90796eca3
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Follow the same convention that ColorDialog and FontDialog.
Change-Id: I49834daf908aadf145949c0b749c6c066f63fd83
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This is consistent with the QML FontDialog from QtQuick Dialogs 1.
Change-Id: I14a5a313be5ba9a9e0fb1645fe272cf9c2cdd389
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|