| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
qmldir files to be generated by the cmake build procedure and don't
need to be stored in the source tree.
Task-number: QTBUG-88263
Change-Id: Idff2800b5b2b6cb74d79a2f42fff717522c10ade
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.1
Change-Id: I688bdd73c939304f572d0e162e7aa09499bf737f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove focusing editText for Combobox when clicking on indicator (when
editable is set to true). Focus on Edit Text should be set only
intentionally by user.
Before this change, when focus was set on Combobox, it automatically set
focus on editText. It was also happening when drop down indicator was
clicked. Because of that, on some platform (like Android) virtual
keyboard was appearing in case when it shouldn't be shown.
Fixes: QTBUG-61021
Pick-to: 5.15 6.0
Change-Id: I813dcc3099c919ec32f0683e7e60e6082c5bc389
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This includes removal of the corresponding .prev_CMakeLists.txt files.
Pick-to: 6.1
Task-number: QTBUG-88742
Change-Id: I4247294258629c92e80914518e9208019090c815
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of the previous behavior, the footer could be read aloud by
the screen reader before the content item. And even worse, the footer
could be read aloud even before the header in some cases. This made
it hard for visually impaired people to use the application.
The Page type was used by the Dialog type, so it also affected that.
Fixes: QTBUG-75042
Pick-to: 5.15 6.0
Change-Id: Ic3e8ec3f7dcf18af9262b1d35c986835c8da6900
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for setting up initial inputMethodHints to Qt::ImhNoPredictiveText
for Combobox.
Before this change, Qt::ImhNoPredictiveText was never set for Combobox.
As inputMethodHints() by default returns Qt::ImhNoPredictiveText value,
setInputMethodHints didn't allow to set this value correctly.
Task-number: QTBUG-61021
Pick-to: 5.15 6.0
Change-Id: Ie4ec0d32fff7586bc3a8bd055b752000c0330fad
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
|
|
|
|
|
|
|
|
| |
Only react to hovered on enabled items.
Fixes: QTBUG-90580
Change-Id: I955033f391e6cd592e3d75b79b9242019db9fcfa
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syncCurrentIndex () function assumes that PathView is used as view for,
Tumbler component, and states that actualViewIndex should be 0 while
initialization. This statement is not correct when Tumbler is in
non-wrap mode and uses ListView as view, where currentIndex is set to
-1 by default. Fix actualViewIndex condition according to ListView
logic.
Fixes: QTBUG-84426
Pick-to: 5.15
Pick-to: 6.0
Change-Id: I4ef1e7b45399bf748968490f44b8909f3218d9bc
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
| |
The warnings appeared after porting QCcolor to float.
Change-Id: I248f15a7a403281e849f030e412c159f9732261e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the geometry of a control changes, this code is called:
void QQuickControl::geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry)
{
Q_D(QQuickControl);
QQuickItem::geometryChange(newGeometry, oldGeometry);
d->resizeBackground();
d->resizeContent();
if (!qFuzzyCompare(newGeometry.width(), oldGeometry.width()))
emit availableWidthChanged();
if (!qFuzzyCompare(newGeometry.height(), oldGeometry.height()))
emit availableHeightChanged();
}
SwipeDelegate works by moving the background and contentItem together
when it is swiped to expose the various delegates. Because this
involves setting the position of the background, the check for
background's x position being 0 in
QQuickControlPrivate::resizeBackground() would fail and the background
would not be resized at all. Fix this by making resizeBackground()
virtual and don't check the x when checking if we should set the width.
Similarly, in QQuickSwipeDelegatePrivate::resizeContent(), we should
set the contentItem's width instead of just repositioning and resizing
it vertically.
Fixes: QTBUG-85770
Pick-to: 5.15 6.0
Change-Id: I36684bf2797719db87fe93063cc7685efe594eea
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
| |
Change-Id: Ifbaadd993924022b1351927aaf3987cb94c74df8
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.0
Change-Id: I8d56f7b7071c51d4dfc88e12864bc3e0e7c5ab10
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A ScrollView will typically contain other controls. And
if we're using a dpr with a fraction (e.g 1.25), the
position of the controls will sometimes jitter as you
scroll. The result is that if e.g a Frame is wrapped
tight around around a Rectangle, the frame will sometimes
be outside the rectangle, and other times on top. This
is because of rounding issues when drawing the Frame
vs the Rectangle.
So let the default flickable used by a ScrollView have
pixelAligned set to true. This will give the best
cross-platform "out of the box" experience.
The developer can always choose to use his own Flickable
for ScrollView, and tweak it, if such default
behavior is not wanted.
Pick-to: 6.0
Change-Id: I7dc7b0b390dbf055f35cca2a6c15a6075e33c0a4
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some more contrived usages of nine patch images can uncover an issue with
the nine patch node implementation when used together with the threaded
render loop of Qt Quick: pixmapChanged generates a QImage that
references external data, which then gets passed to the scenegraph
in updatePaintNode during the scenegraph's sychronization phase.
This pattern (QSGTexture from non-data-owning QImage) should be avoided
in general, because when the gui thread gets unblocked and continues
after the sync phase, it could invalidate the data the QImage points to.
If now the independently running render thread happens to try accessing
the data (still the QImage that got passed in in the sync phase), bad
things may happen.
While it can be difficult to reproduce an actual crash (without ASAN and
such), logging with the specially crafted example code shows that the logic
is problematic if non-owning QImages are involved: (the pointers are the
QImage's constBits)
- pixmapChange 0x1f1053a5954 [gui thread]
- updatePaintNode 0x1f1053a5954 [render thread, gui blocked]
- beforeRendering [render thread]
- pixmapChange 0x1f1053e7424 [gui thread]
- QSGPlainTexture bind/update 0x1f1053a5954 [render thread] // but 0x1f1053a5954 may be invalid at this point if not owned by the QImage passed to createTextureFromImage
- frameSwapped [render thread]
Pick-to: 6.0 5.15
Fixes: QTBUG-88162
Change-Id: Id83d04fce668a3e05d150c086abdecc9d59e51e8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a popup had an exit transition set and was destroyed upon e.g.
being rejected, it would not destroy its modal dimmer, and so events
would not go through to popups that were beneath it even after it
was destroyed.
QQuickPopup's destructor does indirectly attempt to call
finalizeExitTransition() through a setParentItem(nullptr) call,
but prepareExitTransition() returns false if it sees that the
exit transition is already running, and so transitionExit()
never calls finished().
This patch fixes the problem by explicitly calling
finalizeExitTransition() in QQuickPopup's destructor if the exit
transition is running.
Fixes: QTBUG-89673
Pick-to: 5.15 6.0
Change-Id: I468fae52f6a83ac314877c67d062028634bb7e17
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 8b534487044dfb3b464431ecb91ef4e0864af4ed, the C++ tests were only
being run with the default style for the platform that they were run
on.
Fix this by keeping track of whether a default style is in use and
checking it in the tests.
Pick-to: 6.0
Change-Id: I4ddd90aba12ede83fff0d3d1002534e79fce8c87
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This ensures that the modules provide versions matching the current Qt
version.
Change-Id: I164b54af60de3b2b6ca6f54c417eb58b1eafd1e5
Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
It should of course be 4, not 3. The result
of it being 3 is that we would always also print info
when debugging imagerect.
Pick-to: 6.0
Change-Id: I257159b25b8aad1848d82af9855ecd194e7360a0
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.0
Change-Id: I3461744b8e784d9c3c775f06bffe8f7b3965073c
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By resetting the opacity and scale properties after an exit transition
we are ensuring that it does not lose the original values that the user
may have set.
[ChangeLog][Important Behavior Changes][Popup] After the exit
transition is finished, then the opacity and scale properties will
be reset to their values before the enter transition is started.
Pick-to: 5.15
Fixes: QTBUG-87283
Change-Id: I2b192c96eaea2906d968341255e80cd19be177e6
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-52466
Pick-to: 6.0
Change-Id: Ibf5c6f4079381c5ac507812f97439dbb49ada074
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the styleitem was created in a control without a window, it
failed to connect to the activeChanged() signal of QQuickWindow.
It would consequently warn about invalid null parameter to
QObject::connect()
If the control was added to a window at a later point, it would also
not connect to the activeChanged() signal of QQuickWindow. This could
cause that the control was rendered as it would be rendered in an
inactive window, even if the window actually was active.
Task-number: QTBUG-88553
Pick-to: 6.0
Change-Id: I3aa5948e150f0f4baa204943ec43ea8922421e75
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This now follows the same pattern as QQuickSpinBox does it for it's
own indicator buttons.
a11y::ScrollBar crashed because of this
Change-Id: I5669fa2bf130b37ad46573aae5c6bebd8e0d0434
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
In order to achieve this, it separates out QQuickSpinButton into a
separate file (and renames it since it's not only purposed for SpinBox
anymore). This allows it to be also used by QQuickScrollBar.
Fixes: QTBUG-88115
Pick-to: 6.0
Change-Id: I2dea42b29750b7bc619031f40a43717fc10c177b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Change-Id: Ib7ffbb263856f1ed97693eee10097f8cc2f8fb12
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pro2cmake chokes on converting the nativestyle project, because it
expects to find a second argument after the depends clause.
Add an 'auto', and regenerate the project.
Amends a3253c37903e95706f011bc03093160236b57bdc
Pick-to: 6.0
Task-number: QTBUG-88492
Change-Id: I4c9114780e17f5bc21a43511e75207eaef5e7550
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This unbreaks Qt 5 applications that weren't specifying a style or were
specifying Default.
[ChangeLog][Important Behavior Changes] Setting the style to "Default"
now behaves the same way as not specifying a style; a relevant style
will be chosen based on the platform. To use the style previously known
as "Default", use "Basic".
Task-number: QTBUG-85984
Pick-to: 6.0
Change-Id: I8e5533f9c6834765610773e46f97fbd56a242039
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
| |
Fix typo in qquickstyle.
Pick-to: 6.0
Change-Id: Id567f7359ae7aa346b38f94ae1add29aeb73039a
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
| |
Silences qdoc warnings about unlocatable index files, doesn't introduce
any new warnings from missing link targets.
Pick-to: 6.0
Change-Id: I36fe481d57e631389c485aa41c1a6fac5d997680
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
QQuickPlatformMenu links to the Instantiator type from this module.
Pick-to: 6.0
Change-Id: If59f6a64ac0144a7e6697b45e970c9f091bbb2e8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Professional CMake book suggests always using explicit linkage with
target_link_libraries, so let's use that.
Whether to use PUBLIC or PRIVATE depends on the context. But let's
be conservative and advise on using PRIVATE by default.
Also prefer the versioned target name over the unversioned one.
Task-number: QTBUG-88935
Pick-to: 6.0
Change-Id: Icf96616e2229b48cd3304a84d45314e69b1e40a9
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The size of the image we paint the item on should have a size
that will return a whole number when it's divided by the current
dpr. Otherwise the texture mapping that occurs in the scenegraph
later will work on fractions that will cause drawing glitches
to occur.
Fixes: QTBUG-89006
Pick-to: 6.0 6.0.0
Change-Id: I5e65aebbda9598d88bef7af2398b3fe3f2d16a87
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the texture
The size of the node should not be smaller than the size of the
texture. Otherwise the image will look truncated or wrapped.
This is especially important now that the image can be scaled
up to be dpr aligned.
Task-number: QTBUG-89006
Pick-to: 6.0 6.0.0
Change-Id: I0bd82faec89d6e7c2e79541a30d6b98200ebd5a0
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry calculated by the style should not take dpr
into account. The nativestyle framework (and the scenegraph)
understands that all geometry returned by QStyle will need
to be scaled according to the dpr. We will for example
set a dpr on the QPainter (or the QImage it draws on) before
we ask QStyle to draw. This means that the style should not
scale the geometry used in the drawing calls to QPainter since
QPainter will do this automatically.
Task-number: QTBUG-89006
Pick-to: 6.0 6.0.0
Change-Id: Idfcc6690e0ae0062ca00cb829510d2b68c26ebd4
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Non-existing links:
- Qt Quick Calendar
- Windows Style
Wrong link to macOS style
Pick-to: 6.0 6.0.0
Change-Id: I410ef79d71d2ff25eea8cc090516b431e046fc0b
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Since we only depend on using setFamilies() now instead of setFamily()
then we can rely on the fact that it will be resolved correctly, so we
can remove the code that was ensuring that family() would take
precedence if families() was empty.
Change-Id: Iea1464ec840dc76c04a4acae445cab367e03d3ca
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
-recommend using the import statement without versions for Qt 6.0
-update use of \qml snippet without \QtMinorVersion
Task-number: QTBUG-87155
Pick-to: 6.0 6.0.0
Change-Id: I338d4fb81b9709f2f342f250c07ddf66f116b1dd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current implementation would sometimes return a minimum
size with a height equal to 3. And when trying to divide the
image at the center for use with a nine patch image later, we
would get drawing artifacts. This patch will ensure that we
set a valid minimumsize.
Pick-to: 6.0
Change-Id: I9ee72c525966462ced596c5191153d3e2a0d68fe
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
|
| |
To be on the safe side, let's ensure that we set the same scale
one the scene graph node as on the image it's created from
Pick-to: 6.0
Change-Id: Ib8a86dd29f6f458d4c43dd36c6838dd632cb4078
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
| |
Cmake recreates the qmldir, so dependencies need to be listed in it too
Fixes: QTBUG-88492
Change-Id: Ibcb7555216ba2804b545534d9ce8b304d6172f29
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without it qmlimportscanner misses the dependency of FocusFrame.qml
and static builds fail to add the dependency leading to a QComponent is
not ready error.
This happens because the qml file is in a qrc, and thus not visible to qmlimportscanner.
Adding a depends QtQuick.Layouts fixes it (and updating the controls
dependency to drop the version)
Fixes: QTBUG-88492
Change-Id: I9be3e26c3a03b663cb90618368f3480f141a6b04
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
| |
Change-Id: I58a307b1bfae55b6c0b4d9663db817bea50b6b34
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
As it turns out, text areas in general should not show a
focus frame. We don't do that for widgets, and AppKit
doesn't do that for NSTextView. And for good reason, we
don't want to show a big focus ring around the whole text
edit in e.g a text editor application.
Change-Id: Idc344c9f8d9f4a11dce22b2d2284800f05cd551a
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
|
|
|
|
|
|
|
| |
-link to Qt Quick Controls help navigation
Task-number: QTBUG-87155
Change-Id: I65a5775c8754ee9a5fa5f669918a04026afde996
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I0ea36493f49bb642886346164d0e1c300af9afa5
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure that the qml registration function of macOS, Windows and native
styles get linked and executed in static builds by referencing the
initialization function in the plugin constructor.
This is intrusive and ugly, but is the method currently used in other
plugins.
Fixes: QTBUG-88463
Change-Id: I1b41ec89116066f46818f40ad155d12f6e719ca7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
| |
Prepare for upcoming changes in qtbase.
Change-Id: Iace6fb0c99a0256b4665ff8ee6962c8ea837a74a
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
|
|
|
|
|
|
| |
Change-Id: If8126bc760b4a0a4f7ee05a8d858c3ffdf63f64c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
| |
Matching qtbase
Change-Id: I1bd569995197158727ed5dff5b86e041c7af2177
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
| |
Use the new pro2cmake functionality to copy / install the files
specified in AUX_QML_FILES entries.
Task-number: QTBUG-87818
Change-Id: Ibdee35d54aaf37589d31d113bed67520b57fdbf2
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|