| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
And fix minor documentation issues.
Pick-to: 6.2
Change-Id: I42f13e5662fb4e4127428b5e67a145ed22be4cfd
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-82678
Pick-to: 6.2
Change-Id: Icf0f43454086a059e8e14a03db985e570233e0a9
Reviewed-by: Igor Bugaev <freedbrt@gmail.com>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes are subjective, and might not be seen as an improvement by
everyone.
Personally, I felt that some space could be removed between the text
fields and list views for the material style, and between the list
views and group boxes for the universal style.
Task-number: QTBUG-87799
Pick-to: 6.2
Change-Id: I2a94caaa2304ccef0c9709bbfe9a0cd9b56e2034
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
For auto-generated plugins we don't need the declarations.
Pick-to: 6.2
Change-Id: I0250703e7c81debc6bc6ca526722c43b8a8058c8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Specify preferredHeights directly on the items that need them rather
than doing it at a higher level. This makes the lower row with the
text edits and check boxes shorter, giving more space to the row with
the list views.
- Convert the ColumnLayout containing the check boxes into a RowLayout
to save vertical space.
- Add some spacing and padding where necessary now that everything is
more compressed.
Task-number: QTBUG-87799
Pick-to: 6.2
Change-Id: Iba288f678c1d449ace3bc143073d216fe69d9d9a
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pro2cmake.py conversion script faithfully reproduced the .pro files
for the plugins, which specified the libraries as public. But in CMake,
the implications of this are that public usage requirements should then
be propagated to consumers. We don't expect any consumers, since a
plugin is created as a MODULE library in CMake, so for Windows we don't
even have an import library to link with. The only exception to this is
for static builds where plugins are created as STATIC libraries
instead, but only in certain controlled situations do we then link to
plugins. Even then, usage requirements are not expected to propagate to
the consumers, so these relationships should always be specified as
private.
As a drive-by fix, remove Qt::Foo dependencies that are already implied
by Qt::FooPrivate.
Pick-to: 6.2
Task-number: QTBUG-90819
Change-Id: I3f33766612367520e09e599f03ac06d43613aa81
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With recent changes to hover handling logic, hover events would have
been sent to the "main window", even if a popup were modal. As this is
unwanted (a modally blocked button should not auto-raise when hovered),
we now prevent delivery of those events in QQuickOverlay and
overlayEvent.
The logic is the same as for mouse and touch events: If we get a
matching event, we ask the popup to handle it. The popup then uses the
existing blockInput logic to decide whether the event should be blocked
or forwarded.
Pick-to: 6.2
Change-Id: I2194fd8e832592efd5b7b9697412bdaeaea74b83
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-94703
Pick-to: 6.2
Change-Id: I2c48f1cc94b8dd94cddab1d833f62299d35fe5d9
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The Visual Studio 2019 (16.8), marks construction
function(var */*name*/) as warning, but compiler flag /WX marks
warnings as errors, and because of this, it's not possible to compile
this module. This issue fixed in Visual Studio 16.9
Pick-to: 6.2
Change-Id: If79d1b73d916472e2e82d15ebf423eac646fc76d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When a component (e.g. Button) is used as a delegate in ListView, we
might get a updatePolish() before the component is completed.
Make sure we don't call polish() before we are completed.
Pick-to: 6.1 6.2
Fixes: QTBUG-93041
Change-Id: Iba5d1a4365c864f8ff8115383880500feac7bc5d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Pick-to: 6.1 6.2
Change-Id: I897327d5f3bfd0ebbdca2df74ea43d6625c67a65
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-92824
Pick-to: 6.1 6.2
Change-Id: I261b269187b0106939837620287838222f8923b4
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the configure.json and configure.pri files that
were used for the qmake-based configure.
Remove the .prev_*.cmake files that were a by-product of
configurejson2cmake.py.
Pick-to: 6.2
Task-number: QTBUG-89536
Change-Id: Ie6c3d946a7157164c3854ef22812262aa7237c4f
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes an issue with hasAcceptableInput(), if the property
would be read before the contentItem had been set by the qml engine.
This would cause hasAcceptableInput to return false by default, even
though the default value is supposed to be true, if no validators or
inputMasks are being used.
The solution that I've chosen, is to give the QQuickComboBox its own
acceptableInput variable, and connect the contentItem's
acceptableInputChanged() signal to a function that polls for the
contentItem property, and updates its variable accordingly.
Fixes: QTBUG-94307
Pick-to: 6.2 6.1 5.15
Change-Id: I587d76162e75544a7ed1df9e3b9104bd73013bb0
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes: QTBUG-94559
Change-Id: I66c84052801aab56ad759289053e20d32e13c765
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
(cherry picked from commit f78072d5bc2d65307c86ce6e6fbc8d83fa82bc42)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
This allows it to pick up the Palette's placeHolderText color by default
while still using the property if it is overridden with that.
Pick-to: 6.2
Task-number: QTBUG-93746
Change-Id: Ie6af95d6c60fa80f2789c2acd5964b5a347194ce
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Use a smaller threshold than Flickable so that it
doesn't steal our events.
Fixes: QTBUG-55705
Pick-to: 5.15 6.1 6.2
Change-Id: I7e985c27788818226a3158078d485ea12ddd7006
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relayout() might change the size of the header, footer or contentitem
When one of those items changes, QQuickApplicationWindowPrivate will
get notified by that through
QQuickApplicationWindowPrivate::itemGeometryChanged().
itemGeometryChanged() will then call relayout()... (*recursed*).
Pick-to: 5.15 6.2
Task-number: QTBUG-87708
Change-Id: I9403952e776afb2be37d009642c65b5520c79341
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
This is demonstrated in the example, but it's better to make it clear.
Pick-to: 5.15 6.1 6.2
Change-Id: Ie5efcca2256da6a03d31df9cf045f4a97d1ad1ed
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
| |
Otherwise they get re-created and leak.
Pick-to: 6.2
Change-Id: Ib6af70bed196d3b32faa1df7f40063a38e321987
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Fixes: QTBUG-94455
Change-Id: I8d8c82f3b10e5e755ac11924c335ee07ab08d4a6
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I6b96d3d196b6d48e6dd53c74eb021e72840ac6be
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The internal QQmlDelegate model may not be ready until after
componentComplete() is called. For example, the following code will
print -1 for the find call, even though printing the model will
show the "Hello" entry:
ComboBox {
id: comboBug
anchors.centerIn: parent
model: ["123", "BlaBla", "Hello", "Turtle"]
currentIndex: {
console.log("Model: " + comboBug.model)
console.log("Find: " + comboBug.find("Hello"))
return comboBug.find("Hello")
}
}
Fixes: QTBUG-94257
Pick-to: 6.1 6.2
Change-Id: I6e8c2a4eb8ca7ffca0a38d2f2e914cf791d3bd2e
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
After the cmake changes that restructured the repository, the
snippets are now located in a different place. Update the
documentation for SelectionRectangle to reflect this, and
correct some related documentation issues at the same time.
Change-Id: I4860973bf101dc6c2dce5f64822235f0b5b73ce6
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][Controls][AbstractButton] doubleClicked() is now also
emitted for touch events.
Fixes: QTBUG-82146
Change-Id: Ie1e24d291bd4b592edd91fc762da8636e08698df
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
| |
The source files in Qt Quick Dialogs should now have a copyright header
that mentions they are indeed a part of the Qt Quick Dialogs module.
Pick-to: 6.2
Change-Id: I855edbca61f8e5c2a08dea50b5c70f1cdb3f996f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch will add a SelectionRectangle to controls.
A SelectionRectangle can be used together with TableView
to let the user select cells using either pointer Drag
or PressAndHold. It lets the developer set their own
handle delegates, or simply use the included ones added
to the Basic style.
[ChangeLog][Controls][SelectionRectangle] A SelectionRectangle
has been added to Controls. A SelectionRectangle can be used
to make selections in TableView.
Fixes: QTBUG-74750
Change-Id: Ia7af578c1c905b0e92df193d7820ad6ef2c9b697
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new qml CMake API places a closer relationship between
the backing target and the plugin target. Both are typically
created together and they share a lot of common details.
Instead of creating them in different parts of the source
tree, they are now specified together. The src/imports
area has effectively been absorbed into the other
corresponding subdirectories below src with this change.
Task-number: QTBUG-91621
Change-Id: I9bd32e9eb78c198ccc9db04e2829303cac323502
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Adding non-native FontDialog to QtQuick.
This is a native FontDialog on platforms
that support it, and a non-native
Qt Quick FontDialog on platforms that don't.
Fixes: QTBUG-87799
Change-Id: I43a59e3668a8a40f1d0c04a3c2506283d552a22b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An example of the warning:
"Final member contentWidth is overridden in class QQuickPage.
The override won't be used."
- Remove FINAL from base class properties that are overridden
by subclasses where it's not clear if it would be safe to
not override those properties
- Everywhere else, stop redeclaring properties in subclasses.
This will result in e.g. MenuBar not having a contentWidth
property if the QML is importing version 2.4, but as we're
now long past that version, it should be fine.
This fixes some auto tests that were failing after
ba2928c787cf0988a7f6a7d424faea96ff707846.
[ChangeLog][Important Behavior Changes] QML code that imported
version 2.4 or earlier will no longer be able to access contentWidth
and contentHeight in types derived from Container (i.e. MenuBar, etc.).
Fixes: QTBUG-94180
Change-Id: I3cdb79de8a1b54ab0c78ad661c432c47d5d1dfc6
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This prepares for QQuickItem's properties becoming bindable, changing
the type of QQuickItemPrivate::{x, y, width, height}. It adds explicit
casts/types where implicit conversion or type deduction would fail after
the conversion.
Change-Id: I9e25b45d1c7de162c3e72e8ec337b198bfd29c57
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
It has aqcuired revisioned properties.
Task-number: QTBUG-33179
Change-Id: I31ce4b07649ccc20789ed15bfb50e1643f6e4bff
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I82a18e7a0e768fe57c9cb08666b5486ecfa00ba8
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This prevented the function from being exported if something actually
tried to use it. At the moment, no other file is including the affected
header (that is a separate bug in qmltyperegistrar), which is why the
build wasn't failing despite the typo.
Change-Id: Ia9b266c4f5a42326932344e49bea228fd36ebb65
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C4267: 'argument': conversion from 'size_t' to 'const Key', possible loss of data
in
deferredStates()->insert(qHash(object, property), state);
and
QQmlComponentPrivate::DeferredState *state = deferredStates()->take(qHash(object, property));
The return type of qHash got changed to size_t in commit bd5b9cae7a29
Change-Id: If11de4fcd29a4d6ac8104e55ce18dd82f372054e
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
MSVC doesn't like it when there's only a default switch:
qquickwindowsstyle.cpp(2284): warning C4065: switch statement contains 'default' but no 'case' labels
Pick-to: 6.1
Change-Id: I3d6072e88a3aeec3a6801c2b0ddffd8e9f511943
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][QtQuickDialogs] Added FileDialog. This is a native
FileDialog on platforms that support it, and a non-native
Qt Quick FileDialog on platforms that don't.
Fixes: QTBUG-87797
Change-Id: Ia3a98b616479b818c96c232a0329750023079642
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
| |
Fixes: QTBUG-93994
Pick-to: 6.1
Change-Id: Ib9138f6bc59bcf7b97d5ccb478c7b9c434dfef64
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8ba12ed7f25d8cfb7619b6eb0a26fe4ae3e823b1.
The referenced commit was introduced to simplify buttons setup:
Button { checked: true }
Button { checkable: true }
With the commit the first button becomes 'checkable' automatically.
However, the implemented behavior violates the principle of least
surprise, listed in "API Design Principles". The following checkbox
will be checkable despite of the explicitly set properties:
CheckBox {
checked: true
checkable: false
}
This is a "surprising" behavior which makes some rare and already
complex use-cases unnecessarily complicated.
The save of explicit "checkable: true" does not justify the surprice
and the ugliness of the code needed to overcome the forced checkable
property if needed.
[ChangeLog][Important Behavior Changes] Setting the AbstractButton's
'checked' property to 'true' does not automatically set its 'checkable'
to true anymore.
Fixes: QTBUG-93807
Change-Id: Ia35138ee6a09bb9f361f52a84e53578b0b6e57e3
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
isMirrored() will always return true when locale is RTL,
so that we cannot change the layout. To fix this, remove out
the relation between LayoutMirroring.enabled and locale's text
direction.
[ChangeLog][Controls][Important Behavior Changes] Control's locale
property no longer affects layout direction. Use LayoutMirroring
instead.
Fixes: QTBUG-91227
Change-Id: Ibedd3f09828f81f1889077892452a27c90e21533
Reviewed-by: Hyunkook Khang <hyunkook.khang@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When the flickable is deleted before the TextArea is (which can happen
when it is a child of a ScrollView) then we need to make sure that the
TextArea no longer keeps a reference to the Flickable object.
Fixes: QTBUG-93958
Pick-to: 6.1 5.15
Change-Id: I1745065370718e60bc459192e15eae0e1ba36231
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we check for item being nullptr just before it evidently can be,
in which case QQml_setParent_noEvent would access that nullptr.
Fixes issue raised by code checker in 23fe43ee0a0838e3b680f6dc55cd226e
Pick-to: 6.1 5.15
Change-Id: Ic5306c0c8d89734a606ab90addc6540621696553
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
It can be nullptr as per the preamble to the function, and the fact that the
parameter defaults to nullptr.
Addresses code checker report 723994a37c58a4dcc3aeb573e1d517c5.
Pick-to: 6.1
Change-Id: Id17c95314f4adfa48e7754120ecc36a2efac5403
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Reuse the hideOldItem added in 80f1186338bcf8c7d692b4fadfc46531c002c6b0
to unparent and hide them.
Fixes: QTBUG-89126
Pick-to: 6.1 5.15
Change-Id: I641e46571b8ac42e0e5080b6737f305ff59afd51
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This avoids surprises when moving to Qt 6, where the default style is
now platform-dependent.
Fixes: QTBUG-92158
Pick-to: 6.1
Change-Id: I44cede00379b507f97ae7ac51aa5717c1b6510a8
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This allows QQuickPopup-derived types to have their own
QQuickPopup-derived popup item. This is useful for controlling e.g.
implicit content item sizing.
Task-number: QTBUG-83630
Pick-to: 6.1 5.15
Change-Id: I279d2e39df9a9cff29b3015a2f5baae7128f461f
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, QQuickPopupItem uses the implicitWidth of its contentItem,
which is too large in the case of a ToolTip with newlines in the text.
In that case, contentWidth refers to the width of the text including
newlines, so we use that instead.
[ChangeLog][Controls][ToolTip] The implicit width of ToolTips now
accounts for newlines in the text. If you want to use the old behavior,
set ToolTip's contentWidth to implicitContentWidth.
Fixes: QTBUG-83630
Pick-to: 6.1 5.15
Change-Id: I7ca3805429acb68a13ead8f3545bb84a51fb1b72
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
|
|
|
| |
The module is only available on marketplace
Pick-to: 6.1
Change-Id: I0910630b746b6eb4935fabdbc5148677c08bb234
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
A NoSnap and SnapOnRelease mode should always update the sliders
position even if the value is not updated.
Fixes: QTBUG-76136
Change-Id: I6cf6f948bfe582acc7f105373fb1938353acf2e7
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Use the actual padding from the nine patch image rather than the
hard-coded 12.
Fixes: QTBUG-91924
Pick-to: 6.1 5.15
Change-Id: I4707ae173c088625657a135680619cf646e3a9e2
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|