From ef6f66b06aa65a0481a215be15b9e2f1bf68ac58 Mon Sep 17 00:00:00 2001 From: Kai Koehne Date: Tue, 1 Dec 2020 17:00:34 +0100 Subject: Doc: Use explicit linkage with target_link_libraries The Professional CMake book suggests always using explicit linkage with target_link_libraries, so let's use that. Whether to use PUBLIC or PRIVATE depends on the context. But let's be conservative and advise on using PRIVATE by default. Also prefer the versioned target name over the unversioned one. Task-number: QTBUG-88935 Pick-to: 6.0 Change-Id: Icf96616e2229b48cd3304a84d45314e69b1e40a9 Reviewed-by: Alexandru Croitor --- src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/imports/controls/doc/snippets') diff --git a/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake b/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake index 2e9d2f3f..5bbbcff5 100644 --- a/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake +++ b/src/imports/controls/doc/snippets/qtquickcontrols2-overview.cmake @@ -1,4 +1,4 @@ #! [0] find_package(Qt6 COMPONENTS QuickControls2 REQUIRED) -target_link_libraries(mytarget Qt::QuickControls2) +target_link_libraries(mytarget PRIVATE Qt6::QuickControls2) #! [0] -- cgit v1.2.3