From 8aaa72c1035940eb290de9ba16513b2dafe5248c Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Thu, 29 Sep 2016 16:42:56 +0200 Subject: Material: switch back to triggering ripples on press There is something wrong with the ripple effect's speed calculation when it's triggered on release. The ripple is supposed to grow slowly on press, and fast on release. But when triggered on release, it grows clearly too slow. We also got a bug report complaining about the trigger on release behavior. Ripples are triggered on press on Android 5, which is the Android version with the most market share. The proposal is to fix the ripple effect speed calculation when triggered on release later, and switch to trigger on release when later versions of Android have passed Android 5's market share. Task-number: QTBUG-55520 Change-Id: I67994e0df3c318af24f0d1f843bb2d0c26c4d656 Reviewed-by: Mitch Curtis --- src/imports/controls/material/ComboBox.qml | 1 - 1 file changed, 1 deletion(-) (limited to 'src/imports/controls/material/ComboBox.qml') diff --git a/src/imports/controls/material/ComboBox.qml b/src/imports/controls/material/ComboBox.qml index a48c6884..87ab1b2d 100644 --- a/src/imports/controls/material/ComboBox.qml +++ b/src/imports/controls/material/ComboBox.qml @@ -110,7 +110,6 @@ T.ComboBox { clipRadius: control.flat ? 0 : 2 width: parent.width height: parent.height - trigger: Ripple.Press pressed: control.pressed anchor: control active: control.pressed || control.visualFocus || control.hovered -- cgit v1.2.3