From 7fc567eda8a187e365f4c29c6e8f08440bf31218 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Sat, 30 Jan 2016 17:21:55 +0100 Subject: Make popups work without ApplicationWindow, to some degree Using ApplicationWindow is highly recommended. First of all, with a plain Window, QQuickPopup attempts to set a high z-value, but cannot guarantee correct stacking order. Secondly, we cannot provide style- specific background dimming for modal popups, because it is styled as part of ApplicationWindow. Last but not least, QQuickPopup has to install a window-level event filter, which is far less efficient than how event handling done in QQuickOverlay. Change-Id: I08915abce7a1764177b92f7539eef77c054a405a Task-number: QTBUG-49921 Reviewed-by: J-P Nurmi --- src/templates/qquickpopup_p.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/templates/qquickpopup_p.h') diff --git a/src/templates/qquickpopup_p.h b/src/templates/qquickpopup_p.h index e2d89c66..ac9a238a 100644 --- a/src/templates/qquickpopup_p.h +++ b/src/templates/qquickpopup_p.h @@ -276,6 +276,7 @@ protected: void componentComplete() Q_DECL_OVERRIDE; bool isComponentComplete() const; + bool eventFilter(QObject *object, QEvent *event) Q_DECL_OVERRIDE; virtual void focusInEvent(QFocusEvent *event); virtual void focusOutEvent(QFocusEvent *event); virtual void keyPressEvent(QKeyEvent *event); -- cgit v1.2.3