From d6e03b3837f369e9fc94915ef3ad649903845382 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Fri, 4 Nov 2016 16:45:17 +0100 Subject: QQuickComboBox: ensure a parent for delegates This allows us to replace the "width: control.popup.width" expressions with "width: parent.width" to avoid explicit references to the popup. Next, we are ready to defer the execution of the popup until it becomes visible or is accessed by the user. Without the parent item fix, ComboBox throws an error: ComboBox.qml:58: TypeError: Cannot read property of null ...and tst_snippets fails => tested implicitly. :) Change-Id: Ib9cfcf7558addbe3403d835d3ae11b6c11c2f0cb Reviewed-by: J-P Nurmi Reviewed-by: Mitch Curtis Reviewed-by: Qt CI Bot --- tests/auto/controls/data/tst_combobox.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/auto/controls/data/tst_combobox.qml b/tests/auto/controls/data/tst_combobox.qml index 777b98f0..159ccebb 100644 --- a/tests/auto/controls/data/tst_combobox.qml +++ b/tests/auto/controls/data/tst_combobox.qml @@ -65,7 +65,7 @@ TestCase { id: emptyBox ComboBox { delegate: ItemDelegate { - width: popup.width + width: parent.width } } } -- cgit v1.2.3