diff options
| author | Sona Kurazyan <sona.kurazyan@qt.io> | 2021-05-28 10:06:42 +0200 |
|---|---|---|
| committer | Sona Kurazyan <sona.kurazyan@qt.io> | 2021-05-31 16:08:10 +0200 |
| commit | d71f499682e21b6b99b3d4ed9c13d819aa4cca05 (patch) | |
| tree | 662c88f5fabe8368b8011b5ebe9d27b7141aa4f0 | |
| parent | d831ab737a89c6710d43792762993b3cb6d08e96 (diff) | |
Fix static analyzer warnings
Removed or added default constructors/destructors/operators definitions
where needed, to silence clang static analyzer warnings. Also moved the
definition of IoDeviceBasePrivate to a correct location.
Change-Id: If0886b8c2315648a6f430776b5d1e78dc70eba0b
Reviewed-by: Brett Stottlemyer <bstottle@ford.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
| -rw-r--r-- | src/remoteobjects/qconnectionfactories.cpp | 4 | ||||
| -rw-r--r-- | src/remoteobjects/qconnectionfactories_p.h | 1 | ||||
| -rw-r--r-- | src/remoteobjects/qremoteobjectpacket_p.h | 5 |
3 files changed, 7 insertions, 3 deletions
diff --git a/src/remoteobjects/qconnectionfactories.cpp b/src/remoteobjects/qconnectionfactories.cpp index 3a6b668..95536c6 100644 --- a/src/remoteobjects/qconnectionfactories.cpp +++ b/src/remoteobjects/qconnectionfactories.cpp @@ -387,9 +387,9 @@ QtROClientFactory *QtROClientFactory::instance() \sa {qRegisterRemoteObjectsServer} */ -QT_END_NAMESPACE - IoDeviceBasePrivate::IoDeviceBasePrivate() : QObjectPrivate() { m_dataStream.setVersion(dataStreamVersion); } + +QT_END_NAMESPACE diff --git a/src/remoteobjects/qconnectionfactories_p.h b/src/remoteobjects/qconnectionfactories_p.h index 8b93492..b684db2 100644 --- a/src/remoteobjects/qconnectionfactories_p.h +++ b/src/remoteobjects/qconnectionfactories_p.h @@ -89,7 +89,6 @@ class IoDeviceBasePrivate : public QObjectPrivate { public: IoDeviceBasePrivate(); - ~IoDeviceBasePrivate() = default; bool m_isClosing = false; quint32 m_curReadSize = 0; QDataStream m_dataStream; diff --git a/src/remoteobjects/qremoteobjectpacket_p.h b/src/remoteobjects/qremoteobjectpacket_p.h index 1eac764..3935b7f 100644 --- a/src/remoteobjects/qremoteobjectpacket_p.h +++ b/src/remoteobjects/qremoteobjectpacket_p.h @@ -178,7 +178,12 @@ class CodecBase { public: CodecBase() = default; + CodecBase(const CodecBase &) = default; + CodecBase(CodecBase &&) = default; + CodecBase &operator=(const CodecBase &) = default; + CodecBase &operator=(CodecBase &&) = default; virtual ~CodecBase() = default; + virtual void serializeObjectListPacket(const ObjectInfoList &) = 0; virtual void deserializeObjectListPacket(QDataStream &in, ObjectInfoList &) = 0; virtual void serializeInitPacket(const QRemoteObjectRootSource *) = 0; |