diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2019-04-29 15:33:14 +0200 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@qt.io> | 2019-05-02 08:50:21 +0000 |
commit | 50529226884176e3910f84a68fb260a3cb9fb3b2 (patch) | |
tree | 1d437888c6382bfb9d4b8c5be251aa1fe5ed86de /git-hooks/gerrit-bot | |
parent | df3090cb05817277b0dd3586e9e2e7a673955a24 (diff) |
Suppress notification when there's nothing but a +1 from the sanity bot
Fixes: QTBI-1549
Change-Id: I061eafd8ab5b27d07dd9165e82688fd8cbcbe78d
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Diffstat (limited to 'git-hooks/gerrit-bot')
-rwxr-xr-x | git-hooks/gerrit-bot | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/git-hooks/gerrit-bot b/git-hooks/gerrit-bot index e5e8845..cacfa0e 100755 --- a/git-hooks/gerrit-bot +++ b/git-hooks/gerrit-bot @@ -221,6 +221,10 @@ sub process_commit($$$$$) merge_hashes($verdict, $vd); } } + if ($$verdict{labels}{'Sanity-Review'} == 1 && int($$verdict{comments}) == 0) { + # Don't spam everyone about a boring +1 sanity review with no comments. + $$verdict{notify} = NONE; + } if (@invite) { if (system(@gerrit_actor, "set-reviewers", (map { ('-a', $_) } @invite), '--', $rev)) { print "===== ".strftime("%c", localtime(time()))." ===== invitation FAILED\n"; |