summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJedrzej Nowacki <jedrzej.nowacki@nokia.com>2011-05-20 12:49:28 +0200
committerJedrzej Nowacki <jedrzej.nowacki@nokia.com>2011-05-25 10:37:48 +0200
commit54eb31e455ac9c26622c099e9a2fc3f4919bce45 (patch)
tree4a50e18c961859ee59f4133d59d0d23c51990c98
parentc71cdb5b8533d699aed818a75dcd9b91ad45d7c7 (diff)
Move an QEXPECT_FAIL.
We encounter some instability inside V8 / QtScript implementation. We didn't pass the test before for the same reason. Anyway the test is broken from conceptual point of view as it touches undefined behavior. We are not sure what should happen if an JS code is executed in a context that is about to be rolled up (an exception is thrown). Reviewed-by: Olivier Goffart
-rw-r--r--tests/auto/qscriptcontext/tst_qscriptcontext.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/auto/qscriptcontext/tst_qscriptcontext.cpp b/tests/auto/qscriptcontext/tst_qscriptcontext.cpp
index cef322a..b1791db 100644
--- a/tests/auto/qscriptcontext/tst_qscriptcontext.cpp
+++ b/tests/auto/qscriptcontext/tst_qscriptcontext.cpp
@@ -441,8 +441,8 @@ void tst_QScriptContext::throwError_fromEvaluate()
engine.globalObject().setProperty("throw_Error", fun);
QScriptValue result = engine.evaluate("throw_Error()");
QCOMPARE(engine.hasUncaughtException(), true);
- QCOMPARE(result.isError(), true);
QEXPECT_FAIL("ErrorAndReturnString", "v8 seem to forget the exception for some reason", Continue);
+ QCOMPARE(result.isError(), true);
QCOMPARE(result.toString(), stringRepresentation);
}
@@ -462,8 +462,8 @@ void tst_QScriptContext::throwError_fromCpp()
engine.globalObject().setProperty("throw_Error", fun);
QScriptValue result = fun.call();
QCOMPARE(engine.hasUncaughtException(), true);
- QCOMPARE(result.isError(), true);
QEXPECT_FAIL("ErrorAndReturnString", "v8 seem to forget the exception for some reason", Continue);
+ QCOMPARE(result.isError(), true);
QCOMPARE(result.toString(), stringRepresentation);
}