summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix QSV autotest failureswip/v8Peter Varga2011-07-191-3/+1
| | | | | | | | | | | | | Fix the error message in getSetProperty_gettersAndSettersOnGlobalObject(). Remove two testcases from the prettyPrinter because they cause SyntaxError exception. Change-Id: I0fb6906f3c00887772625a414f65d994e42b564e Merge-request: 2 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed-on: http://codereview.qt.nokia.com/1817 Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
* Update sync.profile dependencies to new syntaxAlan Alpert2011-07-111-12/+6
| | | | | | | | | | | | %dependencies now has a simpler format of gitmodule => gitref instead of using qt modules and keywords. Change-Id: I785f30e24e0a793218e2e307bdde56067760c516 Reviewed-on: http://codereview.qt.nokia.com/1273 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com> Reviewed-on: http://codereview.qt.nokia.com/1431 Reviewed-by: Nierob <jedrzej.nowacki@nokia.com>
* Update V8.Jedrzej Nowacki2011-07-111-0/+0
| | | | | | | | | This is the same V8 version as before but with new SHA1. Change-Id: I6a4ba9154facefc72fae3f92502fd235a49c3794 Reviewed-on: http://codereview.qt.nokia.com/1430 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Nierob <jedrzej.nowacki@nokia.com>
* Fix the build.Peter Varga2011-07-072-2/+2
| | | | | | | | | | | Remove $$QT_SOURCE_TREE from the pro files because it is obsolate. Change-Id: Icb26a53017115c8e55cdf5ecf288b858b6ca409c Merge-request: 7 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed-on: http://codereview.qt.nokia.com/1321 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: <jedrzej.nowacki@nokia.com>
* Remove FIXMEs from QSVP::equals and QSVP::strictlyEqualsGabor Ballabas2011-07-071-31/+2
| | | | | | | | | | | | Remove now unnecessary workaround from QSVP::equals and QSVP::strictlyEquals because the V8 bug which made them necessary get fixed. Change-Id: I04bda6d817b8bedbc8b95fc0b136e0408be580ea Merge-request: 6 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com> Reviewed-on: http://codereview.qt.nokia.com/1320 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: <jedrzej.nowacki@nokia.com>
* Update v8 submoduleJedrzej Nowacki2011-06-271-0/+0
| | | | Use new version of v8.
* Use FAST_TLS if possible.Jedrzej Nowacki2011-06-221-0/+3
|
* Replace QSOGO::getOwnProperty by QSEP::hasOwnPropertyPeter Varga2011-06-226-31/+23
| | | | | | | | QSEP::hasOwnProperty uses the proper V8 API call to check the existence of an own property: Object::HasOwnProperty. Merge-request: 5 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
* Remove QSOGO::getOwnPropertyNames methodPeter Varga2011-06-225-28/+3
| | | | | | | Replace the usages of this function by proper V8 API call: Object::GetOwnPropertyNames. Merge-request: 4 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
* Use new v8::Object calling functions.Jedrzej Nowacki2011-06-202-4/+4
| | | | | Our V8 extensions; Object::Call and Object::NewInstance were replaced by standard v8::Object API (CallAsFunction and CallAsConstructor).
* Update v8.pro fileJedrzej Nowacki2011-06-201-36/+32
| | | | | The file had to be updated because of changes in V8 that were adopted recently.
* Update v8 submodule version to the current one.Jedrzej Nowacki2011-06-201-0/+0
|
* Replace v8 copy by v8 submoduleJedrzej Nowacki2011-06-20522-426004/+3
| | | | | It is much easier for us to use git submodule then constantly copy all source code from v8.
* Fix reentrancy problem in QScriptOriginalGlobalObjectJedrzej Nowacki2011-06-151-24/+27
| | | | | | | | As QtScript not full control V8 API we are not allowed to keep properties of QSOGO by a HandleScope. This patch removes wrong startup optimization. (d067b49d347d1b46fc9a9a3d19a98ba4c87112cb)
* Fix a persistent handle usage.Jedrzej Nowacki2011-06-151-1/+2
| | | | | | The QScriptValue created by custom user marshal function have to stay alive as long as we use internal handle. Normally QScriptValue destructor destroys internal handle which means that it is unusable.
* Add QSEP::getCurrentV8Context method.Peter Varga2011-06-064-2/+16
| | | | | | | | | The usage of this method avoids the necessity of using a HandleScope before a QSE instantiation when QSE's constructor is called with AdoptCurrentContext parameter. Merge-request: 3 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
* Fix QScriptEnginePrivate constructor.Peter Varga2011-05-312-7/+10
| | | | | | | | If the constructor is called with a QScriptEngine::AdoptCurrentContext parameter then use the current isolate instead of creating a new one. Merge-request: 2 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
* Remove FIXME from the v8base.priPeter Varga2011-05-301-4/+5
| | | | | | | | Check the version of gcc and use -fno-strict-aliasing flag when it's 4.5. Merge-request: 1 Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
* Fix invalid Handle usageJedrzej Nowacki2011-05-301-1/+1
| | | | | | | QSVP::asV8Value return a Handle which is internally Persistent it is not allowed to use a Persistent as a Local in a HandleScope. Reviewed-by: Gabriel de Dietrich
* QScriptIsolate code cleanup.Jedrzej Nowacki2011-05-271-10/+4
| | | | | Remove redundant include of a header file. Inline init function into the ctor.
* Fix tst_QScriptEngine::dateConversion tests.Jedrzej Nowacki2011-05-261-2/+2
| | | | | | | | The tests were broken by fix to QDataTime::toString that add "Z" at the end of a string representation in ISODate (merge-request 1149 and QTBUG-9698). Reviewed-by: Zeno Albisser
* Fix Isolate usage in QScriptValueIterator.Jedrzej Nowacki2011-05-261-12/+28
| | | | | | | Not every function in QSVI need the isolate, but it is better to be safe than sorry. Reviewed-by: Gabriel de Dietrich
* Skip crash in QSE::abortEvaluation_tryCatch autotest.Jedrzej Nowacki2011-05-261-0/+1
| | | | | | | The test relayed on our patch to V8, which got broken and it is difficult to rework. We need to think more about it. Skipping for now. Reviewed-by: TrustMe
* Code cleanup.Jedrzej Nowacki2011-05-252-37/+1
| | | | Remove unused constructors from QScriptContextPrivate.
* Introduce optimized Handle class for QScriptContextPrivate usage.Jedrzej Nowacki2011-05-254-27/+185
| | | | | | | | | | New class depending on parameter behaves as v8::Local or as v8::Persistent. According to benchmarks, The QSCP::Handle class together with QSCP::Stack and QSCP::Heap classes gives us QObject bindings speedup from 2-12% (it reduce significantly v8::Persistent usage).
* Introduce QScriptContextPrivate Stack and Heap classes.Jedrzej Nowacki2011-05-258-36/+100
| | | | | This is the first step to optimize QSCP class. We will apply some optimizations based on type of allocation of an instance.
* Fix QScriptEnginePrivate destructor.Jedrzej Nowacki2011-05-251-8/+24
| | | | | | | | | All contexts should be destroyed before internal Isolate object. Dispose m_scriptClassToStringTemplate in ~QScriptEnignePrivate Add missing invalidation code for QScriptables and qt_dataId. Reviewed-by: Olivier Goffart Reviewed-by: Gabriel de Dietrich
* Add micro-optimization in ~QScriptEngine.Jedrzej Nowacki2011-05-251-1/+1
| | | | | | | QScriptIsolate can be entered with NotNullEngine option inside QScriptEngine API. Reviewed-by: Olivier Goffart
* Remove outdated workaround in QSEP::NewArrayJedrzej Nowacki2011-05-251-4/+1
| | | | | | | | | http://code.google.com/p/v8/issues/detail?id=1256 got fixed. The patch fixes a persistent leak. This patch 10x speedups an array creation time. Reviewed-by: Gabriel de Dietrich
* Fix QtScript benchmarks.Jedrzej Nowacki2011-05-255-4/+7
| | | | | | Add benchmarks to tests.pro file and fix some dependencies. Reviewed-by: Olivier Goffart
* Move an QEXPECT_FAIL.Jedrzej Nowacki2011-05-251-2/+2
| | | | | | | | | | We encounter some instability inside V8 / QtScript implementation. We didn't pass the test before for the same reason. Anyway the test is broken from conceptual point of view as it touches undefined behavior. We are not sure what should happen if an JS code is executed in a context that is about to be rolled up (an exception is thrown). Reviewed-by: Olivier Goffart
* Fix the include pathOlivier Goffart2011-05-241-1/+3
| | | | | | qtbase.pri need the MODULE variable to be set. It is not autodetected because the name of the profile is not the same as the one of the module name
* Merge branch 'master' into v8Olivier Goffart2011-05-2315-49/+90
|\ | | | | | | | | | | | | | | | | Conflicts: src/3rdparty/javascriptcore/JavaScriptCore/yarr/RegexJIT.cpp src/script/api/qscriptengineagent_p.h src/script/script.pro tests/auto/qscriptable/tst_qscriptable.cpp tests/auto/qscriptengine/qscriptengine.pro
| * Merge branch 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-stagingQt Continuous Integration System2011-05-188-42/+69
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-staging: Reduce usage of Q_ASSERT in autotests. Remove Q_ASSERT from qscriptvaluegenerated test Remove Q_ASSERT from qscriptvaluegenerated test Remove Q_ASSERT's from qscriptvaluegenerated test Remove Q_ASSERT's from V8 autotest Remove Q_ASSERT from qscriptengine autotest Fix compile error. Remove Q_ASSERT's from QScriptable autotest Remove Q_ASSERT from V8 autotest Remove Q_ASSERT's from qscriptclass autotest Remove dead code from qscriptenginedebugger test
| | * Reduce usage of Q_ASSERT in autotests.Jason McDonald2011-05-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using Q_ASSERT does nothing in release-mode builds, and in debug builds it causes tests to terminate prematurely. It is much better to use QVERIFY or QCOMPARE. Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 3475168550c1a804f04f2a4edfeb30c04cd36551)
| | * Remove Q_ASSERT from qscriptvaluegenerated testJason McDonald2011-05-181-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Report a fatal error if an unknown type of comparison is requested rather than failing silently in non-debug builds. Also fixes the misspelled parameter name. Change-Id: I84bd018aa99e99a98d97c43343032b38ca9cbccb Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit fe170938cf963e0a0a20b19f97ee6e18b6808a90)
| | * Remove Q_ASSERT from qscriptvaluegenerated testJason McDonald2011-05-181-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Report a fatal error if an empty test is generated rather than failing silently in non-debug builds. Change-Id: I79aa7a9eb09e387cef1960816a4bcce7b1af282d Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit a4f105070799d4b4362b80b77c5960b364f77000)
| | * Remove Q_ASSERT's from qscriptvaluegenerated testJason McDonald2011-05-181-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Report a fatal error if there are problems reading from the input data stream rather than failing silently in non-debug builds. Change-Id: I7a913bf47dccb37bab09e1cd79e5022b04e42c27 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 385107ebc71a74dae031b713ea5a9c54635eeff8)
| | * Remove Q_ASSERT's from V8 autotestJason McDonald2011-05-181-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Report a fatal error when the realFail() function is missing or misbehaving rather than silently ignoring the failure in non-debug builds. Change-Id: I8b27aeb1c9dab5752a5dbedafc4d420bb4121d2b Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 20512cdab97b530ee8ec767254e553d80164b3c6)
| | * Remove Q_ASSERT from qscriptengine autotestJason McDonald2011-05-181-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than aborting in debug builds and failing silently in release builds, output a meaningful warning message and return a null QScriptValue which will cause the "isQObject" check in the testfunction to fail. Change-Id: I69fd9c15a69924d0abfde6710ea6ae4bf7e013fa Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 3b7f3757efb038fe523a00d474d1b92920f9abe8)
| | * Fix compile error.Jason McDonald2011-05-181-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous change to tst_qscriptv8testsuite.cpp introduced a compile error due to insufficient parameters to QTest::qVerify(). Change-Id: I9ea9462d830b9d796676947a3598e3c066b29180 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 5b044c36d0d7671c8ff9776822cf0f1ad7eeec79)
| | * Remove Q_ASSERT's from QScriptable autotestJason McDonald2011-05-181-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The helper class expects a valid script engine to be available and attempted to verify this with Q_ASSERT (which does nothing in release mode) and QVERIFY (which should only be used directly in test functions). This commit makes the helper class avoid using an invalid engine and catches the problem later by verifying that the last script engine used by the scriptable class was valid. Change-Id: I849df32b141b7801b9b5a92f44ff325397e32f2d Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit a7acd7e0a09d89647abb9ff91b1bcb55d1a7a849)
| | * Remove Q_ASSERT from V8 autotestJason McDonald2011-05-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace Q_ASSERT with QTest::qVerify, in line with the rest of this test function. Change-Id: Ia39e62efb9945f72a6a93fddddf36488cd456965 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 3ba55189d9aa7d9d7c2087071dcb4d338c0feab8)
| | * Remove Q_ASSERT's from qscriptclass autotestJason McDonald2011-05-181-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow the extension() function to return a null QVariant, which will cause the test to fail gracefully. Change-Id: Ide9ef69c48f4bdd5a000f525fe9f395c27854da9 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 8b95b4b5c09bf31f813fe39a3eec611c9daddb98)
| | * Remove dead code from qscriptenginedebugger testJason McDonald2011-05-181-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | Remove code made obsolete by 2d1839e850ac632a13ff0ac3096d8419bff5082d. Change-Id: Ic889c81f0507eb91028fa6b6c4cbf6ae71a728b0 Reviewed-by: Rohan McGovern (cherry picked from commit 4b5a7eeacee997f0129354c9669b8e0d66ca4efa)
| * | Merge branch 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-stagingQt Continuous Integration System2011-05-161-0/+6
| |\| | | | | | | | | | | | | * 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-staging: Fix crashes with regular expressions QtScript on ARM traditional architectures
| | * Fix crashes with regular expressions QtScript on ARM traditional architecturesSimon Hausmann2011-05-161-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Save and restore the r8 register properly. Backport of http://trac.webkit.org/changeset/65242 from WebKit trunk Reviewed-by: Jedrzej Nowacki (cherry picked from commit f5acce7e11fa7c6abf5cf5352ec750c1ac65dd29)
| * | Merge branch 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-stagingQt Continuous Integration System2011-05-143-6/+9
| |\| | | | | | | | | | | | | | | | * 'master' of git://scm.dev.nokia.troll.no/qt/qtscript-staging: Honor -nomake examples setting Update module version number to 5.0.0
| | * Honor -nomake examples settingEckhart Koppen2011-05-131-0/+3
| | | | | | | | | | | | | | | | | | Examples to be enabled explicitly Reviewed-by: TrustMe
| | * Update module version number to 5.0.0Eckhart Koppen2011-05-132-6/+6
| | | | | | | | | | | | Updated .pri file variables