diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2016-09-20 17:14:37 +0200 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2016-10-14 10:53:01 +0000 |
| commit | bde17badd31d4990b1cc57f155c74c62b2ec9c72 (patch) | |
| tree | 168012e4fd8b8ce9e493dd85781e32d4907a14e4 /tools/qscxmlc/scxmlcppdumper.cpp | |
| parent | 7fe44d5d3b0ce86e53d00b65f0905c83b2e17586 (diff) | |
Clean up qscxmlinvokableservice.h
This is public API, so it should follow some minimal standards:
* Use QObject's d pointer where possible
* Follow the FooPrivate naming scheme for private classes
* Don't expose any data members in the public interface
* Give the various service classes somewhat logical names
* Drop some #ifdefs (qscxmlinvokableservice.h isn't used for qscxmlc)
Unfortunately we cannot drop any actual functionality from this
header as we need all of it for the generated C++ code.
Change-Id: Idd2698f7a331548eb1bf2d20da405a0fe05a92f0
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
Diffstat (limited to 'tools/qscxmlc/scxmlcppdumper.cpp')
| -rw-r--r-- | tools/qscxmlc/scxmlcppdumper.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/qscxmlc/scxmlcppdumper.cpp b/tools/qscxmlc/scxmlcppdumper.cpp index 723566f..0afdad5 100644 --- a/tools/qscxmlc/scxmlcppdumper.cpp +++ b/tools/qscxmlc/scxmlcppdumper.cpp @@ -393,10 +393,10 @@ int createFactoryId(QStringList &factories, const QString &className, QString line = QStringLiteral("case %1: return new ").arg(QString::number(idx)); if (srcexpr == QScxmlExecutableContent::NoInstruction) { - line += QStringLiteral("QScxmlInvokeScxmlFactory<%1::%2>(%3, ") + line += QStringLiteral("QScxmlStaticScxmlServiceFactory<%1::%2>(%3, ") .arg(namespacePrefix, className, QString::number(invokeLocation)); } else { - line += QStringLiteral("QScxmlDynamicScxmlFactory(%1, %2, ") + line += QStringLiteral("QScxmlDynamicScxmlServiceFactory(%1, %2, ") .arg(invokeLocation).arg(srcexpr); } line += QStringLiteral("%1, ").arg(QString::number(id)); |