From 070dee39d04d7b5333456e48e259bec5f8bf4dee Mon Sep 17 00:00:00 2001 From: Sergio Martins Date: Sat, 10 Sep 2016 13:41:11 +0100 Subject: Pass by const-ref in range-loop [-Wclazy-range-loop] QScxmlStateMachinePrivate::InvokedService is not a trivial type, it's copy-ctor would be called every time. Change-Id: If57c26aca89005c0fec39fa8ce3d2eac150975a0 Reviewed-by: Marc Mutz --- src/scxml/qscxmlstatemachine.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/scxml/qscxmlstatemachine.cpp b/src/scxml/qscxmlstatemachine.cpp index 915844c..a61fb07 100644 --- a/src/scxml/qscxmlstatemachine.cpp +++ b/src/scxml/qscxmlstatemachine.cpp @@ -518,7 +518,7 @@ void QScxmlStateMachinePrivate::routeEvent(QScxmlEvent *event) } else if (origin.startsWith(QStringLiteral("#_")) && origin != QStringLiteral("#_internal")) { // route to children auto originId = origin.midRef(2); - for (auto invokedService : m_invokedServices) { + for (const auto &invokedService : m_invokedServices) { auto service = invokedService.service; if (service == nullptr) continue; -- cgit v1.2.3