summaryrefslogtreecommitdiffstats
path: root/src/plugins/sensorgestures
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@theqtcompany.com>2016-05-20 14:47:09 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2016-05-30 18:22:03 +0000
commitcd1fc0b6ed27906c15b8f0e7f7e1b8cab147a3c3 (patch)
tree3737dcaf85b748d8a03e1cc111db9cfec1b7fed5 /src/plugins/sensorgestures
parent6189199557a2b8eb981f37e6370b47c25b224b4e (diff)
QCoverSensorGestureRecognizer: sanitize initialization.
Coverity noticed uninitialized members (CID 22309). Eliminate members handler (never accessed or set; the code always uses QtSensorGestureSensorHandler::instance() instead) and lastTs (set but never accessed). Initialized timer (to 0; it'll be set more sensibly as long as create() gets called). Reformatted constructor. Change-Id: I41738ec51db94fb35e068af509e9a34bf9221770 Reviewed-by: Lorn Potter <lorn.potter@canonical.com>
Diffstat (limited to 'src/plugins/sensorgestures')
-rw-r--r--src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.cpp11
-rw-r--r--src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.h2
2 files changed, 7 insertions, 6 deletions
diff --git a/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.cpp b/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.cpp
index ba010048..5b846c5a 100644
--- a/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.cpp
+++ b/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.cpp
@@ -36,9 +36,13 @@
QT_BEGIN_NAMESPACE
-QCoverSensorGestureRecognizer::QCoverSensorGestureRecognizer(QObject *parent) :
- QSensorGestureRecognizer(parent),
- orientationReading(0), proximityReading(0),active(0), detecting(0)
+QCoverSensorGestureRecognizer::QCoverSensorGestureRecognizer(QObject *parent)
+ : QSensorGestureRecognizer(parent),
+ orientationReading(0),
+ proximityReading(0),
+ timer(0),
+ active(0),
+ detecting(0)
{
}
@@ -114,7 +118,6 @@ void QCoverSensorGestureRecognizer::proximityChanged(QProximityReading *reading)
detecting = true;
}
}
- lastTs = reading->timestamp();
}
void QCoverSensorGestureRecognizer::orientationReadingChanged(QOrientationReading *reading)
diff --git a/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.h b/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.h
index 3425ba32..220e83a5 100644
--- a/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.h
+++ b/src/plugins/sensorgestures/qtsensors/qcoversensorgesturerecognizer.h
@@ -70,10 +70,8 @@ private:
bool proximityReading;
QTimer *timer;
- QtSensorGestureSensorHandler *handler;
bool active;
bool detecting;
- qreal lastTs;
};
QT_END_NAMESPACE