summaryrefslogtreecommitdiffstats
path: root/src/plugins/sensors/winrt/winrtaccelerometer.cpp
diff options
context:
space:
mode:
authorJuha Vuolle <juha.vuolle@insta.fi>2021-01-05 14:27:16 +0200
committerJuha Vuolle <juha.vuolle@insta.fi>2021-04-19 13:29:44 +0300
commit5a8aa096dc61336ac95734e8cc61f106e359c865 (patch)
tree20b1c3f3932b48bb6020a3d40d0dacf1abc6be2d /src/plugins/sensors/winrt/winrtaccelerometer.cpp
parent7dbb79c428f813e32986ccfe09a42f7d61a4c005 (diff)
Base commit to make QtSensors runnable on Windows
Fair amount of work remains after the commit still, but this should allow further development as a compilable baseline: code compiles, autotests pass, and most example applications at least start. The changes: -Change examples to use QtQuickControls 2 as per removal of v1 -Fix ambiguous conditional expression compilation error -Link against runtimeobject library (previously part of winrt QPA?) -Change the .pro file rule to win32 as winrt moniker does not exist anymore -Remove references to deleted winrt event dispatcher -Fix error handling: getdefault may be successful even if there is no default sensor -Fix QCOMPARE failure output (toString has changed in Qt6) -Remove qtimestamp alias which was deprecated already in Qt5 -Remove unit test hook that does not seem to be used anywhere -From typedef to ‘using’ for readability -Q_ENUMS -> Q_ENUM as the former has been obsoleted by the latter -Add qt6 changes qdoc page Task-number: QTBUG-88616 Change-Id: I92c168228ba76106b2c636c88f54331c76c3d2e6 Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io> Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'src/plugins/sensors/winrt/winrtaccelerometer.cpp')
-rw-r--r--src/plugins/sensors/winrt/winrtaccelerometer.cpp47
1 files changed, 23 insertions, 24 deletions
diff --git a/src/plugins/sensors/winrt/winrtaccelerometer.cpp b/src/plugins/sensors/winrt/winrtaccelerometer.cpp
index 3570a47d..e2bc0613 100644
--- a/src/plugins/sensors/winrt/winrtaccelerometer.cpp
+++ b/src/plugins/sensors/winrt/winrtaccelerometer.cpp
@@ -41,11 +41,11 @@
#include "winrtcommon.h"
#include <QtSensors/QAccelerometerReading>
-#include <private/qeventdispatcher_winrt_p.h>
#include <functional>
#include <wrl.h>
#include <windows.devices.sensors.h>
+
using namespace Microsoft::WRL;
using namespace Microsoft::WRL::Wrappers;
using namespace ABI::Windows::Foundation;
@@ -119,28 +119,30 @@ WinRtAccelerometer::WinRtAccelerometer(QSensor *sensor)
: QSensorBackend(sensor), d_ptr(new WinRtAccelerometerPrivate(this))
{
Q_D(WinRtAccelerometer);
- HRESULT hr = QEventDispatcherWinRT::runOnXamlThread([d]() {
- HStringReference classId(RuntimeClass_Windows_Devices_Sensors_Accelerometer);
- ComPtr<IAccelerometerStatics> factory;
- HRESULT hr = RoGetActivationFactory(classId.Get(), IID_PPV_ARGS(&factory));
- if (FAILED(hr)) {
- qCWarning(lcWinRtSensors) << "Unable to initialize accelerometer factory."
+
+ HStringReference classId(RuntimeClass_Windows_Devices_Sensors_Accelerometer);
+ ComPtr<IAccelerometerStatics> factory;
+ HRESULT hr = RoGetActivationFactory(classId.Get(), IID_PPV_ARGS(&factory));
+ if (FAILED(hr)) {
+ qCWarning(lcWinRtSensors) << "Unable to initialize accelerometer factory."
<< qt_error_string(hr);
- return hr;
- }
+ sensorError(hr);
+ return;
+ }
+ hr = factory->GetDefault(&d->sensor);
- hr = factory->GetDefault(&d->sensor);
- if (FAILED(hr)) {
- qCWarning(lcWinRtSensors) << "Unable to get default accelerometer."
+ if (FAILED(hr)) {
+ qCWarning(lcWinRtSensors) << "Unable to get default accelerometer."
<< qt_error_string(hr);
- }
- return hr;
- });
- if (FAILED(hr) || !d->sensor) {
sensorError(hr);
return;
}
+ if (!d->sensor) {
+ qCWarning(lcWinRtSensors) << "Default accelerometer was not found on the system.";
+ return;
+ }
+
hr = d->sensor->get_MinimumReportInterval(&d->minimumReportInterval);
if (FAILED(hr)) {
qCWarning(lcWinRtSensors) << "Unable to get the minimum report interval."
@@ -167,11 +169,10 @@ void WinRtAccelerometer::start()
if (d->token.value)
return;
- HRESULT hr = QEventDispatcherWinRT::runOnXamlThread([d]() {
- ComPtr<AccelerometerReadingHandler> callback =
- Callback<AccelerometerReadingHandler>(d, &WinRtAccelerometerPrivate::readingChanged);
- return d->sensor->add_ReadingChanged(callback.Get(), &d->token);
- });
+ ComPtr<AccelerometerReadingHandler> callback =
+ Callback<AccelerometerReadingHandler>(d, &WinRtAccelerometerPrivate::readingChanged);
+ HRESULT hr = d->sensor->add_ReadingChanged(callback.Get(), &d->token);
+
if (FAILED(hr)) {
qCWarning(lcWinRtSensors) << "Unable to attach to reading changed event."
<< qt_error_string(hr);
@@ -200,9 +201,7 @@ void WinRtAccelerometer::stop()
if (!d->token.value)
return;
- HRESULT hr = QEventDispatcherWinRT::runOnXamlThread([d]() {
- return d->sensor->remove_ReadingChanged(d->token);
- });
+ HRESULT hr = d->sensor->remove_ReadingChanged(d->token);
if (FAILED(hr)) {
qCWarning(lcWinRtSensors) << "Unable to detach from reading changed event."
<< qt_error_string(hr);