summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Change license for test filesLucie Gérard2024-04-0428-28/+28
| | | | | | | | | | | | According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I78ce1d00c581442d153a89b07961d3421d840057 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* QtSensors: Expose QSensor::isFeatureSupported to QMLTamas Martinec2023-10-312-0/+28
| | | | | | | | | | | | Checking if a specific feature is supported by the backend is now available from QML. [ChangeLog][QmlSensor] Add QmlSensor::isFeatureSupported(). Fixes: QTBUG-97273 Change-Id: I0ec71fa51c792afc4b6b6191b85910095d2b87a2 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
* Move sensor_explorer QML example to manual testsJuha Vuolle2023-02-2212-2/+425
| | | | | | | | | | | | | | | | The example is useful as a sensor testing tool, but less necessary as an example. The primary demonstrative element of the example was how to iterate the available sensors, which is covered in a documentation snippet (followup commit). This commit also renames the pre-existing widget-based sensor_explorer manual test to avoid name conflicts, as well as removes the qdoc and qmake support from the now-a-manual-test application. Task-number: QTBUG-110939 Pick-to: 6.5 Change-Id: I422f62f852d0a7e40a76f555ec8aa98404164f7a Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Remove ASAN warning on qsensor autotestJuha Vuolle2023-02-132-54/+0
| | | | | | | | | | | | | | The reason for warning was that the qTypedWrapper stored a QScopedPointer<QSensorReadingPrivate>, which in reality held a more derived TestSensor2ReadingPrivate. The base class QSensorReadingPrivate doesn't have a virtual destructor, and ASAN issues a warning when this more derived type is destroyed via a base class pointer. Fixes: QTBUG-105173 Pick-to: 6.5 Change-Id: I0740bd804faa44ace65191b948ae1b5eb44b79c0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Change (u)int to qsizetype (size_t) where applicableJuha Vuolle2022-10-042-2/+2
| | | | | | | | | | | | | Deliberately omitted: - QML interfacing code - public APIs - sensorfw, whose code is disabled/not practical to compile, and whose future is uncertain Fixes: QTBUG-107069 Change-Id: I84f0adf2f099da616ba6ff496fb84675bc845797 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Change from count() to size() with Qt containersJuha Vuolle2022-10-042-16/+16
| | | | | | | | | | As the preferred method. Potentially may be deprecated similar to QString/QByteArray Fixes: QTBUG-107068 Change-Id: I0cfc9d7f8e2e450849f1d22c5b98aa353748ecf6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Remove unused .qtt system test filesJuha Vuolle2022-10-042-425/+0
| | | | | | | These historical files are no longer used Change-Id: I048aa996bd0d285b6bd167130e10d160897c2246 Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Remove disabled sensor gesture codeJuha Vuolle2022-10-0459-9971/+0
| | | | | | | | | | | | | | | Support for sensor gestures in their then-current form was removed in Qt 6 (QTBUG-95747). This commit removes the disabled code. This is to avoid distraction when keeping the repository up-to-date with rest of Qt. The gestures may be reintroduced in some shape or form in the future (QTBUG-97066). For those reference purposes the old code can be found in the git history. Fixes: QTBUG-107065 Change-Id: If2c50171f84d483dde55600422d138d550124bdc Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Comment out header files that uses disabled sensor featuresAlexey Edelev2022-09-211-3/+3
| | | | | | | | | | | Tests still include files that were excluded from the QtSensors module. Comment out these includes. Amends 1e6f2126f11a62813dd652d3df0edb8bff8dfbf1 Task-number: QTBUG-103196 Change-Id: I511fdab9cc76480a7019ebf52a6857f5e8f9b207 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Tests: do not use QT_DISABLE_DEPRECATED_BEFOREIvan Solovev2022-08-251-2/+0
| | | | | | | | | | For several reasons: * It was renamed to QT_DISABLE_DEPRECATED_UP_TO * Its value will be propagated from the general Qt build Task-number: QTBUG-104858 Change-Id: Ia662321abecd1523f74541c277ba07c9eeceb0cd Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-08-2313-13/+13
| | | | | | | Task-number: QTBUG-105718 Change-Id: I8e1e210b85a5c02947a259edec14a915fa64cfc5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* CMake: Don't use PUBLIC_LIBRARIES for tests and test helpersAlexandru Croitor2022-07-287-7/+7
| | | | | Change-Id: I1ed37bf392000364bc1bf72dd11a3d3deec099d7 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
* Add license headers to cmake filesLucie Gérard2022-07-0713-0/+39
| | | | | | | | | | | | | CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: If432c07e9205f97f3c256ca2a8e682478d9dd82c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Use SPDX license identifiersLucie Gérard2022-06-1348-1296/+96
| | | | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I114588b3215fecda3a9127931f17a33bd4ef1edb Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Fix missing includesVille Voutilainen2022-05-171-0/+3
| | | | | | | | There's been recent header refactorings, this fixes the fallout. Pick-to: 6.3 6.2 Change-Id: I52e4ed5610d4f7d834b793c46e57c361168206a2 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* CMake: Bump almost all cmake_minimum_required calls to 3.16Alexandru Croitor2021-09-221-1/+1
| | | | | | | | | | | | | Needed for subsequent change that will check and error out if the version is lower than 3.16. We do that to ensure all policies introduced by CMake up to version 3.16 have their behavior set to NEW. Pick-to: 6.2 Task-number: QTBUG-95018 Change-Id: I51ba79ad25f77c6989acb0cb471967b6403c96f2 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Disable gestures from QtSensorsJuha Vuolle2021-08-163-9/+12
| | | | | | | | | | | | | | | | | | | | The sensor gestures requires some rethinking in order to be of more use for the developers. Therefore we should not yet commit to the old API at least in the first Qt 6 sensors release. This commit disables the gestures by: - Excluding gesture code from compilation - Excluding gesture examples and tests from compilation - Excluding the gesture related documentation - And updating the Qt 6 porting guide Pick-to: 6.2 Task-number: QTBUG-95747 Task-number: QTBUG-95649 Change-Id: I33c1e010825a88b10fa1f7ad49ad3b5383b470aa Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* CMake: Use renamed qt6_add_plugin PLUGIN_TYPE optionAlexandru Croitor2021-08-101-1/+1
| | | | | | | Task-number: QTBUG-95170 Pick-to: 6.2 Change-Id: Ic988e041d899c3c50c72404c5511a0cb19932dfd Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Update QtSensors platform- and sensor support in Qt6Juha Vuolle2021-06-295-47/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This commit removes the sensor frontend implementations of QAltimeter, QDistanceSensor, QHolsterSensor and their QML counterparts. Since the BlackBerry backend removal in 2015 these sensors have not had a backend support. Sensorfw is not currently supported by Qt6, and as the sole backend provider the following sensors have been removed from documentation until such support is reintroduced: QIRProximitySensor, QLidSensor, QTapSensor and their QML counterparts. [ChangeLog][QAltimeter] Remove support [ChangeLog][QDistanceSensor] Remove support [ChangeLog][QHolsterSensor] Remove support [ChangeLog][QIRProximitySensor] Disable documentation [ChangeLog][QLidSensor] Disable documentation [ChangeLog][QTapSensor] Disable documentation Pick-to: 6.2 Task-number: QTBUG-92512 Change-Id: Ic89e91bf65e7a70a2faf0fb566bb24f2f1005a4e Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Remove unused QmlSensorReading constructor parameterJuha Vuolle2021-06-221-3/+2
| | | | | | | | | | | The ctor parameter is not used. For clarity it should be mentioned that the memory management of the created 'reading' is done by explicitly parenting the 'reading' in the qmlsensor baseclass. Pick-to: 6.2 Task-number: QTBUG-92505 Change-Id: I4e50bcafa7789f7400364078302339915473a3b1 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Name variable more descriptivelyJuha Vuolle2021-06-221-9/+9
| | | | | | | Pick-to: 6.2 Task-number: QTBUG-92513 Change-Id: Ief063423985c9ad4d0209b0b9dda25d77e8fb30b Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Fix crash in manual test (sensor explorer)Juha Vuolle2021-06-221-0/+2
| | | | | | | | | | In some cases the reading may be a nullptr and the test needs to prepare for it. Pick-to: 6.2 Task-number: QTBUG-92513 Change-Id: I0186ffe9b277c9b978a30b4001c31df350a5d7a8 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Fix tst_sensorgestures_gestures to pass on AndroidJuha Vuolle2021-06-212-17/+13
| | | | | | | | | | | | | | The problem was that the testcase did not find the testdata files on Android. On closer inspection it turns out that TESTDATA token in qt_internal_add_test treats ANDROID/IOS and rest of the platforms differently in terms of how test resources are handled. This commit stores testdata unconditionally as qrc resources. Pick-to: 6.2 Task-number: QTBUG-92513 Task-number: QTBUG-73618 Change-Id: I0cfe878661dd2c55fa63abc1f95534a8041aa34d Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Add binding support for sensor readingsJuha Vuolle2021-06-216-38/+190
| | | | | | | | | | | | | | | | | | | | | | | | | Many of the sensors' QML "reading" value properties change with high frequency. This makes them candidates to benefit from the more performant bindable support. This commit adds the bindable support for QML sensor 'reading' classes: pressure, gyroscope, tap, compass, proximity, orientation, distance, magnetometer, lid reading, tilt, rotation, humidity, holster, ambient temperature, light sensor, altimeter, IR proximity, accelerometer, ambient light, and sensor reading baseclass (timestamp common to all) In addition to the 'reading' classes, the commit adds bindable support for QmlSensor::reading, as it's change signal is emitted with high frequency, on every sensor reading change. Pick-to: 6.2 Task-number: QTBUG-92513 Task-number: QTBUG-92503 Task-number: QTBUG-92505 Change-Id: I413ddd8a758142b9b93596e55b3bc8c3c2c98252 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alex Blasche <alexander.blasche@qt.io> Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
* Sensor identifier autotest and fix related findingsJuha Vuolle2021-06-151-3/+86
| | | | | | | | | | | | | | | | This commit adds a (QML) test for sensor identifier (and activation whose logic is closely related). The related changes: * Change sensor 'identifier' and 'type' properties to QByteArray. This now matches with C++ side that uses QByteArray * Allow changing of 'identifier' after componentComplete. This is now aligned with C++ side. Changing identifier is fine as long as the backend is not connected. Pick-to: 6.2 Task-number: QTBUG-92513 Task-number: QTBUG-92505 Change-Id: I326d840d5a4efb13a3a6578711563e8054cc9961 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Make sensor possible to indicate it is no longer busyJuha Vuolle2021-06-155-1/+55
| | | | | | | | | | | | | | | The current implementation allowed sensor backend to only indicate that it is busy, but not to tell when it was freed again. This commit allows sensor backend to indicate also that it's busy state has cleared. It is up to the sensor implementation to decide if it makes sense / is possible to do that or not. Pick-to: 6.2 Task-number: QTBUG-92513 Task-number: QTBUG-92505 Change-Id: Ied4857850e81346031fd83aa347d9955081118e8 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Increase QtSensors QML autotest coverageJuha Vuolle2021-06-1517-64/+388
| | | | | | | | | | | | | | | | This commit introduces QML based auto tests in order to increase the autotest coverage. Additionally the QML sensor activity handling is fixed which caused the newly added tests to fail. There are also long-standing bugs about these activeChanged() double emits. Pick-to: 6.2 Task-number: QTBUG-92514 Task-number: QTBUG-70770 Task-number: QTBUG-80755 Change-Id: I98f036f665a056c441efa00aab76ec47bc628057 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Replace Q_FOREACH with ranged for loopsJuha Vuolle2021-06-084-14/+11
| | | | | | Task-number: QTBUG-92505 Change-Id: I1e8334473c883f76285736f6a26138ea882f5351 Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Fix tst_qsensor autotestcase to pass on android deviceJuha Vuolle2021-06-032-10/+7
| | | | | | | | | | | | | | | The main issue with running the autotests on an Android device is that the device has real sensors too and the test case is not prepared for that. This commit addresses this by allowing additional available sensors as well as specifying more specifically which sensor IDs to use for testing. Task-number: QTBUG-73617 Task-number: QTBUG-92513 Change-Id: I92180df6f5e8361d39134567616b21a3a51b636c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alex Blasche <alexander.blasche@qt.io> Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
* Remove obsolete 'legacy' QML test case (cleanup)Juha Vuolle2021-06-031-192/+0
| | | | | | | | The case has been superseded years ago Task-number: QTBUG-92513 Change-Id: I7d27083863d57bfa94e49abcceb1be10f7bf5945 Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
* Few cleanups and modernizationsJuha Vuolle2021-06-021-0/+28
| | | | | | | | | | | This commit introduces few source compatible changes: - Change obsoleted Q_ENUMS => Q_ENUM - Mark QSensor::type property as CONSTANT as it cannot change - Add change signal to QSensor::identifier and a testcase for it Task-number: QTBUG-92505 Change-Id: I6e3a652929d15bc5211448be2ae9254ed6d21118 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Remove obsolete 'legacy' test case (cleanup)Juha Vuolle2021-06-022-282/+0
| | | | | | | | | | The term 'legacy' here refers to QtMobility sensors 1.2 implementation, and the test case removed by this commit has been disabled in 2012 when 1.3 was released. Task-number: QTBUG-92513 Change-Id: If6a2e72c9d7c97f0bf93a8acbc3521cceffab571 Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
* Split the Sensors QML plugin into a library and a pluginJuha Vuolle2021-05-262-5/+3
| | | | | | | | | | | | | | | The main changes: - Introduction of new SensorsQuick library with private exports - The original QML plugin loads this new library and does little else - Renamed original 'sensors' plugin as 'declarative_sensors' to provide an idea what it relates to - Renamed library headers as private "_p.h" and added "We mean it" - Changed qmlRegister* calls to QML_ELEMENT macros - Removed files that are generated in Qt6 (qmldir, plugins.qmltypes) Task-number: QTBUG-92530 Change-Id: I18f849adabcc79ac47e67305f78aefeee82801bc Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Rename subclass static variable which shadowed baseclass methodJuha Vuolle2021-05-196-24/+24
| | | | | | | | | | | The 'type' static variable shadowed the 'QSensors::type()' method of the baseclass. While this is easy to workaround it is better to remove such naming clash. Task-number: QTBUG-60246 Change-Id: Id0ddae978377ea4d4d0202a572c554c2541f9364 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Remove compiler warningsJuha Vuolle2021-05-181-3/+3
| | | | | | Task-number: QTBUG-92505 Change-Id: Iebfda5ae88594826d1253b725e1e15dd2bde7435 Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* Enable QtSensors manual tests as part of buildJuha Vuolle2021-04-306-125/+25
| | | | | | | | | | | | | | The two manual test applications are now part of build when manual tests are built. This helps to detect if the test applications break over time. The tests were slightly renamed to avoid a naming clash with an example app. In addition the commit addresses few trivial things so that the applications start and run without warnings. Task-number: QTBUG-92502 Change-Id: Ia0368764102efc16276116bc8c75d562d79c1e27 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* QtSensors initial cmake supportLorn Potter2021-04-1926-270/+207
| | | | | | | | | | | | | | | | | This commit introduces the bare minimum cmake support that should unblock the CI and allow further verification and development on most platforms: macOS, Linux, Win, iOS and Android. Some clarifications: * The support for sensorfw backend is very preliminary and can be enabled later if needed (no Qt6 version of the sensorfw). * The simulator backend is dropped as obsolete / unnecessary. * Three examples are currently commented out and shall be ported with a later commit. Task-number: QTBUG-92502 Change-Id: Id523d43ed3ef177010dc73afc5812ed374cff0dd Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Base commit to make QtSensors runnable on WindowsJuha Vuolle2021-04-192-32/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | Fair amount of work remains after the commit still, but this should allow further development as a compilable baseline: code compiles, autotests pass, and most example applications at least start. The changes: -Change examples to use QtQuickControls 2 as per removal of v1 -Fix ambiguous conditional expression compilation error -Link against runtimeobject library (previously part of winrt QPA?) -Change the .pro file rule to win32 as winrt moniker does not exist anymore -Remove references to deleted winrt event dispatcher -Fix error handling: getdefault may be successful even if there is no default sensor -Fix QCOMPARE failure output (toString has changed in Qt6) -Remove qtimestamp alias which was deprecated already in Qt5 -Remove unit test hook that does not seem to be used anywhere -From typedef to ‘using’ for readability -Q_ENUMS -> Q_ENUM as the former has been obsoleted by the latter -Add qt6 changes qdoc page Task-number: QTBUG-88616 Change-Id: I92c168228ba76106b2c636c88f54331c76c3d2e6 Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io> Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Add binary compatibility file for qtsensors 5.14 branchMilla Pohjanheimo2019-12-131-0/+6860
| | | | | | | BC file built against 5.14.0 added. Change-Id: I2d845df473db90a37287cc3ecf0dffcf4978ece9 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* Fix QML API for sensor rangesUlf Hermann2019-12-032-0/+117
| | | | | | | | | | | | | | | Previously the QQmlListProperties were constructed on stack-allocated lists, which immediately turned into dangling pointers on return. Also, none of the sensor ranges was ever deleted. Keep the sensor ranges in persistent lists in the private object, parent them to the main QmlSensor object, and add some tests for them. Fixes: QTBUG-79224 Change-Id: Ie61d0aaeaaaf998c1d1f46f60c81848ae48659d6 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io> Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
* Merge remote-tracking branch 'origin/5.13' into 5.14Qt Forward Merge Bot2019-10-261-1/+1
|\ | | | | | | Change-Id: Idb20ba0646891ab3b6fe73c88cee26747516eb30
| * Don't ask for gui when we don't need itEdward Welbourne2019-10-251-1/+1
| | | | | | | | | | | | | | | | Its inclusion in QT broke builds that are fine without it. Change-Id: I457def5945dc3db5b2cf2137c9de1917e941d0c3 Task-number: QTBUG-79353 Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* | Replace the deprecated qSort() -> std::sort()Sona Kurazyan2019-08-261-3/+3
|/ | | | | | Task-number: QTBUG-76491 Change-Id: I3fd78291e117947f38c77360054b8317561ffa28 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Binary compatibility file for Qt 5.13.0 for QtSensorsMilla Pohjanheimo2019-08-141-0/+6821
| | | | | | | | BC file added. Change-Id: Iec44777c1e7cf46c2c880cbb34ec394904d67736 Reviewed-by: Lorn Potter <lorn.potter@gmail.com> Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
* Binary compatibility file for QtSensors for Qt 5.12Milla Pohjanheimo2018-12-181-0/+6451
| | | | | | | Binary compatibility file added. Change-Id: I15a1890d0a921f4427b777d2324649e85db58bbb Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
* Add binary compatibility file for 5.11 for QtSensorsMilla Pohjanheimo2018-06-051-0/+6386
| | | | | | | Binary compatibility file for bic test added. Change-Id: Id0b45f457fd00ee388070fd07cb5dec69834d514 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
* Merge remote-tracking branch 'origin/5.10' into devLiang Qi2018-01-201-0/+6386
|\ | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I17dec1cd2d4934710663e5fa97c926a65fe301e5
| * Add binary compatibility file for QtSensors for 5.10Milla Pohjanheimo2018-01-081-0/+6386
| | | | | | | | | | | | | | | | File to test binary compatibility for 5.10 added Change-Id: Ic86425ada00f5c3804d50fff6d2e8618b2bc923e Reviewed-by: Sergio Ahumada <sahumada@texla.cl> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add missing override and remove redundant virtualAlexander Volkov2017-11-1419-65/+65
| | | | | | | | | | Change-Id: I51c0fc424f44ae68c3c1c4cf6377e7701ee5a0dd Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* | testSingleGestures: Fix for case of multiple gesturesAlexander Volkov2017-11-141-10/+21
|/ | | | | | | | | | | | | | | | This test fails sometimes for the twist gesture data, because it contains 3 gestures. QTRY_COMPARE_WITH_TIMEOUT usually stops comparison after recognition of the first gesture, but it may make the first comparison after more than one gesture has been recognized and thus fail the test. Add a new column to the test data with a list of gestures that should be recognized and use the list in QTRY_COMPARE_WITH_TIMEOUT. It will make the error message more informative if the test will fail, and should make the test pass on all configurations. Change-Id: Icfd86831b527da4933da2a20f45ccf9617862eac Reviewed-by: Lorn Potter <lorn.potter@gmail.com>