summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRolf Eike Beer <eb@emlix.com>2016-11-15 13:06:35 +0100
committerRolf Eike Beer <eb@emlix.com>2016-11-15 12:43:37 +0000
commitd1a766abd332b294bf945af8a732ddb61a2cb9f6 (patch)
treee6d95174d17644f877ca61b91e5a29fd66241ca5
parent0ce15a0b241ca46a76d0b5693c1b5b811c55ac49 (diff)
use switch/case in QCanBusFrame::toString() instead of multiple if's
Change-Id: I5c2940a37aa6d4261eb34ca8c90199905ba45868 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
-rw-r--r--src/serialbus/qcanbusframe.cpp12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/serialbus/qcanbusframe.cpp b/src/serialbus/qcanbusframe.cpp
index 1787c4c..787975a 100644
--- a/src/serialbus/qcanbusframe.cpp
+++ b/src/serialbus/qcanbusframe.cpp
@@ -321,14 +321,16 @@ QString QCanBusFrame::toString() const
{
const FrameType type = frameType();
- if (type == InvalidFrame)
+ switch (type) {
+ case InvalidFrame:
return QStringLiteral("(Invalid)");
-
- if (type == ErrorFrame)
+ case ErrorFrame:
return QStringLiteral("(Error)");
-
- if (type == UnknownFrame)
+ case UnknownFrame:
return QStringLiteral("(Unknown)");
+ default:
+ break;
+ }
const char *idFormat = hasExtendedFrameFormat() ? "%08X" : " %03X";
const char *dlcFormat = hasFlexibleDataRateFormat() ? " [%02d]" : " [%d]";