diff options
| author | Ivan Solovev <ivan.solovev@qt.io> | 2023-01-13 11:56:54 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2023-01-19 16:45:08 +0000 |
| commit | 2bfaf4bbaed2de69a74f1410346ba4a451354d9f (patch) | |
| tree | 285288748519b8f5922ae5fb5ea61f18d97f5ccc /src | |
| parent | 4e44412cde806c39d6b8328dc809d3092d6aaceb (diff) | |
QCanDbcFileParser: rename valueDescriptions() -> messageValueDescriptions()
As pointed out during Qt 6.5 API review, this would be a more suitable
name for the method, considering the return type.
Change-Id: I53ec41fb56d958454c596a23299254ee01d8d514
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
(cherry picked from commit 30e587c69b794b8e51e4ef24caf3477f868b904a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/serialbus/qcandbcfileparser.cpp | 6 | ||||
| -rw-r--r-- | src/serialbus/qcandbcfileparser.h | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/serialbus/qcandbcfileparser.cpp b/src/serialbus/qcandbcfileparser.cpp index 0cdd989..e327d7f 100644 --- a/src/serialbus/qcandbcfileparser.cpp +++ b/src/serialbus/qcandbcfileparser.cpp @@ -48,8 +48,8 @@ QT_BEGIN_NAMESPACE If the parsing completes successfully, call \l messageDescriptions() to get a list of the message descriptions that were extracted during the last - \l parse() call. Call \l valueDescriptions() to get the textual descriptions - of signal raw values, if they are available. + \l parse() call. Call \l messageValueDescriptions() to get the textual + descriptions of signal raw values, if they are available. Use the static \l uniqueIdDescription() function to get a \l QCanUniqueIdDescription for the DBC format. @@ -221,7 +221,7 @@ QList<QCanMessageDescription> QCanDbcFileParser::messageDescriptions() const QCanDbcFileParser::SignalValueDescriptions, QCanDbcFileParser::ValueDescriptions */ -QCanDbcFileParser::MessageValueDescriptions QCanDbcFileParser::valueDescriptions() const +QCanDbcFileParser::MessageValueDescriptions QCanDbcFileParser::messageValueDescriptions() const { return d->m_valueDescriptions; } diff --git a/src/serialbus/qcandbcfileparser.h b/src/serialbus/qcandbcfileparser.h index 7869fb4..8388461 100644 --- a/src/serialbus/qcandbcfileparser.h +++ b/src/serialbus/qcandbcfileparser.h @@ -26,7 +26,7 @@ public: ParseError }; - // The DBC protocol uses unsinged_integer to describe the supported values. + // The DBC protocol uses unsigned_integer to describe the supported values. // Do we need to use QVariant instead of quint32? Or qint64 for better BC // guarantees? using ValueDescriptions = QHash<quint32, QString>; @@ -40,7 +40,7 @@ public: bool parse(const QStringList &fileNames); QList<QCanMessageDescription> messageDescriptions() const; - MessageValueDescriptions valueDescriptions() const; + MessageValueDescriptions messageValueDescriptions() const; Error error() const; QString errorString() const; |