summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorKai Köhne <kai.koehne@qt.io>2021-11-16 12:09:47 +0100
committerKai Köhne <kai.koehne@qt.io>2021-11-16 12:30:45 +0100
commit30098c7e7ae83cfa56210f42a6f6cb0564c6d45c (patch)
treeddd08bddb974abb4940288b3df48f3693ecf632d /src
parentda4220c77b721b71fec0d06298f86915f185cc53 (diff)
CMake: Do not use PUBLIC_LIBRARIES in plugins
Fixes configure time warnings like CMake Warning (dev) at qtbase/cmake/QtPluginHelpers.cmake:57 (message): Plugins are not intended to be linked to. They should not have any public properties, but SystecCanBusPlugin sets PUBLIC_LIBRARIES to the following value: Qt::Core;Qt::Network;Qt::SerialBus Update your project to use LIBRARIES instead. Call Stack (most recent call first): qtserialbus/src/plugins/canbus/systeccan/CMakeLists.txt:5 (qt_internal_add_plugin) This warning is for project developers. Use -Wno-dev to suppress it. Pick-to: 6.2 Change-Id: Id287feb59e4a13d64868c4df6c1f77e10d90d2ca Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/plugins/canbus/systeccan/CMakeLists.txt2
-rw-r--r--src/plugins/canbus/vectorcan/CMakeLists.txt2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/canbus/systeccan/CMakeLists.txt b/src/plugins/canbus/systeccan/CMakeLists.txt
index 5d6e144..c1a1bec 100644
--- a/src/plugins/canbus/systeccan/CMakeLists.txt
+++ b/src/plugins/canbus/systeccan/CMakeLists.txt
@@ -9,7 +9,7 @@ qt_internal_add_plugin(SystecCanBusPlugin
main.cpp
systeccan_symbols_p.h
systeccanbackend.cpp systeccanbackend.h systeccanbackend_p.h
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::Network
Qt::SerialBus
diff --git a/src/plugins/canbus/vectorcan/CMakeLists.txt b/src/plugins/canbus/vectorcan/CMakeLists.txt
index 1642bec..585ada3 100644
--- a/src/plugins/canbus/vectorcan/CMakeLists.txt
+++ b/src/plugins/canbus/vectorcan/CMakeLists.txt
@@ -9,7 +9,7 @@ qt_internal_add_plugin(VectorCanBusPlugin
main.cpp
vectorcan_symbols_p.h
vectorcanbackend.cpp vectorcanbackend.h vectorcanbackend_p.h
- PUBLIC_LIBRARIES
+ LIBRARIES
Qt::Core
Qt::Network
Qt::SerialBus