diff options
author | Alex Blasche <alexander.blasche@theqtcompany.com> | 2015-11-05 11:41:39 +0100 |
---|---|---|
committer | Karsten Heimrich <karsten.heimrich@theqtcompany.com> | 2015-11-05 12:08:31 +0000 |
commit | 794d6b2f9c95e47e5d4aedbb56b296c6053f92de (patch) | |
tree | c35962871170ff8fc016ae56e276f7ce31671625 /tests | |
parent | 1fb44b9ace805f0c18accbc02a578c1c72ac4136 (diff) |
Cleanup QModbusDataUnit documentation and code
reset() was removed, incorrect documentation fixed and some minor doc
layout issues resolved. The unit test was modified to test further
cases.
Change-Id: I77caae7cdd5d89bae35cd487370a8f6d813d1dc1
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auto/qmodbusdataunit/tst_qmodbusdataunit.cpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/tests/auto/qmodbusdataunit/tst_qmodbusdataunit.cpp b/tests/auto/qmodbusdataunit/tst_qmodbusdataunit.cpp index 8fbcb0b..378fd75 100644 --- a/tests/auto/qmodbusdataunit/tst_qmodbusdataunit.cpp +++ b/tests/auto/qmodbusdataunit/tst_qmodbusdataunit.cpp @@ -67,6 +67,8 @@ void tst_QModbusDataUnit::constructors() QCOMPARE(coils.startAddress(), 15); QCOMPARE(coils.values().size(), 20); QCOMPARE(coils.values(), QVector<quint16>(20)); + foreach (auto val, coils.values()) + QCOMPARE(val, quint16(0)); QCOMPARE(coils.valueCount(), 20u); QModbusDataUnit unit2(QModbusDataUnit::HoldingRegisters, 3, QVector<quint16>() << 9); @@ -139,6 +141,12 @@ void tst_QModbusDataUnit::testAPI() } QModbusDataUnit unit; + QCOMPARE(unit.isValid(), false); + QCOMPARE(unit.registerType(), QModbusDataUnit::Invalid); + QCOMPARE(unit.startAddress(), -1); + QCOMPARE(unit.valueCount(), 0u); + QCOMPARE(unit.values(), QVector<quint16>()); + unit.setStartAddress(15); unit.setRegisterType(QModbusDataUnit::Coils); QCOMPARE(unit.isValid(), true); @@ -154,13 +162,6 @@ void tst_QModbusDataUnit::testAPI() QCOMPARE(unit.value(0), quint16(1)); unit.setValue(0, 25); QCOMPARE(unit.value(0), quint16(25)); - - unit.reset(); - QCOMPARE(unit.isValid(), false); - QCOMPARE(unit.registerType(), QModbusDataUnit::Invalid); - QCOMPARE(unit.startAddress(), -1); - QCOMPARE(unit.valueCount(), 0u); - QCOMPARE(unit.values(), QVector<quint16>()); } QTEST_MAIN(tst_QModbusDataUnit) |