From 287c43c9c35e900dbf8e820c60d0b71cbe9099ef Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sun, 19 Mar 2017 12:42:41 +0100 Subject: modbus master example: fix nonsensical code Pointed out by GCC 7: writeregistermodel.cpp:117:48: warning: enum constant in boolean context [-Wint-in-bool-context] if (index.column() == HoldingColumn && Qt::EditRole) { // holding registers ^~~~~~~~ Change-Id: I5d0f19c0480b027109c6a751f69852114cb634b2 Reviewed-by: Denis Shienkov Reviewed-by: David Faure --- examples/serialbus/modbus/master/writeregistermodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'examples/serialbus') diff --git a/examples/serialbus/modbus/master/writeregistermodel.cpp b/examples/serialbus/modbus/master/writeregistermodel.cpp index a664482..60684c4 100644 --- a/examples/serialbus/modbus/master/writeregistermodel.cpp +++ b/examples/serialbus/modbus/master/writeregistermodel.cpp @@ -114,7 +114,7 @@ bool WriteRegisterModel::setData(const QModelIndex &index, const QVariant &value return true; } - if (index.column() == HoldingColumn && Qt::EditRole) { // holding registers + if (index.column() == HoldingColumn && role == Qt::EditRole) { // holding registers bool result = false; quint16 newValue = value.toString().toUShort(&result, 16); if (result) -- cgit v1.2.3