From 80144b89ca1adede0db9d6e485037f5e431216c3 Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Sat, 21 Sep 2019 14:55:08 +0200 Subject: CAN: Avoid symbol clashes on static builds Having the same function name in a global namespace can lead the linker to pick an arbitrary one instead the right one. [ChangeLog] Fixed problems on static builds where an arbitrary version of resolveSymbol() was used instead the correct one. Fixes: QTBUG-78546 Change-Id: I0ff9bc3e5905b3b9694dfe9d446b2a52700f213f Reviewed-by: Karsten Heimrich --- src/plugins/canbus/vectorcan/vectorcan_symbols_p.h | 2 +- src/plugins/canbus/vectorcan/vectorcanbackend.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/plugins/canbus/vectorcan') diff --git a/src/plugins/canbus/vectorcan/vectorcan_symbols_p.h b/src/plugins/canbus/vectorcan/vectorcan_symbols_p.h index 3f2501f..6e35ba4 100644 --- a/src/plugins/canbus/vectorcan/vectorcan_symbols_p.h +++ b/src/plugins/canbus/vectorcan/vectorcan_symbols_p.h @@ -458,7 +458,7 @@ GENERATE_SYMBOL_VARIABLE(XLstatus, xlReceive, XLportHandle, quint32 *, XLevent * GENERATE_SYMBOL_VARIABLE(XLstatus, xlSetNotification, XLportHandle, XLhandle *, int) GENERATE_SYMBOL_VARIABLE(char *, xlGetErrorString, XLstatus) -inline bool resolveSymbols(QLibrary *vectorcanLibrary) +inline bool resolveVectorCanSymbols(QLibrary *vectorcanLibrary) { if (!vectorcanLibrary->isLoaded()) { #ifdef Q_PROCESSOR_X86_64 diff --git a/src/plugins/canbus/vectorcan/vectorcanbackend.cpp b/src/plugins/canbus/vectorcan/vectorcanbackend.cpp index 9026888..40ba0ac 100644 --- a/src/plugins/canbus/vectorcan/vectorcanbackend.cpp +++ b/src/plugins/canbus/vectorcan/vectorcanbackend.cpp @@ -61,7 +61,7 @@ bool VectorCanBackend::canCreate(QString *errorReason) #ifdef LINK_LIBVECTORCAN return true; #else - static bool symbolsResolved = resolveSymbols(vectorcanLibrary()); + static bool symbolsResolved = resolveVectorCanSymbols(vectorcanLibrary()); if (Q_UNLIKELY(!symbolsResolved)) { *errorReason = vectorcanLibrary()->errorString(); return false; -- cgit v1.2.3