summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2014-09-27 23:22:04 +0400
committerDenis Shienkov <denis.shienkov@gmail.com>2014-09-28 18:25:02 +0200
commit54a07b350895b4fdd4143ac2ce9d2d99d86bba42 (patch)
treebd1702838014c8d1cd5587b41c0e2ba567971f7f
parent738d20dbd952ccdf28187b64526733aab345031f (diff)
Fix order of passed parameters into QCOMPARE
According to documentation the QCOMPARE should accept to the first parameter an actual value, and to the second parameter an expected value. Change-Id: I64e762e779fa6a61401f358c4dd6097dacf7a33a Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
-rw-r--r--tests/auto/qserialport/tst_qserialport.cpp14
1 files changed, 7 insertions, 7 deletions
diff --git a/tests/auto/qserialport/tst_qserialport.cpp b/tests/auto/qserialport/tst_qserialport.cpp
index af767dde..9feccd49 100644
--- a/tests/auto/qserialport/tst_qserialport.cpp
+++ b/tests/auto/qserialport/tst_qserialport.cpp
@@ -470,27 +470,27 @@ void tst_QSerialPort::twoStageSynchronousLoopback()
senderPort.waitForBytesWritten(waitMsecs);
QTest::qSleep(waitMsecs);
receiverPort.waitForReadyRead(waitMsecs);
- QCOMPARE(qint64(newlineArray.size()), receiverPort.bytesAvailable());
+ QCOMPARE(receiverPort.bytesAvailable(), qint64(newlineArray.size()));
receiverPort.write(receiverPort.readAll());
receiverPort.waitForBytesWritten(waitMsecs);
QTest::qSleep(waitMsecs);
senderPort.waitForReadyRead(waitMsecs);
- QCOMPARE(qint64(newlineArray.size()), receiverPort.bytesAvailable());
- QCOMPARE(newlineArray, senderPort.readAll());
+ QCOMPARE(receiverPort.bytesAvailable(), qint64(newlineArray.size()));
+ QCOMPARE(senderPort.readAll(), newlineArray);
// second stage
senderPort.write(newlineArray);
senderPort.waitForBytesWritten(waitMsecs);
QTest::qSleep(waitMsecs);
receiverPort.waitForReadyRead(waitMsecs);
- QCOMPARE(qint64(newlineArray.size()), receiverPort.bytesAvailable());
+ QCOMPARE(receiverPort.bytesAvailable(), qint64(newlineArray.size()));
receiverPort.write(receiverPort.readAll());
receiverPort.waitForBytesWritten(waitMsecs);
QTest::qSleep(waitMsecs);
senderPort.waitForReadyRead(waitMsecs);
- QCOMPARE(qint64(newlineArray.size()), receiverPort.bytesAvailable());
- QCOMPARE(newlineArray, senderPort.readAll());
+ QCOMPARE(receiverPort.bytesAvailable(), qint64(newlineArray.size()));
+ QCOMPARE(senderPort.readAll(), newlineArray);
}
void tst_QSerialPort::synchronousReadWrite()
@@ -516,7 +516,7 @@ void tst_QSerialPort::synchronousReadWrite()
while ((readData.size() < writeData.size()) && receiverPort.waitForReadyRead(100))
readData.append(receiverPort.readAll());
- QCOMPARE(writeData, readData);
+ QCOMPARE(readData, writeData);
}
class AsyncReader : public QObject