diff options
author | Kai Köhne <kai.koehne@qt.io> | 2022-02-14 19:27:10 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-02-21 09:40:12 +0000 |
commit | 1c5b578a0e4b08496c3118becb3078069dcf271f (patch) | |
tree | 34226a4ea90a7d7cbbbcad97d74e70e7234d314c | |
parent | 789d861c6eaf568cacd103e6bb9f0b7811882fa9 (diff) |
Improve examples CMakeLists.txt
- Remove "# generated from xyz.pro" comment from pro2cmake
- Remove automatic use of CMAKE_AUTORCC
- Only opt into CMAKE_AUTOUIC if .ui files are involved
- Remove explicit setting of CMAKE_INCLUDE_CURRENT_DIR
- Combine multiple find_package(Qt6 ... calls)
- use REQUIRED COMPONENTS
- sort components alphabetically
- Fix wrong indentations
- Use (only) one empty line after multi-line commands
Change-Id: I024f0c99756c2583a867022b8478f06e088a39af
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit 7364adf4725a044819ab50ce55f82ad522f9c442)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r-- | examples/serialport/blockingreceiver/CMakeLists.txt | 13 | ||||
-rw-r--r-- | examples/serialport/blockingsender/CMakeLists.txt | 13 | ||||
-rw-r--r-- | examples/serialport/cenumerator/CMakeLists.txt | 11 | ||||
-rw-r--r-- | examples/serialport/creaderasync/CMakeLists.txt | 11 | ||||
-rw-r--r-- | examples/serialport/creadersync/CMakeLists.txt | 11 | ||||
-rw-r--r-- | examples/serialport/cwriterasync/CMakeLists.txt | 11 | ||||
-rw-r--r-- | examples/serialport/cwritersync/CMakeLists.txt | 11 | ||||
-rw-r--r-- | examples/serialport/enumerator/CMakeLists.txt | 13 | ||||
-rw-r--r-- | examples/serialport/receiver/CMakeLists.txt | 13 | ||||
-rw-r--r-- | examples/serialport/sender/CMakeLists.txt | 13 | ||||
-rw-r--r-- | examples/serialport/terminal/CMakeLists.txt | 13 |
11 files changed, 44 insertions, 89 deletions
diff --git a/examples/serialport/blockingreceiver/CMakeLists.txt b/examples/serialport/blockingreceiver/CMakeLists.txt index 6e7ce13b..bc660624 100644 --- a/examples/serialport/blockingreceiver/CMakeLists.txt +++ b/examples/serialport/blockingreceiver/CMakeLists.txt @@ -1,32 +1,27 @@ cmake_minimum_required(VERSION 3.16) project(blockingreceiver LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/blockingreceiver") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(blockingreceiver dialog.cpp dialog.h main.cpp receiverthread.cpp receiverthread.h ) + set_target_properties(blockingreceiver PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(blockingreceiver PRIVATE Qt::Core Qt::Gui diff --git a/examples/serialport/blockingsender/CMakeLists.txt b/examples/serialport/blockingsender/CMakeLists.txt index 90d8014f..f2459324 100644 --- a/examples/serialport/blockingsender/CMakeLists.txt +++ b/examples/serialport/blockingsender/CMakeLists.txt @@ -1,32 +1,27 @@ cmake_minimum_required(VERSION 3.16) project(blockingsender LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/blockingsender") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(blockingsender dialog.cpp dialog.h main.cpp senderthread.cpp senderthread.h ) + set_target_properties(blockingsender PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(blockingsender PRIVATE Qt::Core Qt::Gui diff --git a/examples/serialport/cenumerator/CMakeLists.txt b/examples/serialport/cenumerator/CMakeLists.txt index b3a4a1f4..1270e06f 100644 --- a/examples/serialport/cenumerator/CMakeLists.txt +++ b/examples/serialport/cenumerator/CMakeLists.txt @@ -1,28 +1,25 @@ cmake_minimum_required(VERSION 3.16) project(cenumerator LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/cenumerator") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core SerialPort) qt_add_executable(cenumerator main.cpp ) + set_target_properties(cenumerator PROPERTIES WIN32_EXECUTABLE FALSE MACOSX_BUNDLE FALSE ) + target_link_libraries(cenumerator PRIVATE Qt::Core Qt::SerialPort diff --git a/examples/serialport/creaderasync/CMakeLists.txt b/examples/serialport/creaderasync/CMakeLists.txt index 82a726eb..ef13280f 100644 --- a/examples/serialport/creaderasync/CMakeLists.txt +++ b/examples/serialport/creaderasync/CMakeLists.txt @@ -1,29 +1,26 @@ cmake_minimum_required(VERSION 3.16) project(creaderasync LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/creaderasync") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core SerialPort) qt_add_executable(creaderasync main.cpp serialportreader.cpp serialportreader.h ) + set_target_properties(creaderasync PROPERTIES WIN32_EXECUTABLE FALSE MACOSX_BUNDLE FALSE ) + target_link_libraries(creaderasync PRIVATE Qt::Core Qt::SerialPort diff --git a/examples/serialport/creadersync/CMakeLists.txt b/examples/serialport/creadersync/CMakeLists.txt index 5b3f20b8..5d06f777 100644 --- a/examples/serialport/creadersync/CMakeLists.txt +++ b/examples/serialport/creadersync/CMakeLists.txt @@ -1,28 +1,25 @@ cmake_minimum_required(VERSION 3.16) project(creadersync LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/creadersync") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core SerialPort) qt_add_executable(creadersync main.cpp ) + set_target_properties(creadersync PROPERTIES WIN32_EXECUTABLE FALSE MACOSX_BUNDLE FALSE ) + target_link_libraries(creadersync PRIVATE Qt::Core Qt::SerialPort diff --git a/examples/serialport/cwriterasync/CMakeLists.txt b/examples/serialport/cwriterasync/CMakeLists.txt index 88438f78..ae729eef 100644 --- a/examples/serialport/cwriterasync/CMakeLists.txt +++ b/examples/serialport/cwriterasync/CMakeLists.txt @@ -1,29 +1,26 @@ cmake_minimum_required(VERSION 3.16) project(cwriterasync LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/cwriterasync") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core SerialPort) qt_add_executable(cwriterasync main.cpp serialportwriter.cpp serialportwriter.h ) + set_target_properties(cwriterasync PROPERTIES WIN32_EXECUTABLE FALSE MACOSX_BUNDLE FALSE ) + target_link_libraries(cwriterasync PRIVATE Qt::Core Qt::SerialPort diff --git a/examples/serialport/cwritersync/CMakeLists.txt b/examples/serialport/cwritersync/CMakeLists.txt index db05236e..0484ab5d 100644 --- a/examples/serialport/cwritersync/CMakeLists.txt +++ b/examples/serialport/cwritersync/CMakeLists.txt @@ -1,28 +1,25 @@ cmake_minimum_required(VERSION 3.16) project(cwritersync LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/cwritersync") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core SerialPort) qt_add_executable(cwritersync main.cpp ) + set_target_properties(cwritersync PROPERTIES WIN32_EXECUTABLE FALSE MACOSX_BUNDLE FALSE ) + target_link_libraries(cwritersync PRIVATE Qt::Core Qt::SerialPort diff --git a/examples/serialport/enumerator/CMakeLists.txt b/examples/serialport/enumerator/CMakeLists.txt index 416eb092..d9689c74 100644 --- a/examples/serialport/enumerator/CMakeLists.txt +++ b/examples/serialport/enumerator/CMakeLists.txt @@ -1,30 +1,25 @@ cmake_minimum_required(VERSION 3.16) project(enumerator LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/enumerator") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(enumerator main.cpp ) + set_target_properties(enumerator PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(enumerator PRIVATE Qt::Core Qt::Gui diff --git a/examples/serialport/receiver/CMakeLists.txt b/examples/serialport/receiver/CMakeLists.txt index cc271eb0..7d759c55 100644 --- a/examples/serialport/receiver/CMakeLists.txt +++ b/examples/serialport/receiver/CMakeLists.txt @@ -1,31 +1,26 @@ cmake_minimum_required(VERSION 3.16) project(receiver LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/receiver") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(receiver dialog.cpp dialog.h main.cpp ) + set_target_properties(receiver PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(receiver PRIVATE Qt::Core Qt::Gui diff --git a/examples/serialport/sender/CMakeLists.txt b/examples/serialport/sender/CMakeLists.txt index 024a0b10..0146160d 100644 --- a/examples/serialport/sender/CMakeLists.txt +++ b/examples/serialport/sender/CMakeLists.txt @@ -1,31 +1,26 @@ cmake_minimum_required(VERSION 3.16) project(sender LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) -set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/sender") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(sender dialog.cpp dialog.h main.cpp ) + set_target_properties(sender PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(sender PRIVATE Qt::Core Qt::Gui diff --git a/examples/serialport/terminal/CMakeLists.txt b/examples/serialport/terminal/CMakeLists.txt index 0a8c0532..d3a37397 100644 --- a/examples/serialport/terminal/CMakeLists.txt +++ b/examples/serialport/terminal/CMakeLists.txt @@ -1,22 +1,16 @@ cmake_minimum_required(VERSION 3.16) project(terminal LANGUAGES CXX) -set(CMAKE_INCLUDE_CURRENT_DIR ON) - set(CMAKE_AUTOMOC ON) -set(CMAKE_AUTORCC ON) set(CMAKE_AUTOUIC ON) if(NOT DEFINED INSTALL_EXAMPLESDIR) - set(INSTALL_EXAMPLESDIR "examples") + set(INSTALL_EXAMPLESDIR "examples") endif() set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/serialport/terminal") -find_package(Qt6 COMPONENTS Core) -find_package(Qt6 COMPONENTS Gui) -find_package(Qt6 COMPONENTS Widgets) -find_package(Qt6 COMPONENTS SerialPort) +find_package(Qt6 REQUIRED COMPONENTS Core Gui SerialPort Widgets) qt_add_executable(terminal console.cpp console.h @@ -24,10 +18,12 @@ qt_add_executable(terminal mainwindow.cpp mainwindow.h mainwindow.ui settingsdialog.cpp settingsdialog.h settingsdialog.ui ) + set_target_properties(terminal PROPERTIES WIN32_EXECUTABLE TRUE MACOSX_BUNDLE TRUE ) + target_link_libraries(terminal PRIVATE Qt::Core Qt::Gui @@ -35,7 +31,6 @@ target_link_libraries(terminal PRIVATE Qt::Widgets ) - # Resources: set(terminal_resource_files "images/application-exit.png" |