diff options
author | Denis Shienkov <denis.shienkov@gmail.com> | 2013-10-17 19:24:23 +0400 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-10-21 20:27:08 +0200 |
commit | c8b53127b15f45c6d529bff7438a56f81a4ea032 (patch) | |
tree | 1ccf3b54218ca9d0c3a3bb5bf22303ab4b3dd949 | |
parent | 07e3a5813084ca6c2175b028a588bcfb6d83d439 (diff) |
Do not call CancelIo() in the AbstractOverlappedEventNotifier destructorv5.2.0-beta1
This function is used for "CreateFile" calls as opposed to "CreateEvent".
Hence, the usage has been erroneous in here.
See the MSDN links below for further details:
Overall: http://msdn.microsoft.com/en-us/library/windows/desktop/aa363791%28v=vs.85%29.aspx
CreateFile: http://msdn.microsoft.com/en-us/library/windows/desktop/aa363858%28v=vs.85%29.aspx
CreateEvent: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682396%28v=vs.85%29.aspx
It is also observed with a bit of testing that CancelIo() returns
ERROR_INVALID_HANDLE for some reason. This has not been tracked down though,
so it may be red-herring.
Change-Id: Ic2aea712763907dd9c9a32169702fa06308a7ee8
Reviewed-by: Laszlo Papp <lpapp@kde.org>
-rw-r--r-- | src/serialport/qserialport_win.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp index 536451d8..f042ee82 100644 --- a/src/serialport/qserialport_win.cpp +++ b/src/serialport/qserialport_win.cpp @@ -105,7 +105,6 @@ public: virtual ~AbstractOverlappedEventNotifier() { setEnabled(false); - ::CancelIo(o.hEvent); ::CloseHandle(o.hEvent); } |