From 5faf8cc2ea0f757327c23e086caa6309eebeaec3 Mon Sep 17 00:00:00 2001 From: Antti Kokko Date: Tue, 30 Jul 2019 11:25:41 +0300 Subject: Add changes file for Qt 5.13.1 Change-Id: Ie729f172439c4b48458de0a1829c8017f649470f Reviewed-by: Denis Shienkov --- dist/changes-5.13.1 | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 dist/changes-5.13.1 diff --git a/dist/changes-5.13.1 b/dist/changes-5.13.1 new file mode 100644 index 00000000..57ebdbeb --- /dev/null +++ b/dist/changes-5.13.1 @@ -0,0 +1,20 @@ +Qt 5.13.1 is a bug-fix release. It maintains both forward and backward +compatibility (source and binary) with Qt 5.13.0. + +For more details, refer to the online documentation included in this +distribution. The documentation is also available online: + +https://doc.qt.io/qt-5/index.html + +The Qt version 5.13 series is binary compatible with the 5.12.x series. +Applications compiled for 5.12 will continue to run with 5.13. + +Some of the changes listed in this file include issue tracking numbers +corresponding to tasks in the Qt Bug Tracker: + +https://bugreports.qt.io/ + +Each of these identifiers can be entered in the bug tracker to obtain more +information about a particular change. + + - This release contains only minor code improvements. -- cgit v1.2.3 From b1413c11b999aadca302c1b12dd90a12b55a1f12 Mon Sep 17 00:00:00 2001 From: Antti Kokko Date: Tue, 20 Aug 2019 13:16:24 +0300 Subject: Add changes file for Qt 5.12.5 + 85ee2c658a45d2958a54045951d236769640337f Emit _q_notify only if there's no notification pending + 9509b6d3ee02c3c4a0b98dc95bc9787a3c514a18 Bump version Change-Id: I28e0b9585b0e5ba0c4ee1be9f968b8c515e23b25 Reviewed-by: Denis Shienkov --- dist/changes-5.12.5 | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 dist/changes-5.12.5 diff --git a/dist/changes-5.12.5 b/dist/changes-5.12.5 new file mode 100644 index 00000000..e8be9316 --- /dev/null +++ b/dist/changes-5.12.5 @@ -0,0 +1,20 @@ +Qt 5.12.5 is a bug-fix release. It maintains both forward and backward +compatibility (source and binary) with Qt 5.12.0 through 5.12.4. + +For more details, refer to the online documentation included in this +distribution. The documentation is also available online: + +https://doc.qt.io/qt-5/index.html + +The Qt version 5.12 series is binary compatible with the 5.11.x series. +Applications compiled for 5.11 will continue to run with 5.12. + +Some of the changes listed in this file include issue tracking numbers +corresponding to tasks in the Qt Bug Tracker: + +https://bugreports.qt.io/ + +Each of these identifiers can be entered in the bug tracker to obtain more +information about a particular change. + + - This release contains only minor code improvements. -- cgit v1.2.3 From f6b43c36b3839dae54308a6437bbdd99ae9a44de Mon Sep 17 00:00:00 2001 From: Denis Shienkov Date: Fri, 6 Sep 2019 21:19:52 +0300 Subject: Revert "Emit _q_notify only if there's no notification pending" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 85ee2c658a45d2958a54045951d236769640337f. That commit completely breaks the I/O on Windows. Task-number: QTBUG-78086 Change-Id: I9125967d6cb5b1cb4e33d0bad80ee66322e5ccc7 Reviewed-by: Jörg Bornemann --- src/serialport/qwinoverlappedionotifier.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/serialport/qwinoverlappedionotifier.cpp b/src/serialport/qwinoverlappedionotifier.cpp index 233ee696..615dacc9 100644 --- a/src/serialport/qwinoverlappedionotifier.cpp +++ b/src/serialport/qwinoverlappedionotifier.cpp @@ -129,7 +129,6 @@ public: HANDLE hSemaphore = nullptr; HANDLE hResultsMutex = nullptr; QAtomicInt waiting; - QAtomicInt pendingNotifications; QQueue results; }; @@ -396,17 +395,14 @@ void QWinOverlappedIoNotifierPrivate::notify(DWORD numberOfBytes, DWORD errorCod results.enqueue(IOResult(numberOfBytes, errorCode, overlapped)); ReleaseMutex(hResultsMutex); ReleaseSemaphore(hSemaphore, 1, NULL); - if (!waiting && pendingNotifications-- == 0) + if (!waiting) emit q->_q_notify(); } void QWinOverlappedIoNotifierPrivate::_q_notified() { - int n = pendingNotifications.fetchAndStoreAcquire(0); - while (--n >= 0) { - if (WaitForSingleObject(hSemaphore, 0) == WAIT_OBJECT_0) - dispatchNextIoResult(); - } + if (WaitForSingleObject(hSemaphore, 0) == WAIT_OBJECT_0) + dispatchNextIoResult(); } OVERLAPPED *QWinOverlappedIoNotifierPrivate::dispatchNextIoResult() -- cgit v1.2.3 From ba7eb7316d8586c6a30e759c26fed30c5b0ff5ae Mon Sep 17 00:00:00 2001 From: Liang Qi Date: Wed, 18 Sep 2019 08:58:24 +0200 Subject: Port ntddmodm config test to new configure system MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ib8c633534df0cf025b8d9845de6322b8285e73c1 Reviewed-by: Friedemann Kleint Reviewed-by: Qt CI Bot Reviewed-by: Jörg Bornemann --- config.tests/ntddmodm/main.cpp | 47 -------------------------------------- config.tests/ntddmodm/ntddmodm.pro | 4 ---- configure.json | 5 ++-- src/serialport/configure.json | 42 ++++++++++++++++++++++++++++++++++ 4 files changed, 45 insertions(+), 53 deletions(-) delete mode 100644 config.tests/ntddmodm/main.cpp delete mode 100644 config.tests/ntddmodm/ntddmodm.pro create mode 100644 src/serialport/configure.json diff --git a/config.tests/ntddmodm/main.cpp b/config.tests/ntddmodm/main.cpp deleted file mode 100644 index a881f874..00000000 --- a/config.tests/ntddmodm/main.cpp +++ /dev/null @@ -1,47 +0,0 @@ -/**************************************************************************** -** -** Copyright (C) 2015 Denis Shienkov -** Contact: https://www.qt.io/licensing/ -** -** This file is part of the QtSerialPort module of the Qt Toolkit. -** -** $QT_BEGIN_LICENSE:LGPL$ -** Commercial License Usage -** Licensees holding valid commercial Qt licenses may use this file in -** accordance with the commercial license agreement provided with the -** Software or, alternatively, in accordance with the terms contained in -** a written agreement between you and The Qt Company. For licensing terms -** and conditions see https://www.qt.io/terms-conditions. For further -** information use the contact form at https://www.qt.io/contact-us. -** -** GNU Lesser General Public License Usage -** Alternatively, this file may be used under the terms of the GNU Lesser -** General Public License version 3 as published by the Free Software -** Foundation and appearing in the file LICENSE.LGPL3 included in the -** packaging of this file. Please review the following information to -** ensure the GNU Lesser General Public License version 3 requirements -** will be met: https://www.gnu.org/licenses/lgpl-3.0.html. -** -** GNU General Public License Usage -** Alternatively, this file may be used under the terms of the GNU -** General Public License version 2.0 or (at your option) the GNU General -** Public license version 3 or any later version approved by the KDE Free -** Qt Foundation. The licenses are as published by the Free Software -** Foundation and appearing in the file LICENSE.GPL2 and LICENSE.GPL3 -** included in the packaging of this file. Please review the following -** information to ensure the GNU General Public License requirements will -** be met: https://www.gnu.org/licenses/gpl-2.0.html and -** https://www.gnu.org/licenses/gpl-3.0.html. -** -** $QT_END_LICENSE$ -** -****************************************************************************/ - -#include -#include - -int main(int, char**) -{ - GUID guid = GUID_DEVINTERFACE_MODEM; - return 0; -} diff --git a/config.tests/ntddmodm/ntddmodm.pro b/config.tests/ntddmodm/ntddmodm.pro deleted file mode 100644 index abb9ba83..00000000 --- a/config.tests/ntddmodm/ntddmodm.pro +++ /dev/null @@ -1,4 +0,0 @@ -CONFIG -= qt -CONFIG += console - -SOURCES += main.cpp diff --git a/configure.json b/configure.json index 16857005..fdfda244 100644 --- a/configure.json +++ b/configure.json @@ -1,4 +1,5 @@ { - "module": "serialport", - "condition": "!config.integrity && !config.vxworks && !config.winrt && !config.uikit && !config.wasm" + "subconfigs": [ + "src/serialport" + ] } diff --git a/src/serialport/configure.json b/src/serialport/configure.json new file mode 100644 index 00000000..f0e6c76e --- /dev/null +++ b/src/serialport/configure.json @@ -0,0 +1,42 @@ +{ + "module": "serialport", + "condition": "!config.integrity && !config.vxworks && !config.winrt && !config.uikit && !config.wasm", + "depends": [ + "core" + ], + "condition": "module.core", + + "tests": { + "ntddmodm": { + "label": "ntddmodm", + "type": "compile", + "test": { + "include": [ "windows.h", "ntddmodm.h"], + "main": [ + "GUID guid = GUID_DEVINTERFACE_MODEM;" + ] + } + } + }, + + "features": { + "ntddmodm": { + "label": "ntddmodm", + "disable": "input.ntddmodm == 'no'", + "condition": "tests.ntddmodm", + "output": [ + "privateFeature", + { "type": "define", "negative": true, "name": "QT_NO_REDEFINE_GUID_DEVINTERFACE_MODEM" } + ] + } + }, + + "summary": [ + { + "section": "Serial Port", + "entries": [ + "ntddmodm" + ] + } + ] +} -- cgit v1.2.3