summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBogDan Vatra <bogdan@kde.org>2013-10-17 14:17:18 +0300
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-10-17 13:31:18 +0200
commit3dcf8500f4760ba002327a598230811e2fb5d4f4 (patch)
treee9d22cb073151670c8fbd0f34add6d83c8874bee
parent61547c8e43390a36a2cda0ca6856e2f0f53547c0 (diff)
Fix handling android dependency xml.
Run readAndroidDependencyXml only once for every Qt library. Task-number: QTBUG-34078 Change-Id: Ifc2c18f23485e2ced20b0ce3f151a21cb1a0069a Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
-rw-r--r--src/androiddeployqt/main.cpp14
1 files changed, 4 insertions, 10 deletions
diff --git a/src/androiddeployqt/main.cpp b/src/androiddeployqt/main.cpp
index 9db070642..e798a0c79 100644
--- a/src/androiddeployqt/main.cpp
+++ b/src/androiddeployqt/main.cpp
@@ -1173,21 +1173,15 @@ bool readDependenciesFromElf(Options *options,
options->qtDependencies.append(dependency);
if (options->verbose)
fprintf(stderr, "Appending dependency: %s\n", qPrintable(dependency));
- }
- // Add the implicit dependencies for later
- foreach (QString dependency, dependencies) {
- if (dependency.startsWith(QLatin1String("lib/lib")) && dependency.endsWith(QLatin1String(".so"))) {
- QString qtBaseName = dependency.mid(sizeof("lib/lib") - 1);
- qtBaseName = qtBaseName.left(qtBaseName.size() - (sizeof(".so") - 1));
- if (!readAndroidDependencyXml(options, qtBaseName, usedDependencies, remainingDependencies)) {
- return false;
- }
+ QString qtBaseName = dependency.mid(sizeof("lib/lib") - 1);
+ qtBaseName = qtBaseName.left(qtBaseName.size() - (sizeof(".so") - 1));
+ if (!readAndroidDependencyXml(options, qtBaseName, usedDependencies, remainingDependencies)) {
+ return false;
}
}
return true;
}
-
bool readDependencies(Options *options)
{
if (options->verbose)