summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrancisco Boni <boboniboni@gmail.com>2022-02-19 13:33:32 -0300
committerAlexandru Croitor <alexandru.croitor@qt.io>2022-02-28 10:59:41 +0100
commit703cf71de5f20e00e9ff06bffb49481ee4e4b1b4 (patch)
treebb522fbc700a412ca94fed7660423d2f4c4b8bd3
parent5782feea0fe3ffd0cfe806d74f3363feae242548 (diff)
Fix FindWrapLibClang.cmake run for Clang-based lupdate
When FindWrapLibClang.cmake runs for the Clang-based lupdate parser, it fails because the generator expression __qt_clang_genex in target_link_libraries is not explicitly quoted. According to cmake docs (https://cmake.org/cmake/help/latest/command/target_link_libraries.html#target-link-libraries): "If the ... contains any ; characters, e.g. after evaluation of a ${list} variable, be sure to use an explicitly quoted argument "$<...>" so that this command receives it as a single <item>" Change-Id: I3f730b767d9b89f5c4aa19272aab03eb12f0edb2 Reviewed-by: Kai Koehne <kai.koehne@qt.io> Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit b5a4ce03a5b486b4e195acdef49285c8505502be)
-rw-r--r--cmake/FindWrapLibClang.cmake2
1 files changed, 1 insertions, 1 deletions
diff --git a/cmake/FindWrapLibClang.cmake b/cmake/FindWrapLibClang.cmake
index 78a22cd04..3c02ac801 100644
--- a/cmake/FindWrapLibClang.cmake
+++ b/cmake/FindWrapLibClang.cmake
@@ -61,7 +61,7 @@ if(TARGET libclang AND ((TARGET clang-cpp AND TARGET LLVM) OR TARGET clangHandle
set(__qt_clang_genex "$<IF:${__qt_clang_genex_condition},clang-cpp;LLVM,clangHandleCXX>")
target_link_libraries(WrapLibClang::WrapLibClang
INTERFACE libclang
- ${__qt_clang_genex}
+ "${__qt_clang_genex}"
Threads::Threads
)