diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-01-27 10:49:35 +0100 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2021-02-03 11:40:00 +0100 |
commit | 0d36e0d0e1374517bd196c74b0f148abfaf1a58a (patch) | |
tree | 8b5d1bbd840b7b3c6b1b2f606fb9926d65df4062 /examples/designer/taskmenuextension/tictactoeplugin.cpp | |
parent | 4a49f40ad8bd56962cc9efea6439a4f9b6ffb9f7 (diff) |
Brush up the taskmenuextension example
When porting the code to Python, some issues showed up.
- Rewrite cellRect() to take the position (reason being
that porting the existing code to Python creates
problems with implicit conversion to float in the division).
- Use plain assignment by operator[] to replace the characters
in the string
- Avoid repeating return types.
- Streamline code.
- Initialize myState member variable.
- Indicate C++ in the tool tip
Task-number: PYSIDE-1455
Change-Id: I62fa61eebaa2eefe8db0842d6a3789bd7cd4257e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'examples/designer/taskmenuextension/tictactoeplugin.cpp')
-rw-r--r-- | examples/designer/taskmenuextension/tictactoeplugin.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/examples/designer/taskmenuextension/tictactoeplugin.cpp b/examples/designer/taskmenuextension/tictactoeplugin.cpp index 45075fe62..5515526bc 100644 --- a/examples/designer/taskmenuextension/tictactoeplugin.cpp +++ b/examples/designer/taskmenuextension/tictactoeplugin.cpp @@ -74,7 +74,7 @@ QString TicTacToePlugin::group() const QString TicTacToePlugin::toolTip() const { - return QString(); + return QStringLiteral("Tic Tac Toe Example, demonstrating class QDesignerTaskMenuExtension (C++)"); } QString TicTacToePlugin::whatsThis() const |